From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbdKUWQd (ORCPT ); Tue, 21 Nov 2017 17:16:33 -0500 Received: from mga04.intel.com ([192.55.52.120]:7034 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751353AbdKUWQc (ORCPT ); Tue, 21 Nov 2017 17:16:32 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,432,1505804400"; d="scan'208";a="8013297" Subject: Re: [PATCH 17/30] x86, kaiser: map debug IDT tables To: Thomas Gleixner References: <20171110193058.BECA7D88@viggo.jf.intel.com> <20171110193138.1185728D@viggo.jf.intel.com> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, moritz.lipp@iaik.tugraz.at, daniel.gruss@iaik.tugraz.at, michael.schwarz@iaik.tugraz.at, richard.fellner@student.tugraz.at, luto@kernel.org, torvalds@linux-foundation.org, keescook@google.com, hughd@google.com, x86@kernel.org From: Dave Hansen Message-ID: Date: Tue, 21 Nov 2017 14:16:27 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/20/2017 12:40 PM, Thomas Gleixner wrote: > On Fri, 10 Nov 2017, Dave Hansen wrote: >> >> +static int kaiser_user_map_ptr_early(const void *start_addr, unsigned long size, >> + unsigned long flags) >> +{ >> + int ret = kaiser_add_user_map(start_addr, size, flags); >> + WARN_ON(ret); >> + return ret; > What's the point of the return value when it is ignored at the call site? I'm dropping this patch, btw. It was unnecessary.