From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752098AbdHJF2s (ORCPT ); Thu, 10 Aug 2017 01:28:48 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:33860 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750837AbdHJF2p (ORCPT ); Thu, 10 Aug 2017 01:28:45 -0400 Subject: Re: [PATCH 1/7] mtd: spi-nor: cadence-quadspi: add a delay in write sequence To: Rob Herring CC: Marek Vasut , Cyrille Pitchen , Santosh Shilimkar , David Woodhouse , Brian Norris , , , , References: <20170801045434.8733-1-vigneshr@ti.com> <20170801045434.8733-2-vigneshr@ti.com> <20170810000831.mtj5w4sgwa56ja24@rob-hp-laptop> From: Vignesh R Message-ID: Date: Thu, 10 Aug 2017 10:58:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170810000831.mtj5w4sgwa56ja24@rob-hp-laptop> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 10 August 2017 05:38 AM, Rob Herring wrote: > On Tue, Aug 01, 2017 at 10:24:28AM +0530, Vignesh R wrote: >> As per 66AK2G02 TRM[1] SPRUHY8F section 11.15.5.3 Indirect Access >> Controller programming sequence, a delay equal to couple QSPI master >> clock(~5ns) is required after setting CQSPI_REG_INDIRECTWR_START bit and >> writing data to the flash. Add a new compatible to handle the couple of >> cycles of delay required in the indirect write sequence, since this >> delay is specific to TI 66AK2G SoC. >> >> [1]http://www.ti.com/lit/ug/spruhy8f/spruhy8f.pdf >> >> Signed-off-by: Vignesh R >> --- >> Documentation/devicetree/bindings/mtd/cadence-quadspi.txt | 1 + >> drivers/mtd/spi-nor/cadence-quadspi.c | 13 +++++++++++++ >> 2 files changed, 14 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt b/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt >> index f248056da24c..fdd511a83511 100644 >> --- a/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt >> +++ b/Documentation/devicetree/bindings/mtd/cadence-quadspi.txt >> @@ -2,6 +2,7 @@ >> >> Required properties: >> - compatible : Should be "cdns,qspi-nor". >> + Should be "ti,k2g-qspi" for TI 66AK2G platform. > > Also, this doesn't indicate that "cdns,qspi-nor" is a fallback as you > have in the dts files. Reformat to 1 valid combination per line. > Agreed, will fix it in v2. -- Regards Vignesh