From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943555AbcJSUux (ORCPT ); Wed, 19 Oct 2016 16:50:53 -0400 Received: from mout.web.de ([212.227.15.14]:54489 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938152AbcJSUuw (ORCPT ); Wed, 19 Oct 2016 16:50:52 -0400 Subject: [PATCH 5/5] blackfin-setup: Combine ten seq_printf() calls into three calls in show_cpuinfo() To: adi-buildroot-devel@lists.sourceforge.net, Rickard Strandqvist , Steven Miao References: <4cd6678e-ebf0-d2f4-0b79-ac33060a6752@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Wed, 19 Oct 2016 22:50:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <4cd6678e-ebf0-d2f4-0b79-ac33060a6752@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:J3YcAPL8LUjNTfECN2ekd0v8XG9U5Bl4d0iweQReW6N/FPqy/PV ebvb/C7KCWkfw0NN4rQCD4HvsTT48pJuwWM3kOnkAsIScklV8y7kB+AX3pqbY8sWy2C47dw cLDPePjr1rUYaKgqqXQkdogmIGEJD2LAdzTHmy9QQvJ7zw41d1XrEPNM+iEEc94svQxwu33 qRu4tYw0N9cMV3BnS6dGg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Kh8FbxAyIsA=:6fcDGGq/4WznqdjeG4Ydr6 O/WfFM6sC0wKV+zElKbjxQhLKJwVhBgAjY91p/zaOrEehms9VZvHbK8YhH7X2sb0J+Da9zTOv 3Ac7rjpb+WNWaYOAQp5D/aAvKapbVg4l0txy9QCvNgIKIe6+k/d9s7Z+q+Ys4SN6Z5j174lOj KRcrNK5tq4iCjqLSLS/Oo3hS65JNhEfLQQIijvRwE4pMLTXF4aev5fx7T4P/TMkTFgxYjOUCk Hm8rFjtdp4icj6jNiNA3b4Iz+BegDcJDrDl2AxpnCIq5+BA/cpjTiF4IDTgE/d+kJEUH+OQDw IZ18D8lEJlmvrjHpYZXu+2Dvd7OoXCkTpuT4JkMJvEjCIj7JnhjrNDx09qeziLYBRWeiOgw7P C/I9Qol2Wp0eJcHOQ+CsVxLmLkEyY5SyScJpL77vFu5sSQFjGXhJLOJoxoskL/pIwFy0OvIhH GBZKyIrQ9oU/qeE9WKLR/7czP/qMw7Nc7/iqqxwa6cIZVWTruUujoYolENTPWXr/wtptxDvvI ziBfUDsterYjw/5jmejXjokqSCXo5zfNaHtz161KJSghywcJCdGAcgnjsBNxP3n7+b1wVtyrd zwPkKVpXrizqodbqyBwJAgehV0Yr/4NoOl1cdf3fEuf76OtrRFy6Z2zCr66HSIlMxGfSoAICc oeteT962OqNYgTWYCVfCsbfE03g+iYpLXAm9MVLRjtl9fRmBjk/lfUH833+kFMiNtNbAAqYus BZlC1ILcSJ9vLChl5altwGE8kErx7JqpviwopE9H5vo0qp8xK4DtELc9sXqzBY6Er0xtsTka+ Rok07c3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 19 Oct 2016 22:11:32 +0200 Some data were printed into a sequence by ten separate function calls. Print the same data by three function calls instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/blackfin/kernel/setup.c | 64 +++++++++++++++++++++++++------------------- 1 file changed, 36 insertions(+), 28 deletions(-) diff --git a/arch/blackfin/kernel/setup.c b/arch/blackfin/kernel/setup.c index fdd9168..250e645 100644 --- a/arch/blackfin/kernel/setup.c +++ b/arch/blackfin/kernel/setup.c @@ -1360,26 +1360,29 @@ static int show_cpuinfo(struct seq_file *m, void *v) if ((cpudata->imemctl & (IMC | ENICPLB)) != (IMC | ENICPLB)) icache_size = 0; - seq_printf(m, "cache size\t: %d KB(L1 icache) " - "%d KB(L1 dcache) %d KB(L2 cache)\n", - icache_size, dcache_size, 0); - seq_printf(m, "%s\n", cache); - seq_printf(m, "external memory\t: " + seq_printf(m, + "cache size\t: %d KB(L1 icache) %d KB(L1 dcache) %d KB(L2 cache)\n" + "%s\n" + "external memory\t: " #if defined(CONFIG_BFIN_EXTMEM_ICACHEABLE) "cacheable" #else "uncacheable" #endif - " in instruction cache\n"); - seq_printf(m, "external memory\t: " + " in instruction cache\n" + "external memory\t: " #if defined(CONFIG_BFIN_EXTMEM_WRITEBACK) - "cacheable (write-back)" + "cacheable (write-back)" #elif defined(CONFIG_BFIN_EXTMEM_WRITETHROUGH) - "cacheable (write-through)" + "cacheable (write-through)" #else - "uncacheable" + "uncacheable" #endif - " in data cache\n"); + " in data cache\n", + icache_size, + dcache_size, + 0, + cache); if (icache_size) seq_printf(m, "icache setup\t: %d Sub-banks/%d Ways, %d Lines/Way\n", @@ -1403,31 +1406,36 @@ static int show_cpuinfo(struct seq_file *m, void *v) return 0; if (L2_LENGTH) { - seq_printf(m, "L2 SRAM\t\t: %dKB\n", L2_LENGTH/0x400); - seq_printf(m, "L2 SRAM\t\t: " + seq_printf(m, + "L2 SRAM\t\t: %dKB\n" + "L2 SRAM\t\t: " #if defined(CONFIG_BFIN_L2_ICACHEABLE) - "cacheable" + "cacheable" #else - "uncacheable" + "uncacheable" #endif - " in instruction cache\n"); - seq_printf(m, "L2 SRAM\t\t: " + " in instruction cache\n" + "L2 SRAM\t\t: " #if defined(CONFIG_BFIN_L2_WRITEBACK) - "cacheable (write-back)" + "cacheable (write-back)" #elif defined(CONFIG_BFIN_L2_WRITETHROUGH) - "cacheable (write-through)" + "cacheable (write-through)" #else - "uncacheable" + "uncacheable" #endif - " in data cache\n"); + " in data cache\n", + L2_LENGTH / 0x400); } - seq_printf(m, "board name\t: %s\n", bfin_board_name); - seq_printf(m, "board memory\t: %ld kB (0x%08lx -> 0x%08lx)\n", - physical_mem_end >> 10, 0ul, physical_mem_end); - seq_printf(m, "kernel memory\t: %d kB (0x%08lx -> 0x%08lx)\n", - ((int)memory_end - (int)_rambase) >> 10, - _rambase, memory_end); - + seq_printf(m, + "board name\t: %s\n" + "board memory\t: %ld kB (0x%08lx -> 0x%08lx)\n" + "kernel memory\t: %d kB (0x%08lx -> 0x%08lx)\n", + bfin_board_name, + physical_mem_end >> 10, + 0ul, + physical_mem_end, + ((int)memory_end - (int)_rambase) >> 10, + _rambase, memory_end); return 0; } -- 2.10.1