From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794912877; b=WDUndoqgu2eK9+G03SxjDokFfjLHJNpbG8bbaCxY2tXvMCzjZoiSvlh0SroiKy7zCxVT PmGVYF0Ud7Q763FB5RFpOdyIkKShOJhdmiHYaiSKaXRKI8xtGVP5G+Cr3MKfF05EfrvG4 UoQxRlyastt0j7R5XcMIkUoHdsHjOnh+wTepwbA70K1tIepZUkG1KUiwuvKMNfzF4w7Sy KFuxNf6DdGQ/vrRkK0VDzzE+k38ta769hgVbLY1lCaAnzc6JXvEhTeqXMwcJU9UxebR7+ Rn7hEa1d4p4PrQSNWsDUYOtSlH+hL+MA3bkYAuThj/t7hZDRhzt5Enn1qg14nilKjgA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794912877; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=+Tfg1ibNVybgEeeF48UPE9BTEozdfEvCnWQy9W1oTw4=; b=e/ka6u6ExpSe/wGUPnGrrxHDiqqx3YuR3o5OiLBg8gw1W3fmLwqSocVHS5+gOMFkBNjX +L1aYyjzLZKRo5D4ITIsbnSIHiwCHhCToKZ2gsgROixFWc2uRE+DQeXvLMNkBKETpu3lu M1cB2avyKvEH/Y4gT5ODep6poUjACTunLAHSs2ZTWX/dfHoyMOTPPOYPzPiO5ssUihe3E nUPjpyziR13rw8SZ2cPiRl9p4zLw0EFyis4KTpJVAc8CeZR/7pbYCRshrztGsRk2m9KoG AFxfmRYR7fes1O9LMWTDpv7djuAJ13LLpm3X6Fl5Oh/xhTrWQ4T+pRP3lWyN7ji+IWw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=aZP1KsOo; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF88B606A31C for ; Tue, 17 Nov 2026 10:54:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=aZP1KsOo Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13C6E1F000C8; Tue, 17 Nov 2026 10:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794912876; bh=+Tfg1ibNVybgEeeF48UPE9BTEozdfEvCnWQy9W1oTw4=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=aZP1KsOofZXA08D4wdLGepi9PdvJLppDJzJsU6p+skQN1H20zQrbdw43C8f6G8S8i AibDf1dGAP/t2RPsnkYz9X4moOWgFDXV2/6th8B41ZkkvJklEDopaBUXqD6KY1AaeA OvPQNq3RzuMOVkUgdlRBlbIOTtl6FUTtLyfVlWJzsUtR6dYLO2tBdqdijCchh3+h6g moj0KiL7FFnR+o760bFIRNDHGLRXhhnaFq0FhXidI8tEcDswkKnAtnKlvvXmdSes24 tYkGi2wjsWCa5ep+HjhgGKItZB/zBQ9SNKN2BUjF88bHay7fAMWDevuxIR7IugmdL0 FqrEZOV5Hpv2g== Message-ID: Date: Tue, 17 Nov 2026 11:54:28 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fork: mark memcpy() in dup_mm() with data_race() To: Muhammad Haris Awan Cc: Andrew Morton , Ingo Molnar , Peter Zijlstra , Kees Cook , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , linux-mm@kvack.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <179489519663.1444496.15875846661591982934@icloud.com> <0b565b9c-1462-4fed-8836-9a7d08e4b861@kernel.org> <179491109101.4015489.11185824873441987133@icloud.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <179491109101.4015489.11185824873441987133@icloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/17/26 11:24, Muhammad Haris Awan wrote: > Hi David, > > Reclaim isn't touching the new mm being initialized (which isn't added to > mm_list->fifo until lru_gen_add_mm() at the end of copy_process()). Oh, that makes sense. > > The KCSAN read is on oldmm inside dup_mm()'s memcpy(mm, oldmm, sizeof(*mm)): > oldmm is an already-live mm sitting on mm_list->fifo, so when an adjacent > exiting mm calls lru_gen_del_mm(), list_del_init() updates > oldmm->lru_gen.list.next/.prev under mm_list->lock. > > Since oldmm is live, lru_gen_del_mm() has to update those list pointers. > The alternatives in dup_mm() would be taking mm_list->lock (plus > mmlist_lock) during fork, or avoiding copying oldmm->lru_gen / oldmm->mmlist > (awkward because struct mm_struct uses __randomize_layout). Wrapping the > memcpy() in data_race() avoids locking on fork and matches dup_vma() in > mm/vma_init.c. Yeah, the only concern I have is that this is the big hammer for any members, not just the ones where we expect races. We hold the mmap lock in write mode, so one would assume that nothing can rally modify it. Well, besides these list exceptions. Let's see what others have to say, but I guess this is fine then, although a bit suboptimal. -- Cheers, David