mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: Xie Yongji <xieyongji@bytedance.com>,
	jasowang@redhat.com, mst@redhat.com, xiaodong.liu@intel.com,
	maxime.coquelin@redhat.com, stefanha@redhat.com
Cc: songmuchun@bytedance.com,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/5] vduse: Support using userspace pages as bounce buffer
Date: Fri, 19 Aug 2022 08:01:42 +0200	[thread overview]
Message-ID: <f75cb32b7c262fe852c53544034f5b6047d29b65.camel@gmx.de> (raw)
In-Reply-To: <20220803045523.23851-4-xieyongji@bytedance.com>

Greetings,

On Wed, 2022-08-03 at 12:55 +0800, Xie Yongji wrote:
>
> diff --git a/drivers/vdpa/vdpa_user/iova_domain.h b/drivers/vdpa/vdpa_user/iova_domain.h
> index 2722d9b8e21a..4e0e50e7ac15 100644
> --- a/drivers/vdpa/vdpa_user/iova_domain.h
> +++ b/drivers/vdpa/vdpa_user/iova_domain.h
> @@ -14,6 +14,7 @@
>  #include <linux/iova.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/vhost_iotlb.h>
> +#include <linux/rwlock.h>
                   ^^^^^^^^

Erm, that should be spinlock.h.

#ifndef __LINUX_RWLOCK_H
#define __LINUX_RWLOCK_H

#ifndef __LINUX_SPINLOCK_H
# error "please don't include this file directly"
#endif

This belated comment inspired by PREEMPT_RT build meeting the above :)

	-Mike

  reply	other threads:[~2022-08-19  6:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-03  4:55 [PATCH v5 0/5] VDUSE: Support registering userspace memory " Xie Yongji
2022-08-03  4:55 ` [PATCH v5 1/5] vduse: Remove unnecessary spin lock protection Xie Yongji
2022-08-03  4:55 ` [PATCH v5 2/5] vduse: Use memcpy_{to,from}_page() in do_bounce() Xie Yongji
2022-08-03  4:55 ` [PATCH v5 3/5] vduse: Support using userspace pages as bounce buffer Xie Yongji
2022-08-19  6:01   ` Mike Galbraith [this message]
2022-08-19  6:14     ` Yongji Xie
2022-08-03  4:55 ` [PATCH v5 4/5] vduse: Support registering userspace memory for IOVA regions Xie Yongji
2022-08-03  4:55 ` [PATCH v5 5/5] vduse: Support querying information of " Xie Yongji
2022-08-04  4:53   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f75cb32b7c262fe852c53544034f5b6047d29b65.camel@gmx.de \
    --to=efault@gmx.de \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=mst@redhat.com \
    --cc=songmuchun@bytedance.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xiaodong.liu@intel.com \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®