From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7B19C2BB1D for ; Wed, 18 Mar 2020 01:43:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 847F620738 for ; Wed, 18 Mar 2020 01:43:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=massaru-org.20150623.gappssmtp.com header.i=@massaru-org.20150623.gappssmtp.com header.b="tsA75bvN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727282AbgCRBnM (ORCPT ); Tue, 17 Mar 2020 21:43:12 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:40593 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727238AbgCRBnL (ORCPT ); Tue, 17 Mar 2020 21:43:11 -0400 Received: by mail-qt1-f196.google.com with SMTP id n5so19415511qtv.7 for ; Tue, 17 Mar 2020 18:43:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=massaru-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=adfBoclYKVZNMNefhSpixH6B98UG3x3vyleViU9e6t0=; b=tsA75bvNsVxlydE50EtN3v3OV43jLUZwBeqU7K9f4CJgdny+lloa8g8Ai3CcaLbxVj XQFVCtUY+yTbJGV7t6u6vdYlw1NrMdxKzI2b/VrwWKJ9FiMGUj62BqpmOy4bWuSbnLNQ Xw4Pj7IdhlFn6Gp/RlPuNp+bamLXdGS1Wx1SXB4rxRcxKdTU4PWpos/KmtXwsgPOgkHW d5etZGwMaclJi2PH5BM+JfxAHBxa0dbNKnzNHQWJIh4PPsZATsvH09l/vkQUuOyAy9LB c2hmVyINrHQSWbnXSB0clhCwlASTy7ZvaXIjND9IM16bO28/37vuq4tF0IK550VPgQ1v z9pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=adfBoclYKVZNMNefhSpixH6B98UG3x3vyleViU9e6t0=; b=ot45xVGwvumONfDgSk3hsMk0GKymY9I97/aqXa+1hmsrWXwv+MmnCGgFjNeSs+zz7m z/UBsjot8W3tADzC3s+X+1G+R6FeX3G8wnl6GYnqBhtIYrec9I62MeJwzQILPlsOWMLQ q3YxNrWn89277SxWrxJk3ljDyUuvB6gc1WQm7fsShCWSaoe6F2VIJCECMo19xEP1S//F nqD7TVYbICJL4onAy/R6xWMQsV5QO8ZeLdWJxWNuWdNF5zluYwcf5SUhYTNGem09NKDA ahRf8yIi0ip/Na8umWqkBHttzqIJTddXz9Hf1mYEm71UoMiDtaPzYWLMStHSMgA1eaVN NGCw== X-Gm-Message-State: ANhLgQ07k2tVN/SIn3/QC9TvCQXZY6pEp9mm274h+GrBk7H3wFDyJdEn 3akIT3YUOIRozVEWnqpJC+VG7Q== X-Google-Smtp-Source: ADFU+vsvOxgc6z2IjrWovw/hSbhdYVegvhWE7xjTOoafRhx9mCRw45z1VgMOMz3Vo9eqSmJZfdnEjg== X-Received: by 2002:aed:314c:: with SMTP id 70mr2006023qtg.334.1584495788809; Tue, 17 Mar 2020 18:43:08 -0700 (PDT) Received: from bbking.lan ([2804:14c:4a5:36c::cd2]) by smtp.gmail.com with ESMTPSA id m1sm3740883qtm.22.2020.03.17.18.43.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2020 18:43:08 -0700 (PDT) From: Vitor Massaru Iha Cc: willy@infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org Subject: [PATCH 1/2] xarray: Add identifier names for function definition arguments Date: Tue, 17 Mar 2020 22:43:02 -0300 Message-Id: X-Mailer: git-send-email 2.21.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix several checkpatch warnings such as: WARNING: function definition argument 'struct xarray *' should also have an identifier name +void *xa_load(struct xarray *, unsigned long index); Signed-off-by: Vitor Massaru Iha --- include/linux/xarray.h | 87 +++++++++++++++++++++--------------------- 1 file changed, 44 insertions(+), 43 deletions(-) diff --git a/include/linux/xarray.h b/include/linux/xarray.h index f73e1775ded0..a7dec1ec0967 100644 --- a/include/linux/xarray.h +++ b/include/linux/xarray.h @@ -344,21 +344,21 @@ struct xarray { */ #define DEFINE_XARRAY_ALLOC1(name) DEFINE_XARRAY_FLAGS(name, XA_FLAGS_ALLOC1) -void *xa_load(struct xarray *, unsigned long index); -void *xa_store(struct xarray *, unsigned long index, void *entry, gfp_t); -void *xa_erase(struct xarray *, unsigned long index); -void *xa_store_range(struct xarray *, unsigned long first, unsigned long last, - void *entry, gfp_t); -bool xa_get_mark(struct xarray *, unsigned long index, xa_mark_t); -void xa_set_mark(struct xarray *, unsigned long index, xa_mark_t); -void xa_clear_mark(struct xarray *, unsigned long index, xa_mark_t); -void *xa_find(struct xarray *xa, unsigned long *index, - unsigned long max, xa_mark_t) __attribute__((nonnull(2))); -void *xa_find_after(struct xarray *xa, unsigned long *index, - unsigned long max, xa_mark_t) __attribute__((nonnull(2))); -unsigned int xa_extract(struct xarray *, void **dst, unsigned long start, - unsigned long max, unsigned int n, xa_mark_t); -void xa_destroy(struct xarray *); +void *xa_load(struct xarray *xa, unsigned long index); +void *xa_store(struct xarray *xa, unsigned long index, void *entry, gfp_t gfp); +void *xa_erase(struct xarray *xa, unsigned long index); +void *xa_store_range(struct xarray *xa, unsigned long first, unsigned long last, + void *entry, gfp_t gfp); +bool xa_get_mark(struct xarray *xa, unsigned long index, xa_mark_t mark); +void xa_set_mark(struct xarray *xa, unsigned long index, xa_mark_t mark); +void xa_clear_mark(struct xarray *xa, unsigned long index, xa_mark_t mark); +void *xa_find(struct xarray *xa, unsigned long *index, unsigned long max, + xa_mark_t filter) __attribute__((nonnull(2))); +void *xa_find_after(struct xarray *xa, unsigned long *index, unsigned long max, + xa_mark_t filter) __attribute__((nonnull(2))); +unsigned int xa_extract(struct xarray *xa, void **dst, unsigned long start, + unsigned long max, unsigned int n, xa_mark_t filter); +void xa_destroy(struct xarray *xa); /** * xa_init_flags() - Initialise an empty XArray with flags. @@ -551,18 +551,19 @@ static inline bool xa_marked(const struct xarray *xa, xa_mark_t mark) * may also re-enable interrupts if the XArray flags indicate the * locking should be interrupt safe. */ -void *__xa_erase(struct xarray *, unsigned long index); -void *__xa_store(struct xarray *, unsigned long index, void *entry, gfp_t); -void *__xa_cmpxchg(struct xarray *, unsigned long index, void *old, - void *entry, gfp_t); -int __must_check __xa_insert(struct xarray *, unsigned long index, - void *entry, gfp_t); -int __must_check __xa_alloc(struct xarray *, u32 *id, void *entry, - struct xa_limit, gfp_t); -int __must_check __xa_alloc_cyclic(struct xarray *, u32 *id, void *entry, - struct xa_limit, u32 *next, gfp_t); -void __xa_set_mark(struct xarray *, unsigned long index, xa_mark_t); -void __xa_clear_mark(struct xarray *, unsigned long index, xa_mark_t); +void *__xa_erase(struct xarray *xa, unsigned long index); +void *__xa_store(struct xarray *xa, unsigned long index, + void *entry, gfp_t gfp); +void *__xa_cmpxchg(struct xarray *xa, unsigned long index, void *old, + void *entry, gfp_t gfp); +int __must_check __xa_insert(struct xarray *xa, unsigned long index, + void *entry, gfp_t gfp); +int __must_check __xa_alloc(struct xarray *xa, u32 *id, void *entry, + struct xa_limit limit, gfp_t gfp); +int __must_check __xa_alloc_cyclic(struct xarray *xa, u32 *id, void *entry, + struct xa_limit limit, u32 *next, gfp_t gfp); +void __xa_set_mark(struct xarray *xa, unsigned long index, xa_mark_t mark); +void __xa_clear_mark(struct xarray *xa, unsigned long index, xa_mark_t mark); /** * xa_store_bh() - Store this entry in the XArray. @@ -1137,8 +1138,8 @@ struct xa_node { }; }; -void xa_dump(const struct xarray *); -void xa_dump_node(const struct xa_node *); +void xa_dump(const struct xarray *xa); +void xa_dump_node(const struct xa_node *node); #ifdef XA_DEBUG #define XA_BUG_ON(xa, x) do { \ @@ -1489,21 +1490,21 @@ static inline bool xas_retry(struct xa_state *xas, const void *entry) return true; } -void *xas_load(struct xa_state *); -void *xas_store(struct xa_state *, void *entry); -void *xas_find(struct xa_state *, unsigned long max); -void *xas_find_conflict(struct xa_state *); +void *xas_load(struct xa_state *xas); +void *xas_store(struct xa_state *xas, void *entry); +void *xas_find(struct xa_state *xas, unsigned long max); +void *xas_find_conflict(struct xa_state *xas); -bool xas_get_mark(const struct xa_state *, xa_mark_t); -void xas_set_mark(const struct xa_state *, xa_mark_t); -void xas_clear_mark(const struct xa_state *, xa_mark_t); -void *xas_find_marked(struct xa_state *, unsigned long max, xa_mark_t); -void xas_init_marks(const struct xa_state *); +bool xas_get_mark(const struct xa_state *xas, xa_mark_t mark); +void xas_set_mark(const struct xa_state *xas, xa_mark_t mark); +void xas_clear_mark(const struct xa_state *xas, xa_mark_t mark); +void *xas_find_marked(struct xa_state *xas, unsigned long max, xa_mark_t mark); +void xas_init_marks(const struct xa_state *xas); -bool xas_nomem(struct xa_state *, gfp_t); -void xas_pause(struct xa_state *); +bool xas_nomem(struct xa_state *xas, gfp_t gfp); +void xas_pause(struct xa_state *xas); -void xas_create_range(struct xa_state *); +void xas_create_range(struct xa_state *xas); /** * xas_reload() - Refetch an entry from the xarray. @@ -1721,8 +1722,8 @@ enum { #define xas_for_each_conflict(xas, entry) \ while ((entry = xas_find_conflict(xas))) -void *__xas_next(struct xa_state *); -void *__xas_prev(struct xa_state *); +void *__xas_next(struct xa_state *xas); +void *__xas_prev(struct xa_state *xas); /** * xas_prev() - Move iterator to previous index. -- 2.21.1