Re: [PATCH v3] platform/x86: hp-wmi: add support for OMEN 16-am2xxx boards

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3437 bytes --]

On Sat, 24 Oct 2026, Shuwen Bao wrote:

> 在 2026年10月15日星期四 中国标准时间 22:28:33，Ilpo Järvinen 写道：
> > On Wed, 07 Oct 2026 11:08:36 +0800, Shuwen Bao wrote:
> > > The HP HyperX OMEN 16-am2xxx (DMI board 8F1C, 26C1 platform cycle,
> > > Arrow Lake-HXR) is listed in the OMEN Command Center device
> > > capability table with DisplayName "HyperX OMEN 16" and the
> > > "PerformanceControl" feature, but is missing from the kernel's
> > > hp_wmi_feature_boards[] list.
> > > 
> > > Add 8F1C to the hp_wmi_feature_boards[] list, using
> > > omen_v1_legacy_board_params as driver_data.
> > > 
> > > [...]
> > 
> > Thank you for your contribution, it has been applied to my local
> > review-ilpo-next branch. Note it will show up in the public
> > platform-drivers-x86/review-ilpo-next branch only once I've pushed my
> > local branch there, which might take a while.
> > 
> > FYI [if applicable to your patch], as per Linus' policy change, also
> > fixes are mostly routed through for-next unless the fix is for a
> > commit introduced in the most recent cycle or is clearly a regression
> > fix.
> > 
> > The list of commits applied:
> > [1/1] platform/x86: hp-wmi: add support for OMEN 16-am2xxx boards
> >       commit: 2cd10a35f3f09c49698956d32c6374fbdc03245d
> > 
> > --
> >  i.
> 
> Hi Krishna, Ilpo,
> 
> Thank you for applying the patch. However, after further extended testing, 
> I noticed a regression on this hardware. 
> 
> Specifically, the board automatically reverts from performance mode back 
> to balanced mode after a period of time (it seems like the time is not 
> constant), which resembles the behavior of a timed thermal board. 
> 
> This doesn't seem to be a thermal threshold or PL1/PL2 limitation, 
> because manually switching the profile back to balanced and then to 
> performance will re-enable performance mode successfully.
> 
> I am still investigating the root cause and am currently unsure how to 
> properly fix this yet. I'm currently testing adding 8F1C to 
> omen_timed_thermal_profile_boards as a fix.
>
> I haven't looked deeply into hp-wmi.c before, so if adding it to that 
> array is not the correct or intended way to handle this, please let me 
> know.

Hi,

It certainly sounds like a similar problem. I'm not sure if the code 
related to omen_timed_thermal_profile_boards is hooked though with this 
board because it requires is_omen_thermal_profile() returning true.

Some other drivers do profile keepalive by writing the same profile 
periodically if nothing has changed the profile for a while, that would 
seem easier/more generic solution than finding timer offset the current 
solution uses.

If you need to change something it would be nice to generalize this 
so that the keepalive is not bound to a particular submodel category. 
The driver is slowly moving towards that for all models so that we'd 
have only one central dmi matching table where the struct would hold all 
necessary info/quirk details.

> @Ilpo, since commit 2cd10a35f3f0 ("platform/x86: hp-wmi: add support for 
> OMEN 16-am2xxx boards") is already in review-ilpo-next, would you prefer 
> to revert it for now until I figure out a proper solution, or should we 
> keep it as-is while I investigate?

I think I'll keep the change as it still works to an extent so it seems 
better than nothing.

-- 
 i.