From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 547CE235BE3 for ; Mon, 13 Jan 2025 10:00:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736762453; cv=none; b=khgFKZgwXzXnF6K0DrMgYG/99lHAy9ChdCm3a8DO/Fbb1wQRd1M7l7afae8bv7x86Kw9sMgbhBdSTDFTqfGhwHKwLcw00pw3Cm7z1Nm4xT9T95sc2DCndlN03tnf55FBf4rQjXkD24CeaPv9i7NtRCj4KdVbza/nrhXdnO1pLHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736762453; c=relaxed/simple; bh=VCo20O+HBITawCHWMtnVZM1Kf1BOUrqoQbU+cA2mvEM=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=r/Yc83iUyUjLu29IxtDBxI8Cm7HkjUuC6pTucqkwg00CIXpwuvKzckiNW+j8I/AkTEXRqw90/BwNwQJXxXHmxRSsTrCf1iktj73fQBq5+OvhcLpfXRCxb0FsAw83bnhwPGUhBSxPABh4wpA3wChWQHiv9GYGySo5RE8z+UzlaLY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=i/sP3WMJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="i/sP3WMJ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50D4WV0D007701; Mon, 13 Jan 2025 10:00:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ne3ZM4cl0VvRv4Q0cmPhXFnk41F7Udz9C7qYabYbqxM=; b=i/sP3WMJNCZ4TCvF fuazr63jDLMqWBYQd4ynR5D1hHTyMrD2mzxdh3RnDv4JEjWE0SJ5g2mRfMzxTeRq z4hiYzi+6uc9RWPjN24md+JIB9rbIx3L5MEmYo80w7nUkEYeZ1F+666qmxDh8GgB vjJBq3YAv1hPT8G8BHVH9c+2VR65WOwe/1jW8Ha4RvuKEQPxVMz4gcPYVXLb/jx9 cSTizpNDZPZKgDm9I8RPvQ4QdXzDuFV5NiwsG2Q3UgpkrplcQb1Bc8Js+9ugUwi1 m1xPiN+Ny2SFnxHWrBcqBIqtP5rb424jzeSy62Rqdx0aRL2MhkwpczKpQdt85AY0 jHc8rQ== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 444uw6gqu7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Jan 2025 10:00:45 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 50DA0ji6008314 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Jan 2025 10:00:45 GMT Received: from [10.216.23.164] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 13 Jan 2025 02:00:43 -0800 Message-ID: Date: Mon, 13 Jan 2025 15:30:39 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] i3c: Remove unused i3c_device_do_setdasa To: Alexandre Belloni , CC: , References: <20241221143418.86012-1-linux@treblig.org> <202501122254082b225acf@mail.local> Content-Language: en-US From: Mukesh Kumar Savaliya In-Reply-To: <202501122254082b225acf@mail.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: CffRi1iRXZx4OYyqDvHtFhfagg-gTXnl X-Proofpoint-ORIG-GUID: CffRi1iRXZx4OYyqDvHtFhfagg-gTXnl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxlogscore=999 mlxscore=0 suspectscore=0 bulkscore=0 adultscore=0 malwarescore=0 phishscore=0 impostorscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501130084 On 1/13/2025 4:24 AM, Alexandre Belloni wrote: > Hello, > > On 21/12/2024 14:34:18+0000, linux@treblig.org wrote: >> From: "Dr. David Alan Gilbert" >> >> i3c_device_do_setdasa() was added in 2022 as part of >> commit 672825cd2823 ("i3c: export SETDASA method") >> >> but has been unused. >> >> It calls i3c_dev_setdasa_locked() which is now also unused. >> >> Remove them both. I think there might be few drivers in future, which can use. The function looks good to be used. >> (This is effectively a revert of 672825cd2823). >> > > > Yeah, i guess this just means that we didn't see the device driver yet. > I'm going to keep those function around for now. > Agree here. We should keep this function as is. >> Signed-off-by: Dr. David Alan Gilbert >> --- >> drivers/i3c/device.c | 20 -------------------- >> drivers/i3c/internals.h | 1 - >> drivers/i3c/master.c | 19 ------------------- >> include/linux/i3c/device.h | 2 -- >> 4 files changed, 42 deletions(-) >> >> diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c >> index e80e48756914..984976f28314 100644 >> --- a/drivers/i3c/device.c >> +++ b/drivers/i3c/device.c >> @@ -54,26 +54,6 @@ int i3c_device_do_priv_xfers(struct i3c_device *dev, >> } >> EXPORT_SYMBOL_GPL(i3c_device_do_priv_xfers); >> >> -/** >> - * i3c_device_do_setdasa() - do I3C dynamic address assignement with >> - * static address >> - * >> - * @dev: device with which the DAA should be done >> - * >> - * Return: 0 in case of success, a negative error core otherwise. >> - */ >> -int i3c_device_do_setdasa(struct i3c_device *dev) >> -{ >> - int ret; >> - >> - i3c_bus_normaluse_lock(dev->bus); >> - ret = i3c_dev_setdasa_locked(dev->desc); >> - i3c_bus_normaluse_unlock(dev->bus); >> - >> - return ret; >> -} >> -EXPORT_SYMBOL_GPL(i3c_device_do_setdasa); >> - >> /** >> * i3c_device_get_info() - get I3C device information >> * >> diff --git a/drivers/i3c/internals.h b/drivers/i3c/internals.h >> index 433f6088b7ce..842e1a865877 100644 >> --- a/drivers/i3c/internals.h >> +++ b/drivers/i3c/internals.h >> @@ -13,7 +13,6 @@ >> void i3c_bus_normaluse_lock(struct i3c_bus *bus); >> void i3c_bus_normaluse_unlock(struct i3c_bus *bus); >> >> -int i3c_dev_setdasa_locked(struct i3c_dev_desc *dev); >> int i3c_dev_do_priv_xfers_locked(struct i3c_dev_desc *dev, >> struct i3c_priv_xfer *xfers, >> int nxfers); >> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c >> index 42310c9a00c2..000187339400 100644 >> --- a/drivers/i3c/master.c >> +++ b/drivers/i3c/master.c >> @@ -2916,25 +2916,6 @@ void i3c_master_unregister(struct i3c_master_controller *master) >> } >> EXPORT_SYMBOL_GPL(i3c_master_unregister); >> >> -int i3c_dev_setdasa_locked(struct i3c_dev_desc *dev) >> -{ >> - struct i3c_master_controller *master; >> - >> - if (!dev) >> - return -ENOENT; >> - >> - master = i3c_dev_get_master(dev); >> - if (!master) >> - return -EINVAL; >> - >> - if (!dev->boardinfo || !dev->boardinfo->init_dyn_addr || >> - !dev->boardinfo->static_addr) >> - return -EINVAL; >> - >> - return i3c_master_setdasa_locked(master, dev->info.static_addr, >> - dev->boardinfo->init_dyn_addr); >> -} >> - >> int i3c_dev_do_priv_xfers_locked(struct i3c_dev_desc *dev, >> struct i3c_priv_xfer *xfers, >> int nxfers) >> diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h >> index 0a8a44ac2f02..f4e924c179d7 100644 >> --- a/include/linux/i3c/device.h >> +++ b/include/linux/i3c/device.h >> @@ -301,8 +301,6 @@ int i3c_device_do_priv_xfers(struct i3c_device *dev, >> struct i3c_priv_xfer *xfers, >> int nxfers); >> >> -int i3c_device_do_setdasa(struct i3c_device *dev); >> - >> void i3c_device_get_info(const struct i3c_device *dev, struct i3c_device_info *info); >> >> struct i3c_ibi_payload { >> -- >> 2.47.1 >> >