From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0C2F8189B84 for ; Tue, 14 Apr 2026 13:31:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776173477; cv=none; b=BQ4pleDIShaYs/BibDTMaCPcTffpxFleGTXhaMVeclRfsP3MHvKhCPR118mjdCEUq///frnuWrL8c/8dYEoWua5QwXFwEtf0yXM/MT4uF5frk18Eezb6EP21kLeB42Gx/jGFE7/4hGmkYS7DrkGC+kMWNHCoiWRwQPHVJg8nCB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776173477; c=relaxed/simple; bh=3tK6M2VAY67sZVBwbr7Iq6/6sbKfCk+1QBc/ADPvwg4=; h=Message-ID:Date:MIME-Version:Subject:Cc:References:From: In-Reply-To:Content-Type; b=XQxo/gSlWTjdx+fjUFMPkkxHa10U2GSj7wu5Kh2CTU28ybqVOQP/c6CLBb8tVMzjzi8wbicLzoE5ZTgaxNMo5TJpdlaBLpTB/6nbLTgxkYvVqHZBDPECFUM2w1DoPFYlEEH/KekOgS+iflvT4GHJk0QgcFLSb0IfJJ9boC2UTA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=g05Z+H9Y; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="g05Z+H9Y" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8ED0E4E8A; Tue, 14 Apr 2026 06:31:09 -0700 (PDT) Received: from [10.1.196.46] (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3CAA23F7B4; Tue, 14 Apr 2026 06:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776173475; bh=3tK6M2VAY67sZVBwbr7Iq6/6sbKfCk+1QBc/ADPvwg4=; h=Date:Subject:Cc:References:From:In-Reply-To:From; b=g05Z+H9Y5zCAfxxsCMLAye3oMcFUXL7MA899/SOhlndi/DbGbg1e2kDInXzjWGDQ2 vZQdgTd2iz77PALwwMiotIRofahX+pXMm26oUBFzNhx5siVKf/oZaoEm1V7+9vjbuJ v7Z3JR16kMgg5SO3/304eUwitzA/AbqASXX2yaYI= Message-ID: Date: Tue, 14 Apr 2026 14:31:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Thunderbird Daily Subject: Re: [PATCH v1 1/2] arm_mpam: resctrl: Fix broken error path in mpam_resctrl_alloc_domain() Cc: Dan Carpenter , Dan Carpenter , James Morse , Reinette Chatre , Fenghua Yu , lkml , linux-arm-kernel References: <20260414132758.196874-1-ben.horgan@arm.com> <20260414132758.196874-2-ben.horgan@arm.com> Content-Language: en-US From: Ben Horgan In-Reply-To: <20260414132758.196874-2-ben.horgan@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Apologies, I just sent the same patch twice with different subjects. This one can be ignored. Thanks, Ben On 4/14/26 14:27, Ben Horgan wrote: > Dan Carpenter reports that, in mpam_resctrl_alloc_domain(), any_mon_comp is > used in an 'if' condition when it may be uninitialized. Initialize it to > NULL so that the check behaves correctly when no monitor components are > found. > > Reported-by: Dan Carpenter > Fixes: 264c285999fc ("arm_mpam: resctrl: Add monitor initialisation and domain boilerplate") > Signed-off-by: Ben Horgan > --- > drivers/resctrl/mpam_resctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/resctrl/mpam_resctrl.c b/drivers/resctrl/mpam_resctrl.c > index a9938006d0e6..d80df486a313 100644 > --- a/drivers/resctrl/mpam_resctrl.c > +++ b/drivers/resctrl/mpam_resctrl.c > @@ -1399,7 +1399,7 @@ mpam_resctrl_alloc_domain(unsigned int cpu, struct mpam_resctrl_res *res) > } > > if (r->mon_capable) { > - struct mpam_component *any_mon_comp; > + struct mpam_component *any_mon_comp = NULL; > struct mpam_resctrl_mon *mon; > enum resctrl_event_id eventid; >