From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 797ADC31E51 for ; Tue, 18 Jun 2019 08:38:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57FC320B1F for ; Tue, 18 Jun 2019 08:38:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729177AbfFRIir (ORCPT ); Tue, 18 Jun 2019 04:38:47 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:59772 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728818AbfFRIiq (ORCPT ); Tue, 18 Jun 2019 04:38:46 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 83956260DF9 Subject: Re: [PATCH 1/2] platform/chrome: wilco_ec: Fix unreleased lock in event_read() To: Nick Crews , bleung@chromium.org Cc: linux-kernel@vger.kernel.org, dlaurie@chromium.org, djkurtz@chromium.org, dtor@google.com, sjg@chromium.org, kernel-janitors@vger.kernel.org, dan.carpenter@oracle.com References: <20190614205631.90222-1-ncrews@chromium.org> From: Enric Balletbo i Serra Message-ID: Date: Tue, 18 Jun 2019 10:38:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190614205631.90222-1-ncrews@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/6/19 22:56, Nick Crews wrote: > When copying an event to userspace failed, the event queue > lock was never released. This fixes that. > > Reported-by: Dan Carpenter > Signed-off-by: Nick Crews > --- > drivers/platform/chrome/wilco_ec/event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/chrome/wilco_ec/event.c b/drivers/platform/chrome/wilco_ec/event.c > index 4d2776f77dbd..1eed55681598 100644 > --- a/drivers/platform/chrome/wilco_ec/event.c > +++ b/drivers/platform/chrome/wilco_ec/event.c > @@ -342,7 +342,7 @@ static ssize_t event_read(struct file *filp, char __user *buf, size_t count, > struct ec_event_entry, list); > n_bytes_written = entry->size; > if (copy_to_user(buf, &entry->event, n_bytes_written)) > - return -EFAULT; > + n_bytes_written = -EFAULT; > list_del(&entry->list); > kfree(entry); > dev_data->num_events--; > Applied for chrome-platform-5.3 Thanks, ~ Enric