From: "Parag Warudkar" <parag.lkml@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Zachary Amsden" <zach@vmware.com>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Glauber de Oliveira Costa" <gcosta@redhat.com>
Subject: Re: [PATCH] x86, Fix broken LDT access in VMI
Date: Tue, 30 Sep 2008 18:49:58 -0400 [thread overview]
Message-ID: <f7848160809301549n5e8fb0fcr93ed10ba409b938e@mail.gmail.com> (raw)
In-Reply-To: <20080930191356.GA28057@elte.hu>
On Tue, Sep 30, 2008 at 3:13 PM, Ingo Molnar <mingo@elte.hu> wrote:
>> - vmi_ops.write_idt_entry(dt, entry, ldt_entry[0], ldt_entry[1]);
>> + vmi_ops.write_ldt_entry(dt, entry, ldt_entry[0], ldt_entry[1]);
For a few seconds I thought it was diff going mad diff'ing exactly
similar lines.
This one could actually use some capitalization to reduce the
possibility of similar problems in future - rename to write_IDT_entry
and write_LDT_entry perhaps?
Parag
prev parent reply other threads:[~2008-09-30 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 18:02 Zachary Amsden
2008-09-30 19:13 ` Ingo Molnar
2008-09-30 22:49 ` Parag Warudkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7848160809301549n5e8fb0fcr93ed10ba409b938e@mail.gmail.com \
--to=parag.lkml@gmail.com \
--cc=gcosta@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®