From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F247FC41513 for ; Thu, 27 Jul 2023 06:42:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230271AbjG0GmH (ORCPT ); Thu, 27 Jul 2023 02:42:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232862AbjG0Glq (ORCPT ); Thu, 27 Jul 2023 02:41:46 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1FD42D4E for ; Wed, 26 Jul 2023 23:41:27 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qOugC-0002Bi-91; Thu, 27 Jul 2023 08:40:56 +0200 Message-ID: Date: Thu, 27 Jul 2023 08:40:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] net: stmmac: correct MAC propagation delay Content-Language: en-US, de-DE To: Richard Cochran , Marc Kleine-Budde Cc: kernel test robot , "David S. Miller" , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Torgue , Eric Dumazet , Jose Abreu , linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Giuseppe Cavallaro , Jakub Kicinski , Paolo Abeni , linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , patchwork-jzi@pengutronix.de References: <20230719-stmmac_correct_mac_delay-v2-1-3366f38ee9a6@pengutronix.de> <20230725200606.5264b59c@kernel.org> <20230726-dreamboat-cornhusk-1bd71d19d0d4-mkl@pengutronix.de> From: Johannes Zink In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: j.zink@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Richard, On 7/26/23 17:34, Richard Cochran wrote: > On Wed, Jul 26, 2023 at 08:04:37AM +0200, Marc Kleine-Budde wrote: > >> At least the datasheet of the IP core tells to read the MAC delay from >> the IP core (1), add the PHY delay (2) and the clock domain crossing >> delay (3) and write it to the time stamp correction register. > > That is great, until they change the data sheet. Really, this happens. I think I don't get your point here. That's true for literally any register of any peripheral in a datasheet. I think we can just stop doing driver development if we wait for a final revision that is not changed any more. Datasheets change, and if they do we update the driver. Johannes > > Thanks, > Richard > > -- Pengutronix e.K. | Johannes Zink | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |