From: Alexandre Torgue <alexandre.torgue@st.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>, <linux-gpio@vger.kernel.org>,
<arnd@arndb.de>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
<bruherrera@gmail.com>, <lee.jones@linaro.org>
Subject: Re: [PATCH v6 2/4] drivers: irqchip: Add STM32 external interrupts support
Date: Wed, 21 Sep 2016 09:45:09 +0200 [thread overview]
Message-ID: <f7875786-9b5e-075a-59c8-cd32fb1c4583@st.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1609202214460.5476@nanos>
Hi Thomas,
On 09/20/2016 10:16 PM, Thomas Gleixner wrote:
> Alexandre,
>
> On Tue, 20 Sep 2016, Alexandre TORGUE wrote:
>
>> The STM32 external interrupt controller consists of edge detectors that
>> generate interrupts requests or wake-up events.
>>
>> Each line can be independently configured as interrupt or wake-up source,
>> and triggers either on rising, falling or both edges. Each line can also
>> be masked independently.
>>
>> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
>> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
>
> That all looks very reasonable now. The only remaining question is your SOB
> chain. Who is the author of these patches? You or Maxime? If it's Maxime,
> then the changelog misses a From: tag. If it's you then Maximes SOB is
> bogus.
Actually Maxime wrote the main part of this driver and sent version 1
and 2 of the series. After Linus W. reviews, rework was required to use
hierarchical domain. According to Maxime, I coded the rework (adaptation
to hierarchical domain) and sent other version of the series.
Regards
Alex
>
> Thanks,
>
> tglx
>
>
next prev parent reply other threads:[~2016-09-21 7:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 16:00 [PATCH v6 0/4] Add STM32 EXTI interrupt controller support Alexandre TORGUE
2016-09-20 16:00 ` [PATCH v6 1/4] Documentation: dt-bindings: Document STM32 EXTI controller bindings Alexandre TORGUE
2016-09-21 12:19 ` [tip:irq/core] Documentation/dt-bindings: " tip-bot for Alexandre TORGUE
2016-09-20 16:00 ` [PATCH v6 2/4] drivers: irqchip: Add STM32 external interrupts support Alexandre TORGUE
2016-09-20 20:16 ` Thomas Gleixner
2016-09-21 7:45 ` Alexandre Torgue [this message]
2016-09-21 7:50 ` Thomas Gleixner
2016-09-21 7:54 ` Maxime Coquelin
2016-09-21 12:19 ` [tip:irq/core] drivers/irqchip: " tip-bot for Alexandre TORGUE
2016-09-20 16:00 ` [PATCH v6 3/4] ARM: STM32: Select external interrupts controller Alexandre TORGUE
2016-09-21 12:20 ` [tip:irq/core] ARM/STM32: " tip-bot for Alexandre TORGUE
2016-09-20 16:00 ` [PATCH v6 4/4] ARM: dts: Add EXTI controller node to stm32f429 Alexandre TORGUE
2016-09-21 12:20 ` [tip:irq/core] ARM/dts: " tip-bot for Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7875786-9b5e-075a-59c8-cd32fb1c4583@st.com \
--to=alexandre.torgue@st.com \
--cc=arnd@arndb.de \
--cc=bruherrera@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®