mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: samsung: Constify static snd_soc_ops
Date: Thu, 29 Jul 2021 08:58:54 +0200	[thread overview]
Message-ID: <f78b45f1-11e8-e1c3-3095-aca32de9fad1@canonical.com> (raw)
In-Reply-To: <20210728172548.234943-1-rikard.falkeborn@gmail.com>

On 28/07/2021 19:25, Rikard Falkeborn wrote:
> These are only assigned to the ops field in the snd_soc_dai_link struct
> which is a pointer to const struct snd_soc_ops. Make them const to allow
> the compiler to put them in read-only memory.
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
>  sound/soc/samsung/aries_wm8994.c   | 2 +-
>  sound/soc/samsung/arndale.c        | 4 ++--
>  sound/soc/samsung/h1940_uda1380.c  | 2 +-
>  sound/soc/samsung/littlemill.c     | 2 +-
>  sound/soc/samsung/midas_wm1811.c   | 2 +-
>  sound/soc/samsung/neo1973_wm8753.c | 4 ++--
>  sound/soc/samsung/rx1950_uda1380.c | 2 +-
>  sound/soc/samsung/smartq_wm8987.c  | 2 +-
>  sound/soc/samsung/smdk_wm8580.c    | 2 +-
>  sound/soc/samsung/smdk_wm8994.c    | 2 +-
>  sound/soc/samsung/smdk_wm8994pcm.c | 2 +-
>  sound/soc/samsung/tm2_wm5110.c     | 6 +++---
>  sound/soc/samsung/tobermory.c      | 2 +-
>  13 files changed, 17 insertions(+), 17 deletions(-)
> 


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof

  reply	other threads:[~2021-07-29  6:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 17:25 Rikard Falkeborn
2021-07-29  6:58 ` Krzysztof Kozlowski [this message]
2021-07-29 16:39 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f78b45f1-11e8-e1c3-3095-aca32de9fad1@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=rikard.falkeborn@gmail.com \
    --cc=s.nawrocki@samsung.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®