From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AD413B83F9 for ; Wed, 26 Aug 2026 08:41:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787733715; cv=none; b=DvzJ+Kogpb6NB/al7dp+Vzg+1RVA6suuigEdUYZEoBvI0ZOJJiw/zKAGIXHRfAsp0cIut1N9KP5IgS1rIwUUGpQ0PtPaTFTgNDvPmUgWIEmsgC2k4ZYbFBxQj9HF1xdjqhKD/b7e5i+dgWVMjoYCEYMCvSCCiSx9esi1pUladr0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787733715; c=relaxed/simple; bh=aekxbZZ+QrjBnhUUlWKUamuvO/zqUue2BpcbARHo47g=; h=Message-ID:Date:MIME-Version:Subject:To:References:Cc:From: In-Reply-To:Content-Type; b=Km0X/wwcL2I9qQ2vi6AnS9VEeZiEKooIv7+12NYx4IuRnYDgRL5AF7aZPDw4Obxua6sXj+X89YJBHGO0eahJ4OXQFqlpXtgqYw2/S4zk4c2g51h0H59AhK7+QaF+jMMkQ+pL2Dd0R1Y//AfN2FtAfchBOOUgg7N6WBXctw1S/Fs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TS5xN8Cg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XeWS9Pf7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TS5xN8Cg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XeWS9Pf7" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67Q6RpMZ3210627 for ; Wed, 26 Aug 2026 08:41:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= toc2DNcq80nDKIdm/5fVrSwC6pi5hJO7nJ40m2OU9a0=; b=TS5xN8Cgz5VazS8I UqGUSrJLw4Q4NkwLLPJvu954fBWjkLuh4cxC276u8VfxIjAMK1cvD6fInU5I6UB3 tH6sxLa8wPdNKtduMwpeoRwRjmFCLng1OeBgtrx18VTkJ8GgDzglJ1/vWiJyJ3t/ RjtAgJ2iMgbUcTYz7EE4K2td7Wu0ov50AhCcWOsygLW8XHZJ4S2nC2EDLQk+nAN5 6gzlb376vALkqRX7qEg1+sVyV9xU1y5b8eDhxVWLtQfrhHClCeNvYuOba1B7VsH3 Vunr7FrHZZc9mUdPlmEdkNlAxyGvOfIEaK9JuAY8t+ageikntEUTmRKlHLjAo8AU bxbIqQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g9fgrb0de-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Aug 2026 08:41:53 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84e13b57b2cso603348b3a.1 for ; Wed, 26 Aug 2026 01:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787733713; x=1788338513; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=toc2DNcq80nDKIdm/5fVrSwC6pi5hJO7nJ40m2OU9a0=; b=XeWS9Pf7qljPzIsQ5C5mBR4r6XwWvEQJz+IataZtz/fhfCYR9ZJ0Z2N1KzWwN4QIne rW1Mnmuwtw6tY46RPr/6svTg996UWWHSVpLVNXNIzNAGISzsC+30mFJC5Ea9oaKZXvdR rTp7gEDhTwVTCOV7yEcfrOpQ6ws3YZ0XbR/51nhXfmhSSNXL1jmGrOyp0XyrNnr7rv3o esFCyjBLKz2D+OWOLzJEAPNEg+m9VwcQ0Xdgj9Oa/r/RAZWOCwTtpXN6eVRWv7rx0o1L sUlsZWXns9krHYQSVVX4Vebg9Lxs//Tr/F2pYT6eyNNpIsKA8ty07yL4BvDP+FF0shbv AGTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787733713; x=1788338513; h=content-transfer-encoding:content-type:in-reply-to:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=toc2DNcq80nDKIdm/5fVrSwC6pi5hJO7nJ40m2OU9a0=; b=fOqBVPIikvD+YjTf+dMdREUhGIMZyIwfnlxrSR57s+zx+DwtHWD8bbeufBbO7MSdxX NdfJXnMTECiMkXo72X3kG94Bun5p18McgGXm1WGdNGwzthlbA37G+LxMxfqS4WLF4JQI b7CFSrWJFu3BZIswjN3KRs7qGf0FR4lVOIxaEWpNo9wK0loxdy/wRejnCHhP8LderXRi A+y97lj9POWcyxNt5RRP6AEwWlysG60XYNfD6gS8fCWTiAHdf9G4UMC5uKqthGiY/bMN Q5MsObSR41lAlHF9PkYAZhby6b6ATldY5kjCfErydlYK/GJYXdor8bUqqyYa/dwEp/n0 5gnA== X-Forwarded-Encrypted: i=1; AHgh+Rpi9CAV6liZF6IWoHDC1/2BzLXFkwAgAkSySdU9OAVCqwgheIgIWUlnnrJ5GjOcHRH8hqnD0+oLQ0jHnko=@vger.kernel.org X-Gm-Message-State: AFuF++kcyQ1/4Jb6KKTUWcg4zMcetuyfAbxTrBdTL3SEycL93qhjgYns FRDN1rULjYLs2802ZWLfeP4WBP2HfAh28lWagf9tyj0jx1LSWfgnGFahBoX3GJoKZL9I69v17/9 G1vebPf0M6nObPo6CxvIsDzS0OJp8vdK9Oo9KxgCO7CNbV9eOUB5lky5ws8qc6iLpuE8= X-Gm-Gg: AR+sD12Ir0HDf/QcyYmvXMSkayO4TQQqWLn7yirD4Q+K5WgHZvhFowmzW6THlV9pKdU 1AXCpyvkb9brtbNt779GsuV8sutBTg6yKaoe+Ha0ZmA+ZTUxBzkygBILB9/WVzmynjycdu/BfiG qd+95qFHfw1VJc5ioA35FQ6JxPYRnckyETX5Vmpdx4XoY4kLYJIDjOjrSRDq1u4p7k6WW6weU4X oxkxpmMyqWX3CYofJ9gRMAVROFkcSIn7ka4PoBaTt1PkPZ9qyAAG5yqMQsyC3pTeA2mzdLCKuaz 7I7tptVzRL0Ywy//z4gtJ/ImF+qR61tM8y/lPWFmXWrtow0VmHEulGOruq4bjpCR/j70BnCSukK Ugz/zrq8vaCVHHlzrnlsX41uAGoUmXhARBnrJbYe36pOhSgD1xTySThGInOu5fre/DniwPD4= X-Received: by 2002:a05:6a00:178c:b0:848:6c9c:4074 with SMTP id d2e1a72fcca58-85371cb5696mr8913338b3a.1.1787733712887; Wed, 26 Aug 2026 01:41:52 -0700 (PDT) X-Received: by 2002:a05:6a00:178c:b0:848:6c9c:4074 with SMTP id d2e1a72fcca58-85371cb5696mr8913268b3a.1.1787733712430; Wed, 26 Aug 2026 01:41:52 -0700 (PDT) Received: from [10.249.29.124] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8535afb2caesm642714b3a.26.2026.08.26.01.41.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Aug 2026 01:41:52 -0700 (PDT) Message-ID: Date: Wed, 26 Aug 2026 16:41:47 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fastrpc: Reduce log level for DSP info and reserved memory messages To: Ekansh Gupta , Srinivas Kandagatla , amahesh@qti.qualcomm.com, arnd@arndb.de, Greg KH References: <20260514062825.50172-1-jianping.li@oss.qualcomm.com> Content-Language: en-US Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org From: Jianping Li In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: xAIGajMd8RpbQEQSaUy8rx76VPLsKcfv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI2MDA3MSBTYWx0ZWRfX5/2Cf68h74gA F5D20eMdvmpanJ0d1/dC03fsu1KoDAWBAhrICTpIGVaNVT73aubHEOaaiVy9pBWSEgC4PKIISUI qSQTve+ehWlXpvDvb1KPGGrrS5nVhF0mhfeSaiw4UAD4CpxdIOPn3l1WMRtQnZ4EMfmi1vq4bZx Phzmbdjq8Nq7yc9W+uUoqXCZ05+c0GhC/1v84E2bEZd6nW8J9UD3grmV7UFxZG8oJVr6alwx+Bh pvlUrdk8N6q/KDBJTNY5uuKqSmb53qle7a12CVXWRF4wVg8GhhyhmME0NRiMhUNLN3lg7gcQlqY KOt3LhGpo3CtNXIPgw+T2geqoJk+4NyFEGTfcYzZS8rN/2iHps/rgBB9QUD4Lg2Nj30bEf69puF 0EozzeOIpnBShL1qTZJfE18wYqMA+WEW0bwuHFwFVTgL/gI/XSADp5lEOl07zXKP/mGCIlN+Btk i50l2u+4sOEcw+VChzA== X-Authority-Analysis: v=2.4 cv=d8LFDxjE c=1 sm=1 tr=0 ts=6a8ea6d1 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=NEAV23lmAAAA:8 a=EUspDBNiAAAA:8 a=4MCOB7C_Cw_4N5Uyge0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: xAIGajMd8RpbQEQSaUy8rx76VPLsKcfv X-Proofpoint-Spam-Info: AW1haW4tMjYwODI2MDA3MSBTYWx0ZWRfXxWJCe7C1kRO+ qVW3gxrqpYHKMZn69OVaLi92bBUnyvWci/xvfvUjoN1ZvitNkRh54YcA5yQpHrx0NVSEEqoXeO6 MMuJFerxQ9offe85YMpfskyVWvdYIEc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-26_02,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 adultscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608260071 On 8/25/2026 2:47 PM, Ekansh Gupta wrote: > On 14-05-2026 11:58, Jianping Li wrote: >> On some platforms (e.g. QCS615 Talos), fastrpc may temporarily fail >> to retrieve DSP attributes during boot, resulting in repeated >> "Error: dsp information is incorrect" messages printed on the >> console. >> >> These messages are observed continuously during boot when metadata >> flashing is enabled as part of RC releases, causing unnecessary >> log noise. >> >> Similarly, the absence of reserved DMA memory is a valid >> configuration and does not represent an error condition. >> >> Since these scenarios are expected and do not indicate a failure, >> downgrade the log level from dev_err/dev_info to dev_dbg to avoid >> flooding the console. >> >> No functional change intended. > misc: fastrpc: > ACK. >> Signed-off-by: Jianping Li >> --- >> drivers/misc/fastrpc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c >> index 1080f9acf70a..05ec14c07fd0 100644 >> --- a/drivers/misc/fastrpc.c >> +++ b/drivers/misc/fastrpc.c >> @@ -1802,7 +1802,7 @@ static int fastrpc_get_info_from_kernel(struct fastrpc_ioctl_capability *cap, >> kfree(dsp_attributes); >> return -EOPNOTSUPP; >> } else if (err) { >> - dev_err(&cctx->rpdev->dev, "Error: dsp information is incorrect err: %d\n", err); >> + dev_dbg(&cctx->rpdev->dev, "Error: dsp information is incorrect err: %d\n", err); >> kfree(dsp_attributes); >> return err; >> } >> @@ -2361,7 +2361,7 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) >> } >> >> if (of_reserved_mem_device_init_by_idx(rdev, rdev->of_node, 0)) >> - dev_info(rdev, "no reserved DMA memory for FASTRPC\n"); >> + dev_dbg(rdev, "no reserved DMA memory for FASTRPC\n"); >> >> vmcount = of_property_read_variable_u32_array(rdev->of_node, >> "qcom,vmids", &vmids[0], 0, FASTRPC_MAX_VMIDS); > Can you also move this log[1] to debug level/rate-limit? This can cause > dmesg flooding in case all the session are already getting used by > processes. Some discussion around the same happened here[2]. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/misc/fastrpc.c#n1786 > [2] https://github.com/qualcomm/fastrpc/issues/383 Thanks for the pointer. Agreed, that log can flood dmesg when the session pool is exhausted. However, unlike the two messages in this patch, "No session available" reflects a real failure — fastrpc_device_open() returns -EBUSY to userspace on that path. Lowering it all the way to dev_dbg would hide a genuine session-exhaustion condition from the default log, making such issues harder to diagnose in the field. So I'd prefer dev_err_ratelimited() here: it caps the flooding while still surfacing the error. I'll fold this into the same series in v2. Thanks, Jianping >