From: Babu Moger <babu.moger@amd.com>
To: Jim Mattson <jmattson@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Wanpeng Li <wanpengli@tencent.com>,
kvm list <kvm@vger.kernel.org>, Joerg Roedel <joro@8bytes.org>,
the arch/x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v5 04/12] KVM: SVM: Modify intercept_exceptions to generic intercepts
Date: Wed, 26 Aug 2020 16:28:48 -0500 [thread overview]
Message-ID: <f7916109-6590-756b-dafc-7976e42fc44d@amd.com> (raw)
In-Reply-To: <CALMp9eSHVS+HmbYUMdRgt9gPQaWUGBHt_owDenPOz4+KiDti5Q@mail.gmail.com>
On 8/26/20 3:55 PM, Jim Mattson wrote:
> On Wed, Aug 26, 2020 at 12:14 PM Babu Moger <babu.moger@amd.com> wrote:
>>
>> Modify intercept_exceptions to generic intercepts in vmcb_control_area. Use
>> the generic vmcb_set_intercept, vmcb_clr_intercept and vmcb_is_intercept to
>> set/clear/test the intercept_exceptions bits.
>>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> Reviewed-by: Jim Mattson <jmattson@google.com>
>> ---
>
>> @@ -835,7 +832,7 @@ static bool nested_exit_on_exception(struct vcpu_svm *svm)
>> {
>> unsigned int nr = svm->vcpu.arch.exception.nr;
>>
>> - return (svm->nested.ctl.intercept_exceptions & (1 << nr));
>> + return (svm->nested.ctl.intercepts[EXCEPTION_VECTOR] & (1 << nr));
> Nit: BIT(nr) rather than (1 << nr).
Sure. will change it. thanks
next prev parent reply other threads:[~2020-08-26 21:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 19:13 [PATCH v5 00/12] SVM cleanup and INVPCID feature support Babu Moger
2020-08-26 19:13 ` [PATCH v5 01/12] KVM: SVM: Introduce vmcb_(set_intercept/clr_intercept/_is_intercept) Babu Moger
2020-08-26 20:37 ` Jim Mattson
2020-08-26 19:13 ` [PATCH v5 02/12] KVM: SVM: Change intercept_cr to generic intercepts Babu Moger
2020-08-26 20:38 ` Jim Mattson
2020-08-26 19:14 ` [PATCH v5 03/12] KVM: SVM: Change intercept_dr " Babu Moger
2020-08-26 20:45 ` Jim Mattson
2020-08-26 19:14 ` [PATCH v5 04/12] KVM: SVM: Modify intercept_exceptions " Babu Moger
2020-08-26 20:55 ` Jim Mattson
2020-08-26 21:28 ` Babu Moger [this message]
2020-08-26 19:14 ` [PATCH v5 05/12] KVM: SVM: Modify 64 bit intercept field to two 32 bit vectors Babu Moger
2020-08-26 19:14 ` [PATCH v5 06/12] KVM: SVM: Add new intercept vector in vmcb_control_area Babu Moger
2020-08-26 19:14 ` [PATCH v5 07/12] KVM: nSVM: Cleanup nested_state data structure Babu Moger
2020-08-26 19:14 ` [PATCH v5 08/12] KVM: SVM: Remove set_cr_intercept, clr_cr_intercept and is_cr_intercept Babu Moger
2020-08-26 19:14 ` [PATCH v5 09/12] KVM: SVM: Remove set_exception_intercept and clr_exception_intercept Babu Moger
2020-08-26 19:15 ` [PATCH v5 10/12] KVM: X86: Rename and move the function vmx_handle_memory_failure to x86.c Babu Moger
2020-08-26 21:13 ` Jim Mattson
2020-08-26 19:15 ` [PATCH v5 11/12] KVM: X86: Move handling of INVPCID types to x86 Babu Moger
2020-08-26 19:15 ` [PATCH v5 12/12] KVM:SVM: Enable INVPCID feature on AMD Babu Moger
2020-09-09 19:26 ` [PATCH v5 00/12] SVM cleanup and INVPCID feature support Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7916109-6590-756b-dafc-7976e42fc44d@amd.com \
--to=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®