From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5E0FC001DC for ; Sun, 30 Jul 2023 13:31:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230151AbjG3Nbf (ORCPT ); Sun, 30 Jul 2023 09:31:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230002AbjG3Nb1 (ORCPT ); Sun, 30 Jul 2023 09:31:27 -0400 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 835CD10FA for ; Sun, 30 Jul 2023 06:31:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=t-8ch.de; s=mail; t=1690723883; bh=yo4I6s5/JIPLqK8K6k5zbNM/vTwpF+NR0NjfEi911yw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oYCE3PKH6dTdwp7caJgSksAupi4XvmTaFkgMI9PFU+ZnueloH0T1AZRScEJBD3QSj pTvpAmLgjoc+abV5T8ZhqUqV9QNN6k2r9qv3uCRsuwePmWnS5hYkpe3kmpeJOdMX4c Ab7lPQtG3eUy169iPFFTZWhOWQKFCqk4fRrBtbww= Date: Sun, 30 Jul 2023 15:31:22 +0200 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Jingbo Xu Cc: hsiangkao@linux.alibaba.com, chao@kernel.org, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, Karel Zak Subject: Re: [PATCH v2] erofs: deprecate superblock checksum feature Message-ID: References: <20230717112703.60130-1-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717112703.60130-1-jefflexu@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-07-17 19:27:03+0800, Jingbo Xu wrote: > Later we're going to try the self-contained image verification. > The current superblock checksum feature has quite limited > functionality, instead, merkle trees can provide better protection > for image integrity. The crc32c checksum is also used by libblkid to gain more confidence in its filesystem detection. I guess a merkle tree would be much harder to implement. This is for example used by the mount(8) cli program to allow mounting of devices without explicitly needing to specify a filesystem. Note: libblkid tests for EROFS_FEATURE_SB_CSUM so at least it won't break when the checksum is removed. > xxhash is also used in the following xattr name filter feature. It is > redundant for one filesystem to rely on two hashing algorithms at the > same time. > > Since the superblock checksum is a compatible feature, just deprecate > it now. > > Signed-off-by: Jingbo Xu > --- > changes since v1: > - improve commit message (Gao Xiang) > > v1: https://lore.kernel.org/all/20230714033832.111740-1-jefflexu@linux.alibaba.com/ > --- > fs/erofs/Kconfig | 1 - > fs/erofs/super.c | 44 +++++--------------------------------------- > 2 files changed, 5 insertions(+), 40 deletions(-) > [..]