From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Vinod <vkoul@kernel.org>, Mark Brown <broonie@kernel.org>,
Banajit Goswami <bgoswami@codeaurora.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
devicetree@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
spapothi@codeaurora.org
Subject: Re: [PATCH v3 1/2] dt-bindings: soundwire: add bindings for Qcom controller
Date: Tue, 15 Oct 2019 13:22:52 +0100 [thread overview]
Message-ID: <f7977140-c103-7d0d-9523-2212e1029598@linaro.org> (raw)
In-Reply-To: <CAL_Jsq+ZBhh2A3yLtOyReHHAET_bvM-ygBtRXeFihAxf0jvDKQ@mail.gmail.com>
On 15/10/2019 12:35, Rob Herring wrote:
> On Mon, Oct 14, 2019 at 12:34 PM Srinivas Kandagatla
> <srinivas.kandagatla@linaro.org> wrote:
>>
>> Thanks Rob for taking time to review,
>>
>> On 14/10/2019 18:12, Rob Herring wrote:
>>> On Fri, Oct 11, 2019 at 04:44:22PM +0100, Srinivas Kandagatla wrote:
>>>> This patch adds bindings for Qualcomm soundwire controller.
>>>>
>>>> Qualcomm SoundWire Master controller is present in most Qualcomm SoCs
>>>> either integrated as part of WCD audio codecs via slimbus or
>>>> as part of SOC I/O.
>>>>
>>>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>>> ---
>>>> .../bindings/soundwire/qcom,sdw.txt | 167 ++++++++++++++++++
>>>> 1 file changed, 167 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
>>>
>>> Next time, do a DT schema.
>>>
>> Sure! I can do that in next version!
>
> I meant the next binding you write, not v4. However, ...
>
> [...]
>
>>>> += SoundWire devices
>>>> +Each subnode of the bus represents SoundWire device attached to it.
>>>> +The properties of these nodes are defined by the individual bindings.
>>>
>>> Is there some sort of addressing that needs to be defined?
>>>
>> Thanks, Looks like I missed that here.
>>
>> it should be something like this,
>>
>> #address-cells = <2>;
>> #size-cells = <0>;
>>
>> Will add the in next version.
>
> You need a common soundwire binding for this. You also need to define
> the format of 'reg' and unit addresses. And it needs to be a schema.
> So perhaps this binding too should be.
We already have a common SoundWire bindings in mainline for this
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/soundwire/soundwire-controller.yaml?h=v5.4-rc3
Should this binding just make a reference to it instead of duplicating
this same info here?
--srini
>
> Rob
>
next prev parent reply other threads:[~2019-10-15 12:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 15:44 [PATCH v3 0/2] soundwire: Add support to Qualcomm SoundWire master Srinivas Kandagatla
2019-10-11 15:44 ` [PATCH v3 1/2] dt-bindings: soundwire: add bindings for Qcom controller Srinivas Kandagatla
2019-10-14 17:12 ` Rob Herring
2019-10-14 17:34 ` Srinivas Kandagatla
2019-10-15 11:35 ` Rob Herring
2019-10-15 12:22 ` Srinivas Kandagatla [this message]
2019-10-15 13:36 ` Rob Herring
2019-10-21 4:27 ` Vinod Koul
2019-10-11 15:44 ` [PATCH v3 2/2] soundwire: qcom: add support for SoundWire controller Srinivas Kandagatla
2019-10-11 17:50 ` Pierre-Louis Bossart
2019-10-14 9:04 ` Srinivas Kandagatla
2019-10-14 15:43 ` [alsa-devel] " Pierre-Louis Bossart
2019-10-21 4:44 ` Vinod Koul
2019-10-30 14:56 ` Srinivas Kandagatla
2019-10-30 15:18 ` [alsa-devel] " Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7977140-c103-7d0d-9523-2212e1029598@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh@kernel.org \
--cc=spapothi@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®