From: Adrian Hunter <adrian.hunter@intel.com>
To: Chanwoo Lee <cw9316.lee@samsung.com>,
ulf.hansson@linaro.org, baolin.wang@linaro.org, arnd@arndb.de,
colyli@suse.de, lee.jones@linaro.org, sartgarg@codeaurora.org,
pcc@google.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: grant.jung@samsung.com, jt77.jang@samsung.com,
dh0421.hwang@samsung.com, sh043.lee@samsung.com
Subject: Re: [PATCH] mmc: queue: Remove unused define
Date: Wed, 3 Feb 2021 09:36:34 +0200 [thread overview]
Message-ID: <f7984520-8239-24ae-0142-811f4c6d9d9f@intel.com> (raw)
In-Reply-To: <20210203072014.30272-1-cw9316.lee@samsung.com>
On 3/02/21 9:20 am, Chanwoo Lee wrote:
> From: ChanWoo Lee <cw9316.lee@samsung.com>
>
> MMC_CQE_QUEUE_FULL is not set and is only cleared.
> Therefore, define is unnecessary.
>
> Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>
Looks like a pre blk-mq remanent.
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/core/queue.c | 2 --
> drivers/mmc/core/queue.h | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
> index 002426e3cf76..9f37a8b909e8 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -33,8 +33,6 @@ void mmc_cqe_check_busy(struct mmc_queue *mq)
> {
> if ((mq->cqe_busy & MMC_CQE_DCMD_BUSY) && !mmc_cqe_dcmd_busy(mq))
> mq->cqe_busy &= ~MMC_CQE_DCMD_BUSY;
> -
> - mq->cqe_busy &= ~MMC_CQE_QUEUE_FULL;
> }
>
> static inline bool mmc_cqe_can_dcmd(struct mmc_host *host)
> diff --git a/drivers/mmc/core/queue.h b/drivers/mmc/core/queue.h
> index fd11491ced9f..57c59b6cb1b9 100644
> --- a/drivers/mmc/core/queue.h
> +++ b/drivers/mmc/core/queue.h
> @@ -81,7 +81,6 @@ struct mmc_queue {
> int in_flight[MMC_ISSUE_MAX];
> unsigned int cqe_busy;
> #define MMC_CQE_DCMD_BUSY BIT(0)
> -#define MMC_CQE_QUEUE_FULL BIT(1)
> bool busy;
> bool use_cqe;
> bool recovery_needed;
>
next prev parent reply other threads:[~2021-02-03 7:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210203072341epcas1p186cca2cf8177a31d04f1ede4bb5f1ec7@epcas1p1.samsung.com>
2021-02-03 7:20 ` Chanwoo Lee
2021-02-03 7:36 ` Adrian Hunter [this message]
2021-02-08 12:06 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7984520-8239-24ae-0142-811f4c6d9d9f@intel.com \
--to=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=baolin.wang@linaro.org \
--cc=colyli@suse.de \
--cc=cw9316.lee@samsung.com \
--cc=dh0421.hwang@samsung.com \
--cc=grant.jung@samsung.com \
--cc=jt77.jang@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=pcc@google.com \
--cc=sartgarg@codeaurora.org \
--cc=sh043.lee@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®