From: John Meneghini <jmeneghi@redhat.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
Nilesh Javali <njavali@marvell.com>,
Manish Rangankar <mrangankar@marvell.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Nimal Prabudoss I <nprabudo@redhat.com>,
GR-ETH-Storage-Upstream@marvell.com,
Jesse Taube <jtaubepe@redhat.com>
Subject: Re: [PATCH] scsi: qedf: Remove unesseary function call
Date: Thu, 29 Oct 2026 17:15:24 -0400 [thread overview]
Message-ID: <f79de58b-5a3c-4b78-81d0-0e7e50adca15@redhat.com> (raw)
In-Reply-To: <20261029160443.904468-1-jtaubepe@redhat.com>
Reviewed-by: John Meneghini <jmeneghi@redhat.com>
Nilesh or Manish now that you are on the MAINTAINERS list for this file, can we get an ACK from you?
I really want Martin to merge this so we can move forward with some of these bugs, and he needs your ACK.
Thanks,
/John
On 10/29/26 12:04, Jesse Taube wrote:
> The result of `skb_transport_header` was unused. Calling this function
> warned when `skb_transport_header_was_set` returned false causing a
> panic on debug kernels.
>
> Signed-off-by: Jesse Taube <jtaubepe@redhat.com>
> ---
> drivers/scsi/qedf/qedf_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
> index da429b3a4283..f2bc0ac684e0 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -2496,7 +2496,6 @@ static void qedf_recv_frame(struct qedf_ctx *qedf,
>
> /* Pull the header */
> hp = (struct fcoe_hdr *)skb->data;
> - fh = (struct fc_frame_header *) skb_transport_header(skb);
> skb_pull(skb, sizeof(struct fcoe_hdr));
> fr_len = skb->len - sizeof(struct fcoe_crc_eof);
>
prev parent reply other threads:[~2026-10-29 21:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 16:04 Jesse Taube
2026-10-29 16:36 ` Laurence Oberman
2026-10-29 21:15 ` John Meneghini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f79de58b-5a3c-4b78-81d0-0e7e50adca15@redhat.com \
--to=jmeneghi@redhat.com \
--cc=GR-ETH-Storage-Upstream@marvell.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jtaubepe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mrangankar@marvell.com \
--cc=njavali@marvell.com \
--cc=nprabudo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®