From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE39C31E46 for ; Wed, 12 Jun 2019 16:25:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 440C2215EA for ; Wed, 12 Jun 2019 16:25:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=eikelenboom.it header.i=@eikelenboom.it header.b="RSlgjpwa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502108AbfFLQZG (ORCPT ); Wed, 12 Jun 2019 12:25:06 -0400 Received: from server.eikelenboom.it ([91.121.65.215]:56262 "EHLO server.eikelenboom.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727337AbfFLQZG (ORCPT ); Wed, 12 Jun 2019 12:25:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=eikelenboom.it; s=20180706; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ktowEjqF/CBPxhQY3pu7cziNBjpasaaInkiP4lM1ITk=; b=RSlgjpwaOad4S6Af3UpDb10U4o dC7hhgdeQYuNplE4lMwObyLofK5gd7ONp6mAexVHPXXBoFTRvgqpdJmyUudt/WiPUNIj7jjICxEmj IpNyVa0Nz254ZSjkoJpQjgIBcexHaR8UVvXVNPXoUZtLmlIXHUMs5NBuGuJ8gZdmoyUs=; Received: from ip4da85049.direct-adsl.nl ([77.168.80.73]:38718 helo=[172.16.1.50]) by server.eikelenboom.it with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1hb63Y-0004wh-UT; Wed, 12 Jun 2019 18:25:00 +0200 Subject: Re: [PATCH] fuse: require /dev/fuse reads to have enough buffer capacity (take 2) To: Kirill Smelkov Cc: Miklos Szeredi , Miklos Szeredi , gluster-devel@gluster.org, linux-kernel , linux-fsdevel References: <876aefd0-808a-bb4b-0897-191f0a8d9e12@eikelenboom.it> <20190611202738.GA22556@deco.navytux.spb.ru> <20190612112544.GA21465@deco.navytux.spb.ru> <20190612141220.GA25389@deco.navytux.spb.ru> From: Sander Eikelenboom Message-ID: Date: Wed, 12 Jun 2019 18:28:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190612141220.GA25389@deco.navytux.spb.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/06/2019 16:12, Kirill Smelkov wrote: > On Wed, Jun 12, 2019 at 03:03:49PM +0200, Sander Eikelenboom wrote: >> On 12/06/2019 13:25, Kirill Smelkov wrote: >>> On Wed, Jun 12, 2019 at 09:44:49AM +0200, Miklos Szeredi wrote: >>>> On Tue, Jun 11, 2019 at 10:28 PM Kirill Smelkov wrote: >>>> >>>>> Miklos, would 4K -> `sizeof(fuse_in_header) + sizeof(fuse_write_in)` for >>>>> header room change be accepted? >>>> >>>> Yes, next cycle. For 4.2 I'll just push the revert. >>> >>> Thanks Miklos. Please consider queuing the following patch for 5.3. >>> Sander, could you please confirm that glusterfs is not broken with this >>> version of the check? >>> >>> Thanks beforehand, >>> Kirill >> >> >> Hmm unfortunately it doesn't build, see below. >> [...] >> fs/fuse/dev.c:1336:14: error: ‘fuse_in_header’ undeclared (first use in this function) >> sizeof(fuse_in_header) + sizeof(fuse_write_in) + fc->max_write)) > > Sorry, my bad, it was missing "struct" before fuse_in_header. I > originally compile-tested the patch with `make -j4`, was distracted onto > other topic and did not see the error after returning due to long tail > of successful CC lines. Apologize for the inconvenience. Below is a > fixed patch that was both compile-tested and runtime-tested with my FUSE > workloads (non-glusterfs). > > Kirill > Just tested and it works for me, thanks ! -- Sander