From: Sergei Shtepa <sergei.shtepa@veeam.com>
To: Randy Dunlap <rdunlap@infradead.org>, <axboe@kernel.dk>,
<hch@infradead.org>, <corbet@lwn.net>, <snitzer@kernel.org>
Cc: <viro@zeniv.linux.org.uk>, <brauner@kernel.org>,
<willy@infradead.org>, <dlemoal@kernel.org>, <wsa@kernel.org>,
<heikki.krogerus@linux.intel.com>, <ming.lei@redhat.com>,
<gregkh@linuxfoundation.org>, <linux-block@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>,
"Donald Buczek" <buczek@molgen.mpg.de>
Subject: Re: [PATCH v4 02/11] block: Block Device Filtering Mechanism
Date: Tue, 13 Jun 2023 14:34:58 +0200 [thread overview]
Message-ID: <f7b67068-62c4-0977-265a-37c84f553eab@veeam.com> (raw)
In-Reply-To: <e2f851d7-6b17-7a36-b5b3-2d60d450989d@infradead.org>
On 6/13/23 03:51, Randy Dunlap wrote:
>
> On 6/9/23 04:58, Sergei Shtepa wrote:
>> diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
>> index b7b56871029c..7904f157b245 100644
>> --- a/include/uapi/linux/fs.h
>> +++ b/include/uapi/linux/fs.h
>> @@ -189,6 +189,9 @@ struct fsxattr {
>> * A jump here: 130-136 are reserved for zoned block devices
>> * (see uapi/linux/blkzoned.h)
>> */
>> +#define BLKFILTER_ATTACH _IOWR(0x12, 140, struct blkfilter_name)
>> +#define BLKFILTER_DETACH _IOWR(0x12, 141, struct blkfilter_name)
>> +#define BLKFILTER_CTL _IOWR(0x12, 142, struct blkfilter_ctl)
>
> Please update Documentation/userspace-api/ioctl/ioctl-number.rst
> with the blkfilter ioctl number usage.
It seems to me that there is no need to change anything in the table of
numbers for 'blkfilter'. I think the existing record is enough:
0x10 20-2F arch/s390/include/uapi/asm/hypfs.h
0x12 all linux/fs.h
linux/blkpg.h
Maybe it would probably be correct to specify the file 'uapi/linux/fs.h'?
And maybe we need to specify the request numbers for blksnap?
add ioctls numbers for blksnap
Asked-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Sergei Shtepa <sergei.shtepa@veeam.com>
---
Documentation/userspace-api/ioctl/ioctl-number.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst
index 176e8fc3f31b..96af64988251 100644
--- a/Documentation/userspace-api/ioctl/ioctl-number.rst
+++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
@@ -202,6 +202,7 @@ Code Seq# Include File Comments
'V' C0 linux/ivtvfb.h conflict!
'V' C0 linux/ivtv.h conflict!
'V' C0 media/si4713.h conflict!
+'V' 00-1F uapi/linux/blksnap.h conflict!
'W' 00-1F linux/watchdog.h conflict!
'W' 00-1F linux/wanrouter.h conflict! (pre 3.9)
'W' 00-3F sound/asound.h conflict!
--
2.20.1
next prev parent reply other threads:[~2023-06-13 12:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 11:58 [PATCH v4 01/11] documentation: " Sergei Shtepa
2023-06-09 11:58 ` [PATCH v4 02/11] block: " Sergei Shtepa
2023-06-13 1:51 ` Randy Dunlap
2023-06-13 12:34 ` Sergei Shtepa [this message]
2023-06-13 14:16 ` Randy Dunlap
2023-06-09 11:58 ` [PATCH v4 03/11] documentation: Block Devices Snapshots Module Sergei Shtepa
2023-06-09 11:58 ` [PATCH v4 04/11] blksnap: header file of the module interface Sergei Shtepa
2023-06-09 11:58 ` [PATCH v4 05/11] blksnap: module management interface functions Sergei Shtepa
2023-06-09 11:58 ` [PATCH v4 06/11] blksnap: handling and tracking I/O units Sergei Shtepa
2023-06-09 11:58 ` [PATCH v4 07/11] blksnap: minimum data storage unit of the original block device Sergei Shtepa
2023-06-09 11:58 ` [PATCH v4 08/11] blksnap: difference storage Sergei Shtepa
2023-06-09 11:58 ` [PATCH v4 09/11] blksnap: event queue from the " Sergei Shtepa
2023-06-09 11:58 ` [PATCH v4 10/11] blksnap: snapshot and snapshot image block device Sergei Shtepa
2023-06-09 11:58 ` [PATCH v4 11/11] blksnap: Kconfig and Makefile Sergei Shtepa
2023-06-12 23:43 ` Randy Dunlap
2023-06-13 10:47 ` Sergei Shtepa
2023-06-13 1:52 ` [PATCH v4 01/11] documentation: Block Device Filtering Mechanism Randy Dunlap
2023-06-13 15:23 ` Sergei Shtepa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7b67068-62c4-0977-265a-37c84f553eab@veeam.com \
--to=sergei.shtepa@veeam.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=buczek@molgen.mpg.de \
--cc=corbet@lwn.net \
--cc=dlemoal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=rdunlap@infradead.org \
--cc=snitzer@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®