mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Durrant <Paul.Durrant@citrix.com>
To: Juergen Gross <jgross@suse.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	David Vrabel <david.vrabel@citrix.com>
Subject: RE: [PATCH] xenbus: advertize control feature flags
Date: Mon, 10 Oct 2016 09:28:01 +0000	[thread overview]
Message-ID: <f7ba05a8793e4f9184d24c8f87cdd3b8@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <e8f98d14-89ab-238c-8364-13dd6a40c06c@suse.com>

> -----Original Message-----
> From: Juergen Gross [mailto:jgross@suse.com]
> Sent: 10 October 2016 10:11
> To: Paul Durrant <Paul.Durrant@citrix.com>; linux-kernel@vger.kernel.org;
> xen-devel@lists.xenproject.org
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>; David Vrabel
> <david.vrabel@citrix.com>
> Subject: Re: [PATCH] xenbus: advertize control feature flags
> 
> On 10/10/16 09:43, Paul Durrant wrote:
> > The Xen docs specify several flags which a guest can set to advertize
> > which values of the xenstore control/shutdown key it will recognize.
> > This patch adds code to write all the relevant feature-flag keys.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > Cc: David Vrabel <david.vrabel@citrix.com>
> > Cc: Juergen Gross <jgross@suse.com>
> > ---
> >  drivers/xen/manage.c | 45 +++++++++++++++++++++++++++++++++++--
> --------
> >  1 file changed, 35 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
> > index e12bd36..86cf57c 100644
> > --- a/drivers/xen/manage.c
> > +++ b/drivers/xen/manage.c
> > @@ -170,6 +170,7 @@ out:
> >  struct shutdown_handler {
> >  	const char *command;
> >  	void (*cb)(void);
> > +	bool flag;
> >  };
> >
> >  static int poweroff_nb(struct notifier_block *cb, unsigned long code, void
> *unused)
> > @@ -206,21 +207,22 @@ static void do_reboot(void)
> >  	ctrl_alt_del();
> >  }
> >
> > +static struct shutdown_handler shutdown_handlers[] = {
> > +	{ "poweroff", do_poweroff, true },
> > +	{ "halt", do_poweroff, true },
> > +	{ "reboot", do_reboot, false },
> 
> I think you meant to set the flag to "false" for halt and "true" for
> reboot, no?
> 

Yes, you're right. Don't know why I got that backwards. Will fix in v2.

  Paul

> 
> Juergen

  reply	other threads:[~2016-10-10  9:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-10  7:43 Paul Durrant
2016-10-10  9:11 ` Juergen Gross
2016-10-10  9:28   ` Paul Durrant [this message]
2016-10-10  9:17 ` Juergen Gross
2016-10-10  9:28   ` Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ba05a8793e4f9184d24c8f87cdd3b8@AMSPEX02CL03.citrite.net \
    --to=paul.durrant@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®