From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outbound.ci.icloud.com (ci-2003j-snip4-4.eps.apple.com [57.103.91.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F2122417DE for ; Sun, 28 Jun 2026 16:11:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=57.103.91.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782663073; cv=none; b=MIdy+KctOMK1RhSDDx6LVNPPYum/yCHvURrClcWyNb5zCGNWHc5kfIBBmyPMhNp8Cf4pjWpjRDgaAQY/qH1JYZTYISevX14BvJaU48YtM/5qAFEURWbQZymmM5Y4jRJEbClCuXt34KM5Cxll9G8cZGZkln7NwDGpRUrdKJX9UbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782663073; c=relaxed/simple; bh=mAOO0o4SBJP+MukLGY3LcWspTKkA+ndkgr8RkyABQDs=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=RlEQM4wLOsHJZ3w5uhZOdoTvGIiC7NKSXwd32IS6Qwoe2vWgmARc7rP58eUuXmJ6Ur5lMq7FlPYRfNXZhsL8ES9dvnZb0s2dsbDTj/UhhWjo2oEIlXrHbFje/PT2HQjBkjV4EB2wMRHESrZ9uEJGbb2RjnaO31kHCqos32YFGAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com; spf=pass smtp.mailfrom=icloud.com; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b=SA+dIVDC; arc=none smtp.client-ip=57.103.91.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=icloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b="SA+dIVDC" Received: from outbound.ci.icloud.com (unknown [127.0.0.2]) by p00-icloudmta-asmtp-us-central-1k-60-percent-1 (Postfix) with ESMTPS id 0CDD818000D6; Sun, 28 Jun 2026 16:11:06 +0000 (UTC) X-ICL-RepId: 019f0eff-b53e-7b93-b21c-ac4bb3c487f6 X-ICL-Out-Info: HUtFAUMEWwJACUgATUQeDx5WFlZNRAJCTQhKB0MGWQReCEsLQwZcBlBcHA4XXhtCFUsVXANcDkswUBtfAkIPHBNWFRMLU1ZbE1UXRgkZCF0dGQpQUAVaEhhcFFxQWB5GElYNXQkZCFteUBtfAkIPHBNWFRMdQxkPKwhKBEMHRQJeCyUTCVNWWxNVF0YJGQhdHRkVWgkKV1RHWxtWDgZdH0kOG1VAA18DExQZV1QFRgZDD0xQVFRYU0JcHXMEVAddBV1WUAJaVRIEQAhWUF4IXh9MHA== Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1782663071; x=1785255071; bh=mAOO0o4SBJP+MukLGY3LcWspTKkA+ndkgr8RkyABQDs=; h=Message-ID:Date:MIME-Version:To:Subject:From:Content-Type:x-icloud-hme; b=SA+dIVDC7PRv4mvw10+waxQSwaQiLDDsD+uiw11UywHlvhjfiYmZV4GZsfK85b+ODy0mhFQM3f2N7kQbL+cbCI1A044HuTTFbfB/23eGOUqf93K/EzHSmWZKcGpL+Gu9enyhRUbxBS8jhGYoMDY7mEBf9RXYB3tOHujXMbzH3MvOJTCI5Uo1NxHxJk1stuo4CBRtQyI1jxf9NNIzocsl5o9VDIhwlKy1yEbKQDI6nLPduHhNFFvJfLt9etoZH/kAJCB+z+b5oXdgEzVzp1+9L2k/ccZuGSKMdx3zX8uR5vklAcUcjXu2uFGplkKSpcs3MahwAw6pXqT+96jsxUl8aw== Received: from [192.168.255.10] (unknown [17.57.156.36]) by p00-icloudmta-asmtp-us-central-1k-60-percent-1 (Postfix) with ESMTPSA id CF4A518002E7; Sun, 28 Jun 2026 16:10:56 +0000 (UTC) Message-ID: Date: Mon, 29 Jun 2026 00:10:50 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: david@kernel.org Cc: akpm@linux-foundation.org, axelrasmussen@google.com, baohua@kernel.org, bruzzhang@tencent.com, hannes@cmpxchg.org, kasong@tencent.com, liam@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ljs@kernel.org, mhocko@kernel.org, mhocko@suse.com, qi.zheng@linux.dev, rppt@kernel.org, shakeel.butt@linux.dev, surenb@google.com, vbabka@kernel.org, weixugc@google.com, yuanchu@google.com, zippermonkey@icloud.com References: <72874bf7-d2f7-4bb9-9211-804533bd5c19@kernel.org> Subject: Re: [PATCH v4 4/5] mm/vmscan: extract folio unmap logic into folio_try_unmap() From: Zhang Peng In-Reply-To: <72874bf7-d2f7-4bb9-9211-804533bd5c19@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI4MDE0NCBTYWx0ZWRfXw3TTZVdDs5al HqteUu03x0zhHuDeHImA290awxRyVzDPYJALWT/i2hhcLbSLLo8iSFhi9EYQuELFcFzGUvDzqZY WqXD6D0hl9jO4p1AmBiKq9EB5uvfV7E3WFNxvm5a9NhXKxj1oHV9pTrF7gleprURx7+VdGHfcdY ZVL/7o8trWurA6FSBJGzQZXefXmijgONR/68U2I2ln2VecNOaVKQXCbzF3d8JT3a6V6AlPc1Doi rzeFu2NPuN+IRF/wUeitFC7ACpL4urSrfAgq6RusBucxpoBkeSpjuGp7Gygt32hVQK1XX+8GIWe n5J0QRfp3/Wf52zsjbM X-Proofpoint-GUID: xjjpjZvuRlOQhwU3p0jGO_NC-BhpC1dC X-Proofpoint-ORIG-GUID: xjjpjZvuRlOQhwU3p0jGO_NC-BhpC1dC On Wed, Jun 17, 2026 at 02:28:42PM +0200, David Hildenbrand wrote: > Two tabs. > folio_try_unmap() vs. try_to_unmap() Hm. > const bool was_swapbacked = folio_test_swapbacked(folio); > Probably best in a single line. Fixed alignment, const, and joined the short conditions. On the name: I'll keep it as folio_try_unmap() — it's static in vmscan.c, no risk of collision with try_to_unmap(), and the try_ already tells you what it does.  If the _for_reclaim suffix matters to you I'll add it, just let me know.