From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Reza Kurniawan <imkyufie@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] arm64: dts: qcom: Refine device support for Xiaomi Redmi 5A
Date: Tue, 18 Aug 2026 11:14:06 +0200 [thread overview]
Message-ID: <f7bdf9aa-13d4-42a4-b12f-9ebc28552760@oss.qualcomm.com> (raw)
In-Reply-To: <20260810105337.855546-1-imkyufie@gmail.com>
On 8/10/26 12:53 PM, Reza Kurniawan wrote:
> Thank you for the feedback. This is my first contribution and I'm not
> quite familiar with the process yet, apologies for the mistakes.
>
> As instructed, I've added my name in the Signed-off-by field. Aside from
> that, since the changes are isolated from each other, the patch is split
> into multiple patches.
You're on good track. Please make sure all of the commits, apart from a
suitable title, also come with a commit message. This is important both
for the reviewer to more easily grok the change (or have confidence in
your understanding on the problem), as well as it brings historical
value for people that come after you - they can learn from your notes.
See: https://docs.kernel.org/process/submitting-patches.html#describe-your-changeslore
For the patch submission itself, there's a tool called b4 that takes
care of some of the headaches for you:
https://b4.docs.kernel.org/
Konrad
prev parent reply other threads:[~2026-08-18 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 10:53 Reza Kurniawan
2026-08-10 10:53 ` [PATCH v2 1/3] arm64: dts: qcom: Add UART support for Xiaomi Redmi 5A (riva) Reza Kurniawan
2026-08-10 10:53 ` [PATCH v2 2/3] arm64: dts: qcom: Add haptic vibrator " Reza Kurniawan
2026-08-10 10:53 ` [PATCH v2 3/3] arm64: dts: qcom: Add notification LED " Reza Kurniawan
2026-08-18 9:14 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7bdf9aa-13d4-42a4-b12f-9ebc28552760@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imkyufie@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®