From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AF5FC43217 for ; Fri, 11 Nov 2022 14:23:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234397AbiKKOXZ (ORCPT ); Fri, 11 Nov 2022 09:23:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234146AbiKKOWw (ORCPT ); Fri, 11 Nov 2022 09:22:52 -0500 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E00A7391DE for ; Fri, 11 Nov 2022 06:21:52 -0800 (PST) Received: by mail-lj1-x236.google.com with SMTP id l8so4666631ljh.13 for ; Fri, 11 Nov 2022 06:21:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lizn4t8CzEeOAb2NOrW1eGO8GRE54jSk5eHBfoX7CCY=; b=qir1itbo7SLIojVnuniP/lKKgJq9TuBceKLm30rtveqOll+AEFS4SYwDX4QIuW3shO x4jQasyhXZxNK8ihBC5IaSbf1Ljx3yzyW5V162Usc7AqfrOVidzgLPtuuHT02iGN3JkO vvkE6cs+a0r7VD5AT09LEk61y6Up0KR2+zspM0mhnP086VsRZyE3XDwbUvD4ia/CFMmA fV5iRUzLSUPA2brZROmg3t+gbc2j1NQ1IgzLyAac+9ZqqHiib1IkNQYRWoUvfOq8Ge/G fTDiT39cOrORSMM2/4utHqkBzg1eAAalO/kxDP/rXWYe3+htkHUkE0rXs7201C+LoVdb ATdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lizn4t8CzEeOAb2NOrW1eGO8GRE54jSk5eHBfoX7CCY=; b=uLAmMjTU+UFVz2fK0sdOeiIG2Jzu4Rh/EbrL7JDodYpmqbzzchIPg+xpkV0mw0wOZp tYm5rNp2lsyWPHdf34YXj0eE1NckvZY6Hp+IOoAUqmWCD8ODIQHjJja+CzizZLSVUyuv 6tRVe4LDijrJrb73pEI6rONCihK9e/ftC38anwszUt6qMB8KzcDnAJmHipD65B0TqI7O wRSlnkvGamOfcnRwtVvzMdM8i2qe/KCDMQ52zfFkg2Wi0mYnLUcIRZVimIFqXwyJagb6 VvFy1TlPMZaDbZ9PMpR6etawB1DYgxE8/f1Fs1ccnxcfeKaLMg5i38iSTNUPgY2yKiL1 WWYQ== X-Gm-Message-State: ANoB5pm9bMeuuavhenoRXguVa6MmuOcwpaGG8gsTiL1xIl6GMAurluND OW2DtpYpsCUJvT6GT720IfgYQQ== X-Google-Smtp-Source: AA0mqf4u3FCA6Q7ZvIrElwMeHaK0OuMQqzCJGs2cKMdDsSQw3WGaxaJ6fIuzSGrVM7neb1mCUweWPw== X-Received: by 2002:a2e:9d51:0:b0:277:1e3e:fa60 with SMTP id y17-20020a2e9d51000000b002771e3efa60mr675393ljj.496.1668176510760; Fri, 11 Nov 2022 06:21:50 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id o6-20020a05651205c600b0048a8c907fe9sm347374lfo.167.2022.11.11.06.21.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Nov 2022 06:21:50 -0800 (PST) Message-ID: Date: Fri, 11 Nov 2022 15:21:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 02/10] ASoC: dt-bindings: qcom,apr: Split services to shared schema Content-Language: en-US To: Rob Herring Cc: Srinivas Kandagatla , Bjorn Andersson , Mark Brown , Banajit Goswami , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , Liam Girdwood , Patrick Lai , Rob Herring , Srinivasa Rao Mandadapu , alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org References: <20221111113547.100442-1-krzysztof.kozlowski@linaro.org> <20221111113547.100442-3-krzysztof.kozlowski@linaro.org> <166817308876.3060199.17933327732327950670.robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <166817308876.3060199.17933327732327950670.robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/11/2022 14:30, Rob Herring wrote: > > On Fri, 11 Nov 2022 12:35:39 +0100, Krzysztof Kozlowski wrote: >> The APR/GPR nodes are organized like: >> >> apr-or-gpr-device-node <- qcom,apr.yaml >> apr-gpr-service@[0-9] <- qcom,apr.yaml >> service-specific-components <- /schemas/sound/qcom,q6*.yaml >> >> The schema for services (apr-gpr-service@[0-9]) already grows >> considerably and is still quite not specific. It allows several >> incorrect combinations, like adding a clock-controller to a APM device. >> Restricting it would complicate the schema even more. Bringing new >> support for sound on Qualcomm SM8450 and SC8280XP SoC would grow it as >> well. >> >> Simplify the qcom,apr.yaml by splitting the services to a shared file >> which will be: >> 1. Referenced by qcom,apr.yaml with additionalProperties:true, >> 2. Referenced by specific bindings for services with >> additionalProperties:false (not yet in this commit). >> >> While moving the code, add also required 'reg' and >> 'qcom,protection-domain' to further constrain the bindings. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../bindings/soc/qcom/qcom,apr-services.yaml | 54 +++++++++ >> .../bindings/soc/qcom/qcom,apr.yaml | 108 +----------------- >> MAINTAINERS | 2 +- >> 3 files changed, 58 insertions(+), 106 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/soc/qcom/qcom,apr.example.dtb:0:0: /example-0/apr/service@3: failed to match any schema with compatible: ['qcom,q6core'] > Documentation/devicetree/bindings/soc/qcom/qcom,apr.example.dtb:0:0: /example-0/apr/service@4: failed to match any schema with compatible: ['qcom,q6afe'] > Documentation/devicetree/bindings/soc/qcom/qcom,apr.example.dtb:0:0: /example-0/apr/service@7: failed to match any schema with compatible: ['qcom,q6asm'] > Documentation/devicetree/bindings/soc/qcom/qcom,apr.example.dtb:0:0: /example-0/apr/service@8: failed to match any schema with compatible: ['qcom,q6adm'] This is expected. I should have mention maybe in commit msg that these compatibles are being removed in this commit and re-added in further commits. Change is therefore not entirely bisectable, but should be easier for review. If desired, I can squash these commits. Best regards, Krzysztof