From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F1BF145A0A; Mon, 29 Jul 2024 11:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722251461; cv=none; b=XSpOebKzl+QGSGfM3YSg1ZY1wtGdFZxzaR5AgJZ+o80etYA3FWHe6scCdYpBPkydkz6agVUjIjXwJUEqqWQvz5l+YqXMc/XI3vAMzdRntlSSNy7xALyI7G++6uklnMwmwJzW5V5xazJ2kyYF4gZHCV4uo5PmWfnhytiIL7c5t4E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722251461; c=relaxed/simple; bh=SJ//61zs9YkpjXbm861D0K8GgZ1Ki0bah6gnhT2Kb+Y=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=Um9+NapZh0fDG6a9ficR7BMaARM29ZKajVRtiBmLhdArSkOOy71f3HsXnOYDf1rlMo05/G+f6Vr4pxP5t8BbrhxMTEorMt6/I/Li4kOA8LqaOoygTSfh0QFctYzRTS5mCAfBTODBK78N3ic7BDEHE2qxMVcZ6CBx6q6JWASsJ3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4WXbBT34HRzyNwn; Mon, 29 Jul 2024 19:05:53 +0800 (CST) Received: from kwepemi100008.china.huawei.com (unknown [7.221.188.57]) by mail.maildlp.com (Postfix) with ESMTPS id 8BE72140135; Mon, 29 Jul 2024 19:10:49 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemi100008.china.huawei.com (7.221.188.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 29 Jul 2024 19:10:48 +0800 Message-ID: Date: Mon, 29 Jul 2024 19:10:47 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2] irqchip: Remove asmlinkage for *handle_irq() functions Content-Language: en-US To: Mark Rutland CC: , , , , , , , , , , , , , , , , , , References: <20240729024752.1250618-1-ruanjinjie@huawei.com> From: Jinjie Ruan In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi100008.china.huawei.com (7.221.188.57) On 2024/7/29 17:39, Mark Rutland wrote: > On Mon, Jul 29, 2024 at 10:47:52AM +0800, Jinjie Ruan wrote: >> Since commit 064dbfb41691 ("arm64: entry: convert IRQ+FIQ handlers to C"), >> the gic_handle_irq() is only called by C functions. >> >> And since commit a7b0872e964c ("irq: arm: perform irqentry in entry code"), >> aic_handle(), aic5_handle(), clps711x_irqh(), davinci_cp_intc_handle_irq(), >> ft010_irqchip_handle_irq(), ixp4xx_handle_irq(), omap_intc_handle_irq(), >> sa1100_handle_irq() and fpga_handle_irq() are only called by C functions. >> >> So remove the asmlinkages. > > This commit message isn't quite right -- GICv3 can also be used on 32-bit arm, > and so even after commit 064dbfb41691 it could be called from assembly until > commit a7b0872e964c. You are right! ARCH_AIROHA and ARCH_VIRT also use GICv3. > > I think it'd be better to say: > > Currently, all architectures with set_handle_irq() call the root irqchip > handler from C code, so there's no need for these to be asmlinkage. > > Remove asmlinkage for all handlers registered with set_handle_irq(). > >> Fixes: 064dbfb41691 ("arm64: entry: convert IRQ+FIQ handlers to C") >> Fixes: a7b0872e964c ("irq: arm: perform irqentry in entry code") > > This is a cleanup, not a fix. Please don't add Fixes tags unless this > fixes a real functional issue. > >> Signed-off-by: Jinjie Ruan >> Suggested-by: Thomas Gleixner > > With the commit message cleaned up and the fixes tags gone: Thank you! I'll update it. > > Acked-by: Mark Rutland > > Mark. > >> --- >> v2: >> - Also fix for arm32 irqchip as Thomas suggested. >> - Add Suggested-by. >> --- >> drivers/irqchip/irq-atmel-aic.c | 3 +-- >> drivers/irqchip/irq-atmel-aic5.c | 3 +-- >> drivers/irqchip/irq-clps711x.c | 2 +- >> drivers/irqchip/irq-davinci-cp-intc.c | 3 +-- >> drivers/irqchip/irq-ftintc010.c | 2 +- >> drivers/irqchip/irq-gic-v3.c | 2 +- >> drivers/irqchip/irq-ixp4xx.c | 3 +-- >> drivers/irqchip/irq-omap-intc.c | 3 +-- >> drivers/irqchip/irq-sa11x0.c | 3 +-- >> drivers/irqchip/irq-versatile-fpga.c | 2 +- >> 10 files changed, 10 insertions(+), 16 deletions(-) >> >> diff --git a/drivers/irqchip/irq-atmel-aic.c b/drivers/irqchip/irq-atmel-aic.c >> index 4631f6847953..3839ad79ad31 100644 >> --- a/drivers/irqchip/irq-atmel-aic.c >> +++ b/drivers/irqchip/irq-atmel-aic.c >> @@ -57,8 +57,7 @@ >> >> static struct irq_domain *aic_domain; >> >> -static asmlinkage void __exception_irq_entry >> -aic_handle(struct pt_regs *regs) >> +static void __exception_irq_entry aic_handle(struct pt_regs *regs) >> { >> struct irq_domain_chip_generic *dgc = aic_domain->gc; >> struct irq_chip_generic *gc = dgc->gc[0]; >> diff --git a/drivers/irqchip/irq-atmel-aic5.c b/drivers/irqchip/irq-atmel-aic5.c >> index 145535bd7560..c0f55dc7b050 100644 >> --- a/drivers/irqchip/irq-atmel-aic5.c >> +++ b/drivers/irqchip/irq-atmel-aic5.c >> @@ -67,8 +67,7 @@ >> >> static struct irq_domain *aic5_domain; >> >> -static asmlinkage void __exception_irq_entry >> -aic5_handle(struct pt_regs *regs) >> +static void __exception_irq_entry aic5_handle(struct pt_regs *regs) >> { >> struct irq_chip_generic *bgc = irq_get_domain_generic_chip(aic5_domain, 0); >> u32 irqnr; >> diff --git a/drivers/irqchip/irq-clps711x.c b/drivers/irqchip/irq-clps711x.c >> index e731e0784f7e..806ebb1de201 100644 >> --- a/drivers/irqchip/irq-clps711x.c >> +++ b/drivers/irqchip/irq-clps711x.c >> @@ -69,7 +69,7 @@ static struct { >> struct irq_domain_ops ops; >> } *clps711x_intc; >> >> -static asmlinkage void __exception_irq_entry clps711x_irqh(struct pt_regs *regs) >> +static void __exception_irq_entry clps711x_irqh(struct pt_regs *regs) >> { >> u32 irqstat; >> >> diff --git a/drivers/irqchip/irq-davinci-cp-intc.c b/drivers/irqchip/irq-davinci-cp-intc.c >> index 7482c8ed34b2..f4f8e9fadbbf 100644 >> --- a/drivers/irqchip/irq-davinci-cp-intc.c >> +++ b/drivers/irqchip/irq-davinci-cp-intc.c >> @@ -116,8 +116,7 @@ static struct irq_chip davinci_cp_intc_irq_chip = { >> .flags = IRQCHIP_SKIP_SET_WAKE, >> }; >> >> -static asmlinkage void __exception_irq_entry >> -davinci_cp_intc_handle_irq(struct pt_regs *regs) >> +static void __exception_irq_entry davinci_cp_intc_handle_irq(struct pt_regs *regs) >> { >> int gpir, irqnr, none; >> >> diff --git a/drivers/irqchip/irq-ftintc010.c b/drivers/irqchip/irq-ftintc010.c >> index 359efc1d1be7..b91c358ea6db 100644 >> --- a/drivers/irqchip/irq-ftintc010.c >> +++ b/drivers/irqchip/irq-ftintc010.c >> @@ -125,7 +125,7 @@ static struct irq_chip ft010_irq_chip = { >> /* Local static for the IRQ entry call */ >> static struct ft010_irq_data firq; >> >> -static asmlinkage void __exception_irq_entry ft010_irqchip_handle_irq(struct pt_regs *regs) >> +static void __exception_irq_entry ft010_irqchip_handle_irq(struct pt_regs *regs) >> { >> struct ft010_irq_data *f = &firq; >> int irq; >> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c >> index c19083bfb943..0efa3443c323 100644 >> --- a/drivers/irqchip/irq-gic-v3.c >> +++ b/drivers/irqchip/irq-gic-v3.c >> @@ -930,7 +930,7 @@ static void __gic_handle_irq_from_irqsoff(struct pt_regs *regs) >> __gic_handle_nmi(irqnr, regs); >> } >> >> -static asmlinkage void __exception_irq_entry gic_handle_irq(struct pt_regs *regs) >> +static void __exception_irq_entry gic_handle_irq(struct pt_regs *regs) >> { >> if (unlikely(gic_supports_nmi() && !interrupts_enabled(regs))) >> __gic_handle_irq_from_irqsoff(regs); >> diff --git a/drivers/irqchip/irq-ixp4xx.c b/drivers/irqchip/irq-ixp4xx.c >> index 5fba907b9052..f23b02f62a5c 100644 >> --- a/drivers/irqchip/irq-ixp4xx.c >> +++ b/drivers/irqchip/irq-ixp4xx.c >> @@ -105,8 +105,7 @@ static void ixp4xx_irq_unmask(struct irq_data *d) >> } >> } >> >> -static asmlinkage void __exception_irq_entry >> -ixp4xx_handle_irq(struct pt_regs *regs) >> +static void __exception_irq_entry ixp4xx_handle_irq(struct pt_regs *regs) >> { >> struct ixp4xx_irq *ixi = &ixirq; >> unsigned long status; >> diff --git a/drivers/irqchip/irq-omap-intc.c b/drivers/irqchip/irq-omap-intc.c >> index dc82162ba763..ad84a2f03368 100644 >> --- a/drivers/irqchip/irq-omap-intc.c >> +++ b/drivers/irqchip/irq-omap-intc.c >> @@ -325,8 +325,7 @@ static int __init omap_init_irq(u32 base, struct device_node *node) >> return ret; >> } >> >> -static asmlinkage void __exception_irq_entry >> -omap_intc_handle_irq(struct pt_regs *regs) >> +static void __exception_irq_entry omap_intc_handle_irq(struct pt_regs *regs) >> { >> extern unsigned long irq_err_count; >> u32 irqnr; >> diff --git a/drivers/irqchip/irq-sa11x0.c b/drivers/irqchip/irq-sa11x0.c >> index 31c202a1ae62..9d0b80271949 100644 >> --- a/drivers/irqchip/irq-sa11x0.c >> +++ b/drivers/irqchip/irq-sa11x0.c >> @@ -127,8 +127,7 @@ static int __init sa1100irq_init_devicefs(void) >> >> device_initcall(sa1100irq_init_devicefs); >> >> -static asmlinkage void __exception_irq_entry >> -sa1100_handle_irq(struct pt_regs *regs) >> +static void __exception_irq_entry sa1100_handle_irq(struct pt_regs *regs) >> { >> uint32_t icip, icmr, mask; >> >> diff --git a/drivers/irqchip/irq-versatile-fpga.c b/drivers/irqchip/irq-versatile-fpga.c >> index 5018a06060e6..ca471c6fee99 100644 >> --- a/drivers/irqchip/irq-versatile-fpga.c >> +++ b/drivers/irqchip/irq-versatile-fpga.c >> @@ -128,7 +128,7 @@ static int handle_one_fpga(struct fpga_irq_data *f, struct pt_regs *regs) >> * Keep iterating over all registered FPGA IRQ controllers until there are >> * no pending interrupts. >> */ >> -static asmlinkage void __exception_irq_entry fpga_handle_irq(struct pt_regs *regs) >> +static void __exception_irq_entry fpga_handle_irq(struct pt_regs *regs) >> { >> int i, handled; >> >> -- >> 2.34.1 >> >