From: Chanwoo Choi <cwchoi00@gmail.com>
To: Dong Aisheng <aisheng.dong@nxp.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: dongas86@gmail.com, kernel@pengutronix.de, shawnguo@kernel.org,
linux-imx@nxp.com, linux-kernel@vger.kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
cw00.choi@samsung.com, abel.vesa@nxp.com
Subject: Re: [PATCH V2 RESEND 2/4] PM / devfreq: Remove the invalid description for get_target_freq
Date: Tue, 23 Mar 2021 23:56:22 +0900 [thread overview]
Message-ID: <f7cc9eef-4fc9-ba33-06de-9414843ddf5b@gmail.com> (raw)
In-Reply-To: <1616484011-26702-3-git-send-email-aisheng.dong@nxp.com>
On 21. 3. 23. 오후 4:20, Dong Aisheng wrote:
> First of all, no_central_polling was removed since
> commit 7e6fdd4bad03 ("PM / devfreq: Core updates to support devices
> which can idle")
> Secondly, get_target_freq() is not only called only with update_devfreq()
> notified by OPP now, but also min/max freq qos notifier.
>
> So remove this invalid description now to avoid confusing.
>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> Documentation/ABI/testing/sysfs-class-devfreq | 5 +----
> drivers/devfreq/governor.h | 2 --
> 2 files changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-devfreq b/Documentation/ABI/testing/sysfs-class-devfreq
> index 386bc230a33d..5e6b74f30406 100644
> --- a/Documentation/ABI/testing/sysfs-class-devfreq
> +++ b/Documentation/ABI/testing/sysfs-class-devfreq
> @@ -97,10 +97,7 @@ Description:
> object. The values are represented in ms. If the value is
> less than 1 jiffy, it is considered to be 0, which means
> no polling. This value is meaningless if the governor is
> - not polling; thus. If the governor is not using
> - devfreq-provided central polling
> - (/sys/class/devfreq/.../central_polling is 0), this value
> - may be useless.
> + not polling.
>
> A list of governors that support the node:
> - simple_ondmenad
> diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
> index 244634465170..2d69a0ce6291 100644
> --- a/drivers/devfreq/governor.h
> +++ b/drivers/devfreq/governor.h
> @@ -57,8 +57,6 @@
> * Basically, get_target_freq will run
> * devfreq_dev_profile.get_dev_status() to get the
> * status of the device (load = busy_time / total_time).
> - * If no_central_polling is set, this callback is called
> - * only with update_devfreq() notified by OPP.
> * @event_handler: Callback for devfreq core framework to notify events
> * to governors. Events include per device governor
> * init and exit, opp changes out of devfreq, suspend
>
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
next prev parent reply other threads:[~2021-03-23 14:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 7:20 [PATCH V2 RESEND 0/4] PM / devfreq: a few small fixes and improvements Dong Aisheng
2021-03-23 7:20 ` [PATCH V2 RESEND 1/4] PM / devfreq: Use more accurate returned new_freq as resume_freq Dong Aisheng
2021-03-23 14:55 ` Chanwoo Choi
2021-03-23 7:20 ` [PATCH V2 RESEND 2/4] PM / devfreq: Remove the invalid description for get_target_freq Dong Aisheng
2021-03-23 14:56 ` Chanwoo Choi [this message]
2021-03-23 7:20 ` [PATCH V2 RESEND 3/4] PM / devfreq: bail out early if no freq changes in devfreq_set_target Dong Aisheng
2021-03-23 15:01 ` Chanwoo Choi
2021-05-19 6:51 ` Dong Aisheng
2021-03-23 7:20 ` [PATCH V2 RESEND 4/4] PM / devfreq: imx8m-ddrc: remove imx8m_ddrc_get_dev_status Dong Aisheng
2021-03-23 14:56 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7cc9eef-4fc9-ba33-06de-9414843ddf5b@gmail.com \
--to=cwchoi00@gmail.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=cw00.choi@samsung.com \
--cc=dongas86@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®