From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f228.google.com (mail-qk1-f228.google.com [209.85.222.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B227560AC8 for ; Thu, 15 Oct 2026 19:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.228 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792091429; cv=none; b=Ph1zPsGbP9UIJF95buFvbPN7gi0gd8whd+ISU/Hu7TIVvbD5s3ShMM5WFMebNruyRlEFLIyj0yG13i6DNR0OwHhBPVkA8G+NzBFTiwn613kskOSFEB9AoaYdIeEkli/0pJIvQKQU5+Z666PWL8cg3TOsJUxP3wLVey0t56XtKzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792091429; c=relaxed/simple; bh=hE3f8QdWqnVhUuJM36XTgD2Q348p5LglREhubn7I+ww=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TrSmy7vLCoXz4LnQL6Fg7rC9FemNzDUcDboCi3uQJ2LQQ+bkS3eBzvaMfqt20/8FO0kiTFCObAbSy3pI0DfsOOw9Fl63bgU1LHKD+1wxmBNgHedrZyZ/KRO1etpMqg1UUXs4Cfuo+RzscwvzHOfGZr9Ks+r6ZQLqKEn/FFX2Ffo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=VV6K+DVN; arc=none smtp.client-ip=209.85.222.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="VV6K+DVN" Received: by mail-qk1-f228.google.com with SMTP id af79cd13be357-93e6fb35f91so533805085a.2 for ; Thu, 15 Oct 2026 12:10:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792091427; x=1792696227; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=fpovG3xe/GFBxw/GZpFun0w46KPpZR7RwgjQ0+f5SJE=; b=MZV8zQZhfclplrN8gQ6VnhPlzkBstOtKZbTf3qaY/P7QUJ0JzuktFcp6uw2LzU5Kek JRB9SqDgXmo9b4BYBgKb1EZKr6bgi7e+Jat1aF436DFMdIO7D9mmKwRUgKKG9xK3zRAX th7rMNKtxDwqN2lzW9MrVVb8SLzD1NQcPbLsQw6betZe7ZCUaaxc/9I9wFh6vZRaRMcu bGsmvYKlmrEZbYsS51R9JBUezQYhUNIUoLqoUwtAVlyCSqQyiTlGSuHZvtcKIyJ/oKF/ WOyrURl+JoLYbTD8nxCGIZqHGnURHzAcDQgoBbjdP7QXIUhFNtiUJl5/Q1weOm/6TXkI fTwA== X-Forwarded-Encrypted: i=1; AKwUvBzCEamj5oej5qZw72EfcL4G/2IYv5ejtNj2QpKC2+gGbM+T8T+7tEAgJ4PKl5RJkH85KhlZS+PZcDpYjIo=@vger.kernel.org X-Gm-Message-State: AFq9FYIujsaODWScjDCS8gMWSrNhuH6f/2lM7BJ5gXeAV4x0SJx3tFPB yUdtRXfLt3vQPk1yP+3b4R10Xii8b3ONUfEJIL61Vc5QmlmsAYPhRObycON8oMmN8tD2WIHRiSO EhZpzVKU74P04zOYEx2mXlMIcx7mfnCt3g1xV3jiVa6/qZIkvybU3bOyPaSFs6Lkd+xxzDEKP14 sAVNi5wOF1OKE9914QSy7c5APuDeCVJyLadxGc7+jt4Ncg5NN4UFuVvoFnmP3mXVUBCLY4LqCyk hvgwkcmbzN5iHOIa4qiwQM/ X-Gm-Gg: AYBFou0+oYlakWjy8Z0Fka1RR8NtPgw4c39+VGOvOWCPpUOGRUX8D6f8eD6+LosT6x4 vFZ1PMM+NxEGfr15wgfGt3onCQXsoLer3LxNjKV+4coJtLqG5/iTpaWBecVM+TfIx2BbiVkWWcJ c94U3jRZcePTAi7rGJVpC5mCa/+azDcYegfX3eAf0DknTSzEIJexTx5MK0ZtFn0aiDOLq79f9gU txJ3zfPLd6hOLdaD+xNDztuJTpmjmYhAfxmntpGiEntHa0Oh/u8V7IW5iejEINejN6YAb7pzf9m FLh+1IaWBfunXyschVTdRx7tbTjyJHRKId5lnCzuvURCVVmmN3o/97XzcpDWUAiXfgHoURFQwwX +Pz/RshWQxTnybVbr8W64MGQySVMsty34kMwtoFfQSTJA1CNVcI6C6zS/k+yQ7TQ6qOPXqBS+Lh Zwv1pOKf/TDPYHYp82mQD86WGJAE60blvVLOJ4v//Vv1U= X-Received: by 2002:a05:620a:6601:b0:93e:4dd3:bbb1 with SMTP id af79cd13be357-93ebd1e0104mr3371259585a.19.1792091427033; Thu, 15 Oct 2026 12:10:27 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-120.dlp.protect.broadcom.com. [144.49.247.120]) by smtp-relay.gmail.com with ESMTPS id af79cd13be357-93f1a16118csm1536385a.12.2026.10.15.12.10.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Oct 2026 12:10:27 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-93cc359d9easo933209985a.3 for ; Thu, 15 Oct 2026 12:10:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1792091426; x=1792696226; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fpovG3xe/GFBxw/GZpFun0w46KPpZR7RwgjQ0+f5SJE=; b=VV6K+DVN5vaRfTlBAHAqkf37WriJyaIgIDifIHp5nZMsvzTOhB5i3Tcu768etqPYX7 fdBhBIFS3JlNk7MWbRRmT1mrn+QqbPIhUcE8YHsMfeOxDjLcxdPR66QU1PNFZlPZAfWj wDWBNffboufNooiacKahpBD3FutI8sAtdsXNc= X-Forwarded-Encrypted: i=1; AKwUvBw/IHZ8+p/GWyPvdeUmfxFOk9HX6TXILje7+QM7OeLSNpk615JZ/w07EZYEzndp7NIP37L3joRaBvg0+V4=@vger.kernel.org X-Received: by 2002:a05:620a:19a5:b0:93e:acdd:acd9 with SMTP id af79cd13be357-93ebd0cb796mr3250025985a.7.1792091426112; Thu, 15 Oct 2026 12:10:26 -0700 (PDT) X-Received: by 2002:a05:620a:19a5:b0:93e:acdd:acd9 with SMTP id af79cd13be357-93ebd0cb796mr3250018785a.7.1792091425443; Thu, 15 Oct 2026 12:10:25 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-91bcb8b4c51sm3232936d6.5.2026.10.15.12.10.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2026 12:10:24 -0700 (PDT) Message-ID: Date: Thu, 15 Oct 2026 12:10:22 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/2] PCI: iproc-bcma: Use EROM instead of devicetree To: Semih Baskan Cc: Bjorn Helgaas , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Ray Jui , Scott Branden , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Arnd Bergmann , Rosen Penev , Rani Hod , bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Helgaas References: <20261013220421.1588051-1-bhelgaas@google.com> <0dcfb2db-5536-465a-bee1-afe160535748@broadcom.com> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 10/15/26 11:51, Semih Baskan wrote: >> Humm, this is not materially different for me before/after applying tihs >> patch and unfortunately but here is what I am getting with these two >> patches applied on top of Linus' master at >> 0fcb05b72344f40806cbe810de8872f1698bf053: > [...] >> Unhandled fault: external abort on non-linefetch (0x1008) at 0xc896df40 > [...] >> r3 : c896df40 r2 : 0000ffff r1 : 00000f40 r0 : c1ce1a00 > [...] >> pci_host_probe from iproc_pcie_setup+0x8a0/0xd94 >> iproc_pcie_setup from iproc_pltfm_pcie_probe+0x10c/0x1d4 > > The series only changes the pcie-iproc-bcma path, and this kernel probes > the controller with pcie-iproc-platform, so the patches do not run here. Yes, clearly not enough coffee, thank you Semih. > > I think the abort is the read of APB_ERR_EN at offset 0xf40 (r1). I > measured the same on an RT-N18U (core revision 0x01) in September: the > platform-only kernel does not come up, and with this one line it boots > and enumerates the BCM4360 [1]: > > --- a/drivers/pci/controller/pcie-iproc.c > +++ b/drivers/pci/controller/pcie-iproc.c > @@ -1388,7 +1388,7 @@ > break; > case IPROC_PCIE_PAXB: > regs = iproc_pcie_reg_paxb; > - pcie->has_apb_err_disable = true; > + pcie->has_apb_err_disable = false; > if (pcie->need_ob_cfg) { > pcie->ob_map = paxb_ob_map; > pcie->ob.nr_windows = ARRAY_SIZE(paxb_ob_map); Yes that works for me, and I was able to establish the last working baseline was v7.0 which did not include 76701239797698b620f2b7ec713fe08ef50ee664 ("ARM: dts: BCM5301X: Describe PCIe controllers fully"), whereas v7.1 and onwards crashes unless your patch is applied. Also, the good thing is that my local test bed has been resurrected and will be more regularly testing now. > > [1] https://lore.kernel.org/all/CAAsRjRnV-RTddO6h2XCUz2N5pB0pS8i_-_2XRcD=WOTA7AAFZQ@mail.gmail.com/ > > Best regards, > Semih -- Florian