From: Ashish Mhetre <amhetre@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>, Jason Gunthorpe <jgg@ziepe.ca>
Cc: catalin.marinas@arm.com, will@kernel.org, corbet@lwn.net,
skhan@linuxfoundation.org, robin.murphy@arm.com, joro@8bytes.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v7 2/3] iommu/arm-smmu-v3: Introduce CFGI/TLBI-repeat workaround infrastructure
Date: Wed, 22 Jul 2026 14:48:02 +0530 [thread overview]
Message-ID: <f7cff418-0849-4c58-8d3e-1ce8e1ca1134@nvidia.com> (raw)
In-Reply-To: <al01gEzqzCO8KqTO@nvidia.com>
On 7/20/2026 2:07 AM, Nicolin Chen wrote:
> On Sat, Jul 18, 2026 at 01:45:48PM -0300, Jason Gunthorpe wrote:
>> On Fri, Jul 17, 2026 at 02:16:53PM -0700, Nicolin Chen wrote:
>>> Given the use cases on Tegra264, instead of patching the iommufd
>>> path as this patch does, perhaps we should simply spit a WARN in
>>> arm_vsmmu_init():
>> Nope, in this case you need to make the errata discoverable through
>> the viommu info so the VMM can validate the right DT is used, or apply
>> the WAR itself before submitting commands to the kernel.
> OK.
>
>> Some kind of new flag in the viommu struct I guess
> struct iommu_hw_info_arm_smmuv3 has an unused "flags" field:
>
> /**
> * enum iommu_hw_info_smmuv3_flags - Flags for ARM SMMUv3 hw_info
> * @IOMMU_HW_INFO_SMMUV3_ERRATA_REPEAT_TLBI_CFGI: If set, user space must issue
> * TLBI/CFGI+SYNC commands twice
> * due to a hardware erratum:
> * <link-to-erratum>
> */
> enum iommu_hw_info_smmuv3_flags {
> IOMMU_HW_INFO_SMMUV3_ERRATA_REPEAT_TLBI_CFGI = 1 << 0,
> };
>
> Thanks
> Nicolin
Ack, I am sending v8 addressing this.
Thanks,
Ashish Mhetre
next prev parent reply other threads:[~2026-07-22 9:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 10:41 [PATCH v7 0/3] iommu/arm-smmu-v3: Tegra264 invalidation workaround Ashish Mhetre
2026-07-14 10:42 ` [PATCH v7 1/3] iommu/arm-smmu-v3: Factor out CMDQ batch force-sync conditions Ashish Mhetre
2026-07-17 19:59 ` Jason Gunthorpe
2026-07-14 10:42 ` [PATCH v7 2/3] iommu/arm-smmu-v3: Introduce CFGI/TLBI-repeat workaround infrastructure Ashish Mhetre
2026-07-17 20:18 ` Jason Gunthorpe
2026-07-17 21:16 ` Nicolin Chen
2026-07-18 16:45 ` Jason Gunthorpe
2026-07-19 20:37 ` Nicolin Chen
2026-07-22 9:18 ` Ashish Mhetre [this message]
2026-07-14 10:42 ` [PATCH v7 3/3] iommu/arm-smmu-v3: Enable CFGI/TLBI-repeat workaround on Tegra264 Ashish Mhetre
2026-07-17 20:19 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7cff418-0849-4c58-8d3e-1ce8e1ca1134@nvidia.com \
--to=amhetre@nvidia.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=skhan@linuxfoundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®