From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754713AbeDPMjF (ORCPT ); Mon, 16 Apr 2018 08:39:05 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:34655 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753917AbeDPMjD (ORCPT ); Mon, 16 Apr 2018 08:39:03 -0400 X-Google-Smtp-Source: AIpwx4+9q9mbu3h548uG9UnuEo6DGlpxVXx/dVTmd6YSPNX7B3Bm/4wKgYi+FjwyN//UI48K/HtieQ== Subject: Re: [PATCH 01/14] thermal: exynos: Reading temperature makes sense only when TMU is turned on To: Bartlomiej Zolnierkiewicz Cc: Eduardo Valentin , Zhang Rui , Krzysztof Kozlowski , Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Marek Szyprowski References: <1523873525-23718-1-git-send-email-b.zolnierkie@samsung.com> <1523873525-23718-2-git-send-email-b.zolnierkie@samsung.com> <60958515.5KCaPvLZ9i@amdc3058> From: Daniel Lezcano Message-ID: Date: Mon, 16 Apr 2018 14:39:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <60958515.5KCaPvLZ9i@amdc3058> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/04/2018 14:17, Bartlomiej Zolnierkiewicz wrote: > On Monday, April 16, 2018 02:06:41 PM Daniel Lezcano wrote: >> On 16/04/2018 12:11, Bartlomiej Zolnierkiewicz wrote: >>> From: Marek Szyprowski >>> >>> When thermal sensor is not yet enabled, reading temperature might return >>> random value. This might even result in stopping system booting when such >>> temperature is higher than the critical value. Fix this by checking if TMU >>> has been actually enabled before reading the temperature. >>> >>> This change fixes booting of Exynos4210-based board with TMU enabled (for >>> example Samsung Trats board), which was broken since v4.4 kernel release. >> >> Why not move the thermal_zone_of_sensor_register *after* initializing >> the sensor ? > > For initializing the sensor we need data obtained from > therm_zone_of_sensor_register() so it cannot be easily > done (especially since we also want the fix to be > ported to -stable kernels). For more detailed description > please see: > > https://lkml.org/lkml/2018/4/10/376 I see, a chicken egg problem :/ Thanks for the pointer. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog