From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39FEE3E6DC5 for ; Fri, 17 Jul 2026 09:59:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784282362; cv=none; b=BMpabgiKkyzDRRx5/K3hPWiHj/4VWJEaU21S/BAyqLaSaVbTuu3ISF3dK1hec5MiIrvSxcnPL8JQoLtp79FmI/oi+wgqUT48PPPPYF5ffjSCQ7O+a8quM8eapQt+1l3upihpHm3ZH6455sll5rsJXN/K6K+rB3lpCe7vD6mf4v8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784282362; c=relaxed/simple; bh=jL3mrOok8MADLcpmY7jdHUknhxvySR86Mx3M++52+aw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LxSJYyLkfW7M5UdSN08TMAB1/PYIzcl7HJ66t1LfibFvfmXdIqplxbLeSCbU9ZOLFjeLtddPP9FCIcizKBn0R/jcbPDHzE0vGWyCv0+DlEiq+fHB7lf8cp/9RSZ9FwYAZheVpCyAj1Jwip+N8paIKjmjIZI5HicpUjD9J/XFUBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Qov3sl3X; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fZ3Rh/Cp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Qov3sl3X"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fZ3Rh/Cp" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66H6cNr41066038 for ; Fri, 17 Jul 2026 09:59:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4m4mhHCdwe+iD4gbi28L8euNiv4IB7P2LYKO26utpc4=; b=Qov3sl3XOGvuaaS9 FzJ64v8p+4oY/aWx3GR75C+9X6OpIO2Ur6Y/TrlskZq7xyE4qWVcdLzgAK1OkjcW /O1PfaH+hCukscfvU0Usf//CEk+9veVwA/G6+tNr3UL5NsUHHrdRVPTjn/Y0TlEb LEVvhlslkKG67+QUs0vgfT3Af3AdvBk+sINzKnG390ybx+UpMIayENdJnYE4m9q+ c7Cr5MyXPrw54nkerytxqHoMPPoGxBTdNvngbm3R4fwW13K8hB0gqkBkCFZ1fwq/ eESdJxByGALHzIP2JC5Y3tAe5udjJlu/OgjRhjaDv5y/gVkCUi4NqZU3eFfD3YZG 4XXPdw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ffbquhhww-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 09:59:20 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e9c0c4492so152839585a.2 for ; Fri, 17 Jul 2026 02:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784282359; x=1784887159; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4m4mhHCdwe+iD4gbi28L8euNiv4IB7P2LYKO26utpc4=; b=fZ3Rh/CpPUj9vh6SjXly3vM41IQ9OooLJqtanHPZoLTHsZHLHLkGdv3nLk+jMhjDxb MpVdaHmTb3+mV4L2ECs5FpwPCJ1LSPTN+d4kTWqkdzYEI95055Mp9hpaT2hD0JPvWQyx qVmdpFDRSwo3gJbTtXyo0RWK89i8cQBcmeJ8V1udeduLnsToDFHgnz4LRbKqN2MNC3O/ tauyz2E/CXrJoNigs2OtQvw2K4MBMDomh01TeIALA/vbewZXTz+GtK0vTm5TV7fzuajC OQ3g0RfSUHiYedSly6FL5ihdUN1eX1CNKtMquAwlVImqUt4PoHtdEUhVCdOSJUdaKzB2 ygOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784282359; x=1784887159; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4m4mhHCdwe+iD4gbi28L8euNiv4IB7P2LYKO26utpc4=; b=lo4UKrHs79x6OG+lEhvnoEmrcJWBUwUugwgtP+Ev7jZ5ckM15DgClTEJve0PCq+3wx vN/63JRPZDD4x2x+a8Vcvx9y4LArTq+gpgQhUS7+aFaenoJ6nWjWa8xsqPUVo2Qz1lLP SJZjDxSJjO1XQxPB1Mvf1nwjj3AJjelaoW2F3Eg3HwsH7+BLyKFlFnCZ2xoC8mCJkxir s7bqsysgk7jbV3Ctp3fb4ch1oXXIizb+aX6pSfEYarmvFcOn+yN6GViqN//CxpAvqCuv GcwWTgk2iOIfbk23qwQbbShtIwYY5zSR6aGP16pZYoC/W7TzcP2hb+1c/4+21wWJW7mg vl0g== X-Forwarded-Encrypted: i=1; AHgh+RqStYgYVgwu7Lx2SMzLs2J46VZAWTcdfRhAd8PFUZMea1UiUFO0iMcc94i9HKN30PRJJXWqe+NNm1d9ZTw=@vger.kernel.org X-Gm-Message-State: AOJu0YxI+zIelx9QB929ckgkjMxlvgwc9XKp2GkEow0aqcbUTLdLXrHb J5NDAZkBaWxj3mUZ40u54zCj+moYicxPZFbUkc98VsCSBd5p0gqJbXWWQoZobEirI4v70rm09Z9 jtIo3/p7ZGINmHteubDnGZ3HTZ605eZ+360BWC156qkPsBePeLlDmDx8P4gtUyQ5/BkU= X-Gm-Gg: AfdE7cm4NrthcrXUMOGcfoDqHV4KiAGkidIuFwglGFuORfV+9i6eSh9oPFWYszG72mB FGNDiDKam7Ctipy+NObyW4h5W+7Q8bFsI21nsnG20LWhCQplyeYl5vxGsDf8vvC3DvCXvmb9LcE jjR4KzA4JVJftyDibg50pT7tJbHt9UmHIZ+9fm15M6uF5oi3sHA/RArxVy7T/Z/nrrfrAuuErUP jjBxl4JCKQE2yU01RMXx1QVK/YDg7eZ2DfeFSnImPvmFPzFl6HozAQ6S6tqhVw4jwN/7RiU+w50 /6dFD/pg1iAYFpuv13VU867pd+ESpZ8XjT0CmZhAQz93BO+P3DkNHS4PgxwN4SmKlVDCAGWMR3+ SyvTUGCslp0bZhnoIlWwA2Col X-Received: by 2002:a05:620a:4396:b0:92a:228:1bfc with SMTP id af79cd13be357-930b3e2e4famr170490485a.2.1784282359420; Fri, 17 Jul 2026 02:59:19 -0700 (PDT) X-Received: by 2002:a05:620a:4396:b0:92a:228:1bfc with SMTP id af79cd13be357-930b3e2e4famr170487485a.2.1784282359012; Fri, 17 Jul 2026 02:59:19 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1740bf5df5sm50044466b.61.2026.07.17.02.59.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2026 02:59:18 -0700 (PDT) Message-ID: Date: Fri, 17 Jul 2026 11:59:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] arm64: dts: qcom: eliza: Add GPU SMMU node To: Akhil P Oommen Cc: Puranam V G Tejaswi , Abel Vesa , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Will Deacon , Robin Murphy , "Joerg Roedel (AMD)" References: <20260705-eliza-gpu-v1-0-c9f1354dbd29@oss.qualcomm.com> <20260705-eliza-gpu-v1-6-c9f1354dbd29@oss.qualcomm.com> <10b0ad51-8766-449c-a51c-979364e6c781@oss.qualcomm.com> <5fcc0bc1-7f9e-4611-be77-42860e0f4c74@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: GO_3gQFmqB2DaCyxZJtKTDAoqvjKE3tT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDA5OSBTYWx0ZWRfXwIfaHjJJHCu/ +HffSCEpYIXmGzSyOjN5pIzb3FtkLgedhlv/dX6VCyyZQUCx2UI9g/7SHmjfeQK6RrnLV90ndx+ Z2yY0RHZiIYc3hvpyPJHMpE0MrYNPNerniC2lzwBjKz7BOd4zVF4+8oaRG0EhspWRhmfqyLd5wu w3ImIH1+rZ+02yXcIs2V+UrLrvJ+DvYsX0szaZl66P1kI+4/vFXNpVo62Mt0q0QahbDn2LA1W+y 6yCKJuV6n3cY9UPGYLnqXkheBtXuTQ3s7un24vGfV7Ta5Uo8W3WMoCGZSTx3cz9YC3abWOY/9nQ bZfiV6jzBbq1VFaHGT+1GZxAIgDpClbwzJipG6iaFPnb77psQTshj8JFnWk1Tvo7iEEVlA+zMfq XTA4B5qDwAzmIp2qDRh6C/vWmKkFtyCQpORAQwEtXIiKG8FzfehAVo6+Mb7wa6Z7kK3PjU8VZCd aBZn1nKPVwjCEpULaSA== X-Authority-Analysis: v=2.4 cv=NZ3WEWD4 c=1 sm=1 tr=0 ts=6a59fcf8 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=hbrWYzUuUx-UyiL5C5EA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: GO_3gQFmqB2DaCyxZJtKTDAoqvjKE3tT X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDA5OSBTYWx0ZWRfX8XEaOjgQXN5q lH1uByFo3WtDJ0t5rczUiCw75uIj/BY8DIzZTPyBWVLFLM/fV/CFSuTeA2NJkGvV/LVF3qiC1zA TV7QZpszYpWGa24ZAj4yq6qUZaXDd8Y= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_02,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170099 On 7/13/26 9:47 PM, Akhil P Oommen wrote: > On 7/6/2026 4:38 PM, Konrad Dybcio wrote: >> On 7/6/26 1:07 PM, Konrad Dybcio wrote: >>> On 7/5/26 10:14 AM, Akhil P Oommen wrote: >>>> From: Abel Vesa >>>> >>>> Add the nodes to describe the GPU SMMU. >>>> >>>> Signed-off-by: Abel Vesa >>>> Signed-off-by: Akhil P Oommen >>>> --- >>>> arch/arm64/boot/dts/qcom/eliza.dtsi | 38 +++++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 38 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi >>>> index c5635f22e2a7..e5b8377e6c3a 100644 >>>> --- a/arch/arm64/boot/dts/qcom/eliza.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/eliza.dtsi >>>> @@ -2674,6 +2674,44 @@ mdss_dp0_out: endpoint { >>>> }; >>>> }; >>>> >>>> + adreno_smmu: iommu@3da0000 { >>>> + compatible = "qcom,eliza-smmu-500", "qcom,adreno-smmu", >>>> + "qcom,smmu-500", "arm,mmu-500"; >>>> + reg = <0x0 0x03da0000 0x0 0x40000>; >>>> + #iommu-cells = <2>; >>>> + #global-interrupts = <1>; >>>> + interrupts = , >>> >>> 674 is the correct globla >> >> (modulo the issue i explained below) >> >> [...] >> >>> This list is not quite correct. It must be sorted by the context index, >>> to which a given interrupt corresponds to - the driver relies on that >>> to give you information about where a context fault happens >>> >>> Moreover, I see that the interrupt sheet has the bug where some >>> interrupts are offset by 32 from the base vector, and others are offset >>> by 31 (i.e. the SPI number doesn't equal irq vector - 32) - please find >>> out which mapping is correct with the right folks > > I reviewed this and looks correct to me. Also, this matches the > downstream configuration. Did you confuse with Dest Port vs Vector ID in > the documentation? What I'm trying to say is that the documentation is confusing, we've had that issue in the past on other platforms. If you see that the correct irqs are firing, it's fine Konrad