From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D2C6C2BB48 for ; Thu, 17 Dec 2020 11:41:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D739123741 for ; Thu, 17 Dec 2020 11:41:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727993AbgLQLlC (ORCPT ); Thu, 17 Dec 2020 06:41:02 -0500 Received: from mx2.suse.de ([195.135.220.15]:45242 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726773AbgLQLlB (ORCPT ); Thu, 17 Dec 2020 06:41:01 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 527A2AC7B; Thu, 17 Dec 2020 11:40:20 +0000 (UTC) Message-ID: Subject: Re: [PATCH 1/3] cifs: Delete a stray unlock in cifs_swn_reconnect() From: Samuel Cabrero Reply-To: scabrero@suse.com To: Dan Carpenter , Steve French Cc: Aurelien Aptel , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Thu, 17 Dec 2020 12:40:18 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-12-17 at 14:01 +0300, Dan Carpenter wrote: > The unlock is done in the caller, this is a stray which leads to a > double unlock bug. > Indeed. Reviewed-by: Samuel Cabrero -- Samuel Cabrero / SUSE Labs Samba Team GPG: D7D6 E259 F91C F0B3 2E61 1239 3655 6EC9 7051 0856 scabrero@suse.com scabrero@suse.de