From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f100.google.com (mail-qv1-f100.google.com [209.85.219.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11258226863 for ; Fri, 13 Mar 2026 23:01:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773442900; cv=none; b=XodzxqCyVOBd47jrl0ee1GJIaS6LtphfbaaXkqQrPQ8B19q3OkESwG1skiI5A/OHXyhdznfiXKdrjnxr+s4T4JSnHJlJlEu6+H+mGKb6rcE85PKnQO7voh4uKjjmyixF3u0E6TCidSu14UVHNlhHDJHjnuz9UQNncqqfR3nDe5E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773442900; c=relaxed/simple; bh=7SMNboWR/j0cymyIrPPcyWtbzuKx8Ba/8gHfSqMT2E0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HlIM5xm7xZPxEXXOrzze0rGDPTNcnqrOCSGqTVdAbKdZJmRdDa6xlyYOLm3MELby6kBvkePhUU8N+51vtaEOnarKx3PNXhJundT6q1V+UJIHmWAdWpQHl7b0KCSdpxH6cjAMDaSGLU2VLtR/gHIw/oQsaFZV/zUWhO7frpj6pNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=DJNbOBtJ; arc=none smtp.client-ip=209.85.219.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="DJNbOBtJ" Received: by mail-qv1-f100.google.com with SMTP id 6a1803df08f44-89a00e8dc04so26390046d6.0 for ; Fri, 13 Mar 2026 16:01:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773442898; x=1774047698; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bMulMmXSixwpfrBnFM+KvWC268VUN5S7cA68yHQsSWY=; b=NkhvxF9NT7EWW6E49dNYANz4Ej7ygArG+f1pQpNdtkaDjrkYlhBrTTEOZ6vwW5hXwq IYSj+Pvn7x8kklZIrDfcr0zWhZzjddvI/Jrz9HxxRyBNcIPLLD+WKuE/Pk3gTZTd+xKS qkmNdzwNt5c2LBqLNGd5A/ndHUzbkRFg3VoQESnWqi3bOvVXdbeyPeUdrDgD+7tCMe5I qH81oV3QUwpzKMF7rJ4cD7AiILG1JeYrSqU06BEPMXQqv82mVXrI5JFjN0pmlOYLbrgh 2FEjv4xhJfXJe95ZthF7PMTU+Knh5Obevv3N+11iEYGbgbS866Nr+davRBQwx2yVOO6y zdeA== X-Forwarded-Encrypted: i=1; AJvYcCV0ENGdTtl4R+kmgL7JQ5gLlXqn/Y9OzrNFRqxpCltiURWknlfoVxXWEyLMVh1bAy0oXbmrWTIMFy6InYQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwNIKhBeM6h2T6l94SMAROeJ/9AUJ8Hl1FCRO9rNSHvhT9Ve01M 7sNVWVP84Vo4xXR2SH61QhYoKhCrVoh3gejVQ2Y/cVcn5hvT2JNIx7Y8PaZXDJCu5kms8GxUlxv rFASj5s8asqtBV24bbOLtM583cRE4HlDOTO4W93h0ODItB0tDzlEAEPitISHn6fMUwx6uM+JPSo 2ExGpm7dO4kHv83zasWJAhozkWwDiN8twixUuTHlA2Y47vYroHXyj2OsGfAU4xZ50MNmBwc7IqQ 0R45msqkuCjk20joaqWBIgl X-Gm-Gg: ATEYQzxhPHbtsIfHtHs6zdb1KgYI/U83Z33XnycsZWxjmsZrWJDP9BsCuDHTg9da1or +kbcquLTz6DcNFxTk+Aez81ndiTFb0cBylvTL7nG83NKU2vTEPulyVesKT7ZLE6tcOXM5xsOVYe 4DO0clJ93RMLAAkG8H+ZYGo7HenkYO2cAJOI8nxSFwMKkkOXks5+dUwi7vu5E2knYMWwt4qK8qS 0KMOtYk+ysi1p1jQfMnxY+Hcsf8q5OZkhkgdcwPXet0st4L1CEHZ/ppj+5vlGXvzoAKBWJV0KRO xoWGq3oZZZjJ6IUxgR0H+p03nzfTCXzQlR2LU6c2Kp+p64uhKXZ9o8NPniapZgMk/nekkrX4G3X r290gTsDsWq4Ec7SvZ47RYYbveerj4AdRfnO5uu/KpOr3lZaNuoW2U5+7CzskXOzkVeCeaSiKb+ o11LaTMlmYXwfblzKHdaR0nWc51GktgASsfKgQcb+R2Z2te6/kciJsT+dC7e9ppg== X-Received: by 2002:a05:6214:250c:b0:899:f6b6:543c with SMTP id 6a1803df08f44-89a81ff6cc7mr68810776d6.47.1773442897974; Fri, 13 Mar 2026 16:01:37 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-63.dlp.protect.broadcom.com. [144.49.247.63]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-89a65d06ecbsm9331076d6.18.2026.03.13.16.01.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Mar 2026 16:01:37 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50911c94db1so149438381cf.0 for ; Fri, 13 Mar 2026 16:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773442897; x=1774047697; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=bMulMmXSixwpfrBnFM+KvWC268VUN5S7cA68yHQsSWY=; b=DJNbOBtJZ+ktu6uQBfaWJ6jinZitOOYxEyDM7cVHVOov9WZzvWBEyK1zytS26mLaj2 e6AYPVVzrEcoLjHYB5S6CI0dJKQMLechFl5q+KQ2UShR8MloTDBKbyo8u6pvZEI7Amhd 6fuaNAjM9htu0ejseIqijASwLeQ4pMo8xdxr8= X-Forwarded-Encrypted: i=1; AJvYcCWNbF5Z67K8N76mSZg9rR3VGuxiTsvcj0u66pWiZ2U5xvENli3oBBo8ihyOAng10ETm+AV/jp6HIG3VVEs=@vger.kernel.org X-Received: by 2002:ac8:7f8b:0:b0:509:3c8c:23f7 with SMTP id d75a77b69052e-50957d5b09bmr65069241cf.30.1773442897024; Fri, 13 Mar 2026 16:01:37 -0700 (PDT) X-Received: by 2002:ac8:7f8b:0:b0:509:3c8c:23f7 with SMTP id d75a77b69052e-50957d5b09bmr65068721cf.30.1773442896532; Fri, 13 Mar 2026 16:01:36 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89a65beeb7dsm75536546d6.19.2026.03.13.16.01.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 16:01:35 -0700 (PDT) Message-ID: Date: Fri, 13 Mar 2026 16:01:33 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 0/6] net: bcmgenet: add XDP support To: Nicolai Buchwitz , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Doug Berger Cc: Broadcom internal kernel review list , Vikas Gupta , Bhargava Marreddy , Rajashekar Hudumula , Eric Biggers , Heiner Kallweit , =?UTF-8?Q?Markus_Bl=C3=B6chl?= , Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260313092101.1344954-1-nb@tipi-net.de> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20260313092101.1344954-1-nb@tipi-net.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 3/13/26 02:20, Nicolai Buchwitz wrote: > Add XDP support to the bcmgenet driver, covering XDP_PASS, XDP_DROP, > XDP_TX, XDP_REDIRECT, and ndo_xdp_xmit. > > The first patch converts the RX path from the existing kmalloc-based > allocation to page_pool, which is a prerequisite for XDP. The remaining > patches incrementally add XDP functionality and per-action statistics. > > Tested on Raspberry Pi CM4 (BCM2711, bcmgenet, 1Gbps link): > - XDP_PASS: 943 Mbit/s TX, 935 Mbit/s RX (no regression vs baseline) > - XDP_PASS latency: 0.164ms avg, 0% packet loss > - XDP_DROP: all inbound traffic blocked as expected > - XDP_TX: TX counter increments (packet reflection working) > - Link flap with XDP attached: no errors > - Program swap under iperf3 load: no errors This is very nice, thanks for doing that work! If the network is brought up and there is a background iperf3 client transmitting data, and then you issue "reboot -f", you will see the following NPD: [ 176.531216] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000010 [ 176.540052] Mem abort info: [ 176.542854] ESR = 0x0000000096000004 [ 176.546614] EC = 0x25: DABT (current EL), IL = 32 bits [ 176.551938] SET = 0, FnV = 0 [ 176.555000] EA = 0, S1PTW = 0 [ 176.558149] FSC = 0x04: level 0 translation fault [ 176.563037] Data abort info: [ 176.565924] ISV = 0, ISS = 0x00000004, ISS2 = 0x00000000 [ 176.571421] CM = 0, WnR = 0, TnD = 0, TagAccess = 0 [ 176.576489] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 [ 176.581813] user pgtable: 4k pages, 48-bit VAs, pgdp=0000000044d02000 [ 176.588286] [0000000000000010] pgd=0000000000000000, p4d=0000000000000000 [ 176.595101] Internal error: Oops: 0000000096000004 [#1] SMP [ 176.600774] Modules linked in: bdc udc_core [ 176.604976] CPU: 3 UID: 0 PID: 1575 Comm: reboot Not tainted 7.0.0-rc3-g08ac0b907060 #2 PREEMPTLAZY [ 176.614124] Hardware name: BCM972180HB_V20 (DT) [ 176.618662] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 176.625636] pc : bcmgenet_free_rx_buffers+0x78/0x148 [ 176.630618] lr : bcmgenet_fini_dma+0x104/0x180 [ 176.635071] sp : ffff8000836d3910 [ 5] 95.00-96.00 sec 98.4 MB[ 176.638390] x29: ffff8000836d3910 x28: 0000000000000000 x27: 0000000000000038 ytes 826 Mbits/sec 0 819[ 176.648318] x26: 0000000000000001 x25: 0000000000000010 x24: 00000000000003c0 KBytes [ 176.658238] x23: ffffffffffffffff x22: ffff0000086b4a00 x21: 0000000000000000 [ 176.666766] x20: ffff0000086b8600 x19: 0000000000000000 x18: 0000000000000000 [ 176.673917] x17: 000000000000fe88 x16: 00000000000733f0 x15: 00000000000005a8 [ 176.681067] x14: 000000291895b141 x13: 00000000000733f0 x12: 0000000000000000 [ 176.688218] x11: 00000000000000c0 x10: 0000000000000910 x9 : ffff8000809b4ecc [ 176.695368] x8 : ffff0000058531f0 x7 : 0000000000000000 x6 : 0000000000000000 [ 176.702518] x5 : 0000000000000000 x4 : ffffffff00000000 x3 : 00000000fffe1db3 [ 176.709669] x2 : 0000000000000001 x1 : ffff80008103a108 x0 : 0000000000000001 [ 176.716821] Call trace: [ 176.719271] bcmgenet_free_rx_buffers+0x78/0x148 (P) [ 176.724247] bcmgenet_fini_dma+0x104/0x180 [ 176.728353] bcmgenet_netif_stop+0x1b4/0x1f8 [ 176.732633] bcmgenet_close+0x38/0xd8 [ 176.736304] __dev_close_many+0xd4/0x1f8 [ 176.740237] netif_close_many+0x8c/0x140 [ 176.744169] unregister_netdevice_many_notify+0x210/0x998 [ 176.749578] unregister_netdevice_queue+0xa0/0xe8 [ 176.754291] unregister_netdev+0x28/0x50 [ 176.758221] bcmgenet_shutdown+0x24/0x48 [ 176.762153] platform_shutdown+0x28/0x40 [ 176.766085] device_shutdown+0x154/0x260 [ 176.770015] kernel_restart+0x48/0xc8 [ 176.773688] __do_sys_reboot+0x154/0x268 [ 176.777620] __arm64_sys_reboot+0x28/0x38 [ 176.781638] invoke_syscall+0x4c/0x118 [ 176.785397] el0_svc_common.constprop.0+0x44/0xe8 [ 176.790110] do_el0_svc+0x20/0x30 [ 176.793433] el0_svc+0x18/0x68 [ 176.796495] el0t_64_sync_handler+0x98/0xe0 [ 176.800689] el0t_64_sync+0x154/0x158 [ 176.804362] Code: d280003a d503201f f94d2e93 9b3b4eb3 (f9400a61) [ 176.810467] ---[ end trace 0000000000000000 ]--- That does not happen if you do: ip link set eth0 down while there is transmission in progress, FWIW. pw-bot: cr -- Florian