mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Hook, Gary" <ghook@amd.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Gary R Hook <gary.hook@amd.com>,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/amd - Use dev_err to send events to the system log
Date: Tue, 13 Feb 2018 14:24:56 -0500	[thread overview]
Message-ID: <f7e7e2c2-c83d-9c4a-f3ac-5c351576b567@amd.com> (raw)
In-Reply-To: <20180213160018.fg7baclgu5o5rgxc@8bytes.org>

On 2/13/2018 11:00 AM, Joerg Roedel wrote:
> On Tue, Feb 13, 2018 at 10:47:55AM -0500, Hook, Gary wrote:
>>
>>          dev_err(&iommu->dev->dev, "ILLEGAL...
> 
> I think its more something like iommu->iommu->dev.
> 
> 


Without actually running a driver and getting some debug info, I'll just
say that my example compiled, the amd_iommu structure points to a 
pci_dev which contains a device, and the two possibilities are likely 
equivalent.

I'll vet that, of course, but working under the assumption that they are 
equivalent, the question becomes, do you have a preference?

Thanks,
Gary

  reply	other threads:[~2018-02-13 19:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31  1:04 Gary R Hook
2018-02-13 13:22 ` Joerg Roedel
2018-02-13 15:47   ` Hook, Gary
2018-02-13 16:00     ` Joerg Roedel
2018-02-13 19:24       ` Hook, Gary [this message]
2018-02-14 11:49         ` Joerg Roedel
2018-02-14 14:58           ` Hook, Gary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7e7e2c2-c83d-9c4a-f3ac-5c351576b567@amd.com \
    --to=ghook@amd.com \
    --cc=gary.hook@amd.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®