mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tim Surber <me@timsurber.de>
To: Jianfeng Liu <liujianfeng1994@gmail.com>,
	linux-rockchip@lists.infradead.org
Cc: Diederik de Haas <didi.debian@cknow.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add RGA2 support to rk3588
Date: Fri, 30 Aug 2024 19:57:36 +0200	[thread overview]
Message-ID: <f7f30cbc-1bae-440e-b6e5-d50f2deb8847@timsurber.de> (raw)
In-Reply-To: <20240604163408.1863080-3-liujianfeng1994@gmail.com>

Hi Jianfeng,

I've tested RGA2 now for a while on a RK3588 board and it works correctly.

Of course it has to be updated and moved to probably rk3588-base.dtsi now.

With this done:

Tested-by: Tim Surber <me@timsurber.de>

Best regards,

Tim Surber

On 04.06.24 18:34, Jianfeng Liu wrote:
> RK3588 also features a RGA2 block. Add the necessary device tree
> node.
>
> Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com>
>
> ---
>
> Changes in v2:
> - Sort node by bus-address based on next-20240604
>
>   arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> index 6ac5ac8b48a..beebc4dc0e7 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> @@ -1159,6 +1159,17 @@ power-domain@RK3588_PD_SDMMC {
>   		};
>   	};
>   
> +	rga: rga@fdb80000 {
> +		compatible = "rockchip,rk3588-rga", "rockchip,rk3288-rga";
> +		reg = <0x0 0xfdb80000 0x0 0x180>;
> +		interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH 0>;
> +		clocks = <&cru ACLK_RGA2>, <&cru HCLK_RGA2>, <&cru CLK_RGA2_CORE>;
> +		clock-names = "aclk", "hclk", "sclk";
> +		resets = <&cru SRST_RGA2_CORE>, <&cru SRST_A_RGA2>, <&cru SRST_H_RGA2>;
> +		reset-names = "core", "axi", "ahb";
> +		power-domains = <&power RK3588_PD_VDPU>;
> +	};
> +
>   	av1d: video-codec@fdc70000 {
>   		compatible = "rockchip,rk3588-av1-vpu";
>   		reg = <0x0 0xfdc70000 0x0 0x800>;

      reply	other threads:[~2024-08-30 17:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04 16:34 [PATCH v2 0/2] media: rockchip: rga: Add rk3588 support Jianfeng Liu
2024-06-04 16:34 ` [PATCH v2 1/2] dt-bindings: media: rockchip-rga: add rockchip,rk3588-rga Jianfeng Liu
2024-06-04 16:34 ` [PATCH v2 2/2] arm64: dts: rockchip: Add RGA2 support to rk3588 Jianfeng Liu
2024-08-30 17:57   ` Tim Surber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7f30cbc-1bae-440e-b6e5-d50f2deb8847@timsurber.de \
    --to=me@timsurber.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=didi.debian@cknow.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=liujianfeng1994@gmail.com \
    --cc=robh@kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®