From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Alim Akhtar <alim.akhtar@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org,
tglx@linutronix.de, pankaj.dubey@samsung.com,
m.szyprowski@samsung.com
Subject: Re: [PATCH v2 3/3] clocksource/drivers/exynos_mct: bump up number of local timer
Date: Sun, 20 Feb 2022 18:34:03 +0100 [thread overview]
Message-ID: <f7fb5de6-369a-837f-35ad-52aa13df7e10@canonical.com> (raw)
In-Reply-To: <0a0801d8267b$467e8800$d37b9800$@samsung.com>
On 20/02/2022 17:59, Alim Akhtar wrote:
>
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>> Sent: Sunday, February 20, 2022 9:03 PM
>> To: Alim Akhtar <alim.akhtar@samsung.com>; linux-arm-
>> kernel@lists.infradead.org; linux-kernel@vger.kernel.org
>> Cc: linux-samsung-soc@vger.kernel.org; daniel.lezcano@linaro.org;
>> tglx@linutronix.de; pankaj.dubey@samsung.com;
>> m.szyprowski@samsung.com
>> Subject: Re: [PATCH v2 3/3] clocksource/drivers/exynos_mct: bump up
>> number of local timer
>>
>> On 20/02/2022 14:38, Alim Akhtar wrote:
>>> As per the dt binding, maximum number of local timer can be up to 16.
>>> Increase the array size of the _name_ variable which holds the number
>>> of local timer name per CPU to reflect the binding. While at it,
>>> change the magic number to a meaningful macro.
>>
>> This still does not make sense. Let's say you have 16 local timers, so why the
>> name of clock event device should be maximum 16? How are these related?
>>
> As you rightly commented on v1 and it is mainly for "mct_tick%d" with number of local timers and
> local timer is per cpu. With increase in cpu number, name[10] restrict the scalability.
> So either we can change to 11, or use some reference (as local timer number in this patch).
> Let me know your thought on this.
There could be some reference, like dedicated define. However length is
not directly related to the number of local irqs, but only number of
digits in decimal representation. If MCT_NR_LOCAL_TIMERS is increased
from 12 to 20, or from 20 to 80, the length should stay the same.
I propose to keep it at 11 and add a comment that length of the name
must be adjusted if number of interrupts grow over two digits.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-02-20 17:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220220132636epcas5p4f320ac6dff9621b75481bd71b1f33183@epcas5p4.samsung.com>
2022-02-20 13:38 ` [PATCH v2 1/3] clocksource/drivers/exynos_mct: Remove mct interrupt index enum Alim Akhtar
[not found] ` <CGME20220220132640epcas5p1a523e6db151e0cb76c0edb6d32959fe5@epcas5p1.samsung.com>
2022-02-20 13:38 ` [PATCH v2 2/3] clocksource/drivers/exynos_mct: bump up mct max irq number Alim Akhtar
2022-02-20 15:32 ` Krzysztof Kozlowski
[not found] ` <CGME20220220132643epcas5p39d48a27bb3fcde2ea3a01a260b46e1a0@epcas5p3.samsung.com>
2022-02-20 13:38 ` [PATCH v2 3/3] clocksource/drivers/exynos_mct: bump up number of local timer Alim Akhtar
2022-02-20 15:33 ` Krzysztof Kozlowski
2022-02-20 16:59 ` Alim Akhtar
2022-02-20 17:34 ` Krzysztof Kozlowski [this message]
2022-02-20 15:30 ` [PATCH v2 1/3] clocksource/drivers/exynos_mct: Remove mct interrupt index enum Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7fb5de6-369a-837f-35ad-52aa13df7e10@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=alim.akhtar@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®