Re: [PATCH] selftests/alsa: remove 0/NULL global variable assignment

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

On Fri, Aug 22, 2025 at 12:17:14AM +0300, Nikola Ivanov wrote:
> On Thu, Aug 21, 2025 at 09:49:29PM +0100, Mark Brown wrote:

> > > -int num_cards = 0;
> > > -int num_controls = 0;
> > > -struct card_data *card_list = NULL;
> > > -struct ctl_data *ctl_list = NULL;
> > > +int num_cards;
> > > +int num_controls;
> > > +struct card_data *card_list;
> > > +struct ctl_data *ctl_list;

> > Nothing now sets initial values for these variables so they all have
> > undefined values which is buggy.  The code is relying on the default
> > values.

> Checkpatch reports it as an error, it looks to be part of the C
> standard that all compilers must initialize globals to 0.
> Though I suppose it helps with readability to see
> the num_ counters assigned 0.

Do you have a reference there, note that these are just plain non-static
variables?  I wouldn't trust checkpatch for anything that isn't kernel
code (and even there it's got issues).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]