From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9074466AF1 for ; Thu, 13 Aug 2026 11:15:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786619763; cv=none; b=Ts4aKOC/MS7dEaGFlcb81ParxHbLQbYXAo3bTNgOlZ1WH/NE7ly/hnWbHpwZYcuu2cvhkAnZjg50W6O+lvGIOXl2c+haSL2obSk8ZCfRsnkazQ60qy145urAqLzo7SGEQ0fZySZlleJzZnZOUI1RHRY7PWJ28pKKXVjYjoEtmfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786619763; c=relaxed/simple; bh=eCtC6QgWZJI49Osw7++8fZemrdIWgMW8ibmZR93kf9E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Cg4ljf1aImhTJTqF8zgjhgUbm/8rrf/jkGkmCrYzorDK9moF7vTBh7MaPf3FQ7o/MfkWDyCW11L32OFSGnKro4FkayyTM7vM2FidJfau0rb7QhwVI11Qaon86iWsy7w6xquR/gDvr2O4M+/pBkt9LDtK95VthWeeIkNcAf1HRiY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=egkcsgmX; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=p15V5/nm; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="egkcsgmX"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="p15V5/nm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786619755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eCtC6QgWZJI49Osw7++8fZemrdIWgMW8ibmZR93kf9E=; b=egkcsgmX6tbGaG5Xta4xTkVquNee7IzJqk52MqkQsCPUVhVZNOOohtZ8I1h6WTWspARx0h uJOaMvTahaFtCsl9833YYwc9ld+8rIJm03f0dm8oXLsNdF3PFxBhMjH4BWfB6x0uJ+mJq6 /F6UnOyCEMgBjD/18d3i6XJMzT4Lg3U= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-492-FgOjEzq_M0e5yL8Xf5UvJw-1; Thu, 13 Aug 2026 07:15:54 -0400 X-MC-Unique: FgOjEzq_M0e5yL8Xf5UvJw-1 X-Mimecast-MFC-AGG-ID: FgOjEzq_M0e5yL8Xf5UvJw_1786619754 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c0408254aso13621721cf.0 for ; Thu, 13 Aug 2026 04:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1786619754; x=1787224554; darn=vger.kernel.org; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=eCtC6QgWZJI49Osw7++8fZemrdIWgMW8ibmZR93kf9E=; b=p15V5/nmCx7YfVZt38+gstLpHktrhVcwEispL7N9eP9nMLI8B/XUNB/QflDbjoC3dH Yr96B4Jf8OajlDulHNe6i8QeiuJWUOIz/nleBp/BSDpqGNcS3cSjrUsbrD05HCsbz7Zk aoXLf3dv1LRl7ZPqSxEqBm2D+jaVJaZhzno+jx3a8gy2Th2OdrNHYHvEc+5vltPckxvN Qp0SusYpNz0KTnvkhFe3jPrAFdOiA5bQhMY2x3ALSqubrTkfEWOYzEDHmgd+iC8Uwh6i ZBTf1z007k/PK5tncuDJZ50axq2nP6KPjQTDO76LJbcP1F+gGCqH6lEc/hXMlDD6W1Qo Xeww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786619754; x=1787224554; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=eCtC6QgWZJI49Osw7++8fZemrdIWgMW8ibmZR93kf9E=; b=Kh2hrgaKTdy3TKHQq+0ppkh+8U5tqaz1ua/p5OA3Tum5BuHImH6p7D6VtEnKeSuL97 UqSQk2LzC5Ax/hLZT5pzPeVNlylMoLv1b3FFqwEN1aSkRcD1MH5gV1AosK/yroXSC8Yh 7qzuQhCo4em6DpXSzBhCStB5oxZwn1haiZoqVw9A2ax28bLNa0viKDdegopco8HfiGQu YOcfxnowZkyQUvNty18cpL2zqU+kYzJKs53TaQr85WTrqcOs3ZvCx4COw4mNn+ToEuPe D3sp1slMl3XN3f9xOfyJ/4GVOYvOSJc+B9gvf8l+uS9rzSsqPIbglcXQIUj0VSHUXqZw tnKw== X-Forwarded-Encrypted: i=1; AHgh+RquQX394EfNvDKX2awTMXqug5Nms05xOwcOS73I0+WYOQ9YPeeuJP/DPC69xgZj7Bz/KcmA7YnStICG040=@vger.kernel.org X-Gm-Message-State: AOJu0YzkqfLcpuwmXiYsUOCzpINlf2h4ukQacUs3ofWugbdoBZhgeFqb k6NTXmNEDCXsQZwWEaRCzGLiLhcZgXmAyQ8/nHR1RtwF43XThwtMPaz0Ctp6GC6qJBTjmlH7UVS 1wu61yKuHzhbGnsTy+ua1VGyCytylGYUWLHqyRWhUSoq96VXv4c1AmSlTnwgHGLkYoA== X-Gm-Gg: AR+sD12B0fIWgnEtEf0h+sKxPucl47JjrvYkyh82lpqeV5UYg8NGtVCZ9nW1jqSmmDK P2bcFqi0BML4RK9ROmQwUEtEJg1nz0zGs5MrhQScsxGZ2ag/SmJHXIxsqkcw0uNT3TTaY9NvIep Cd+iX/MBoW3rOVzDQ3rVYRH0ta5E5IGGKKnoyDO6rSuMfawySJlhB8+qGx/AUwTA2L0o+Kfa654 X4LibNCHndf7zTB+x6gvcRH4FPlbHWlt3lt1WmN3VwxwRlJbO5Yo/jlKfyhEBei9d+2Fsvf2BSH TLy8t84Xu0Q4e6h7DjpiFsYDsoZIYbKOiYxM3fwPBP86WiyT9l4yWGNPK77VOxAiQv3HR5U40SO RBe3xnI5wgwIn1fzPBCMQo3NiM19D X-Received: by 2002:a05:622a:590a:b0:51b:9873:e37b with SMTP id d75a77b69052e-52d751c7c1dmr41466671cf.9.1786619753848; Thu, 13 Aug 2026 04:15:53 -0700 (PDT) X-Received: by 2002:a05:622a:590a:b0:51b:9873:e37b with SMTP id d75a77b69052e-52d751c7c1dmr41466021cf.9.1786619753443; Thu, 13 Aug 2026 04:15:53 -0700 (PDT) Received: from aconole-thinkpadt14gen4.rmtusnh.csb ([216.212.25.12]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52d73fb89c0sm14535951cf.18.2026.08.13.04.15.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 04:15:53 -0700 (PDT) From: Aaron Conole To: Minxi Hou Cc: netdev@vger.kernel.org, davem@davemloft.net, dev@openvswitch.org, echaudro@redhat.com, edumazet@google.com, horms@kernel.org, i.maximets@ovn.org, i.maximets@redhat.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, pabeni@redhat.com, shuah@kernel.org Subject: Re: [PATCH net-next v10] selftests/net/openvswitch: add SCTP flow key support and test In-Reply-To: <20260811181645.1918420-1-houminxi@gmail.com> (Minxi Hou's message of "Tue, 11 Aug 2026 14:16:45 -0400") References: <20260811181645.1918420-1-houminxi@gmail.com> Date: Thu, 13 Aug 2026 07:15:51 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Minxi Hou writes: > The ovskey flow-string parser has no OVS_KEY_ATTR_SCTP entry, so a > flow string containing sctp(src=.../dst=...) parses without error but > silently drops the L4 key. The resulting flow carries only > ipv4(proto=132), and the kernel rejects it: match_validate() in > flow_netlink.c requires OVS_KEY_ATTR_SCTP when the IP protocol is > IPPROTO_SCTP and returns -EINVAL for the missing key. > > Register OVS_KEY_ATTR_SCTP in the parse table and add a matching > selftest that verifies SCTP flow key matching (sctp src/dst port). > > One listener serves the whole test. socat's fork option handles each > association in a child, so the flow rules are the only thing that > changes between the three phases and the listener is never restarted > underneath them. -t 1 bounds how long a forked child lingers after > its association closes, and the existing kill -TERM of the captured > pid on teardown removes the listener itself. > > Also enable CONFIG_IP_SCTP in the selftest kernel config. The config > checker strips underscores before comparing keys, so the entry sorts > before CONFIG_IPV6 rather than after it. > > Signed-off-by: Minxi Hou > --- Reviewed-by: Aaron Conole