From: Andrew Lunn <andrew@lunn.ch>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Tao Ren <rentao.bupt@gmail.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Tao Ren <taoren@meta.com>
Subject: Re: [PATCH v4 11/13] ARM: dts: aspeed: facebook-fuji: Include facebook-fuji-data64.dts
Date: Tue, 14 Oct 2025 17:11:22 +0200 [thread overview]
Message-ID: <f801a4cb-3d27-439c-82f2-d5ee5aa0d810@lunn.ch> (raw)
In-Reply-To: <4e099ead-e6df-4489-a775-1730bc852dcf@roeck-us.net>
> > If it is already in mainline, i don't care too much if it is wrong. We
> > don't want to cause regressions.
> >
> > I only object when adding new nodes which are wrong. If we keep adding
> > broken nodes, there is no incentive to fix the broken driver to do the
>
> This wasn't adding an allegedly (sorry, it worked for me) broken node,
> it was removing one that worked for me all along. Obviously I do not know
> if it worked (or if it is even used) on real hardware, but it worked for
> the fuji-bmc qemu emulation.
It probably does work on real hardware, because it is one of those
"two wrongs makes a right" cases. So i see this as a regression. The
node should not be removed. It should hopefully get corrected sometime
in the future when somebody actually fixes the aspeed driver, and
fixes both wrongs.
Andrew
next prev parent reply other threads:[~2025-10-14 15:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 5:56 [PATCH v4 00/13] ARM: dts: aspeed: Add Meta Darwin dts rentao.bupt
2025-07-28 5:56 ` [PATCH v4 01/13] ARM: dts: aspeed: wedge400: Fix DTB warnings rentao.bupt
2025-07-28 5:56 ` [PATCH v4 02/13] ARM: dts: aspeed: fuji: " rentao.bupt
2025-07-28 5:56 ` [PATCH v4 03/13] ARM: dts: aspeed: Fix DTB warnings in ast2600-facebook-netbmc-common.dtsi rentao.bupt
2025-07-28 5:56 ` [PATCH v4 04/13] ARM: dts: aspeed: Move eMMC out of ast2600-facebook-netbmc-common.dtsi rentao.bupt
2025-07-28 5:56 ` [PATCH v4 05/13] ARM: dts: aspeed: Add facebook-bmc-flash-layout-128-data64.dtsi rentao.bupt
2025-07-28 5:56 ` [PATCH v4 06/13] dt-bindings: arm: aspeed: add Facebook Wedge400-data64 board rentao.bupt
2025-07-28 5:56 ` [PATCH v4 07/13] ARM: dts: aspeed: Add Facebook Wedge400-data64 (AST2500) BMC rentao.bupt
2025-07-28 5:56 ` [PATCH v4 08/13] ARM: dts: aspeed: wedge400: Include wedge400-data64.dts rentao.bupt
2025-07-28 5:56 ` [PATCH v4 09/13] dt-bindings: arm: aspeed: add Facebook Fuji-data64 board rentao.bupt
2025-07-30 20:55 ` Rob Herring (Arm)
2025-07-28 5:56 ` [PATCH v4 10/13] ARM: dts: aspeed: Add Facebook Fuji-data64 (AST2600) Board rentao.bupt
2025-07-28 5:56 ` [PATCH v4 11/13] ARM: dts: aspeed: facebook-fuji: Include facebook-fuji-data64.dts rentao.bupt
2025-10-14 0:20 ` Guenter Roeck
2025-10-14 1:15 ` Tao Ren
2025-10-14 3:20 ` Guenter Roeck
2025-10-14 3:44 ` Guenter Roeck
2025-10-14 4:09 ` Tao Ren
2025-10-14 4:35 ` Guenter Roeck
2025-10-14 4:45 ` Tao Ren
2025-10-14 12:08 ` Andrew Lunn
2025-10-14 14:49 ` Guenter Roeck
2025-10-14 15:11 ` Andrew Lunn [this message]
2025-10-14 16:39 ` Guenter Roeck
2025-10-14 19:14 ` Andrew Lunn
2025-10-14 22:39 ` Tao Ren
2025-10-15 0:12 ` Andrew Lunn
2025-07-28 5:56 ` [PATCH v4 12/13] dt-bindings: arm: aspeed: add Facebook Darwin board rentao.bupt
2025-07-28 5:56 ` [PATCH v4 13/13] ARM: dts: aspeed: Add Facebook Darwin (AST2600) BMC rentao.bupt
2025-07-31 3:32 ` [PATCH v4 00/13] ARM: dts: aspeed: Add Meta Darwin dts Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f801a4cb-3d27-439c-82f2-d5ee5aa0d810@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rentao.bupt@gmail.com \
--cc=robh@kernel.org \
--cc=taoren@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®