From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Vivek.Pernamitta@quicinc.com, Manivannan Sadhasivam <mani@kernel.org>
Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vivek Pernamitta <quic_vpernami@quicinc.com>
Subject: Re: [PATCH v2 5/5] bus: host: mhi: Need to honor sys_err at power_up state
Date: Thu, 10 Jul 2025 14:46:51 +0200 [thread overview]
Message-ID: <f80d4e32-0f28-4a90-9db4-05c95e260658@oss.qualcomm.com> (raw)
In-Reply-To: <20250710-sriov_vdev_next-20250630-v2-5-4bd862b822e8@quicinc.com>
On 7/10/25 10:58 AM, Vivek.Pernamitta@quicinc.com wrote:
> From: Vivek Pernamitta <quic_vpernami@quicinc.com>
>
> In mhi_sync_power_up() host waits for device to enter in to mission mode
> but SYS_ERR is an valid state, If device sends an SYS_ERR host will bail
> out for wait_event_timeout() as MHI is in error state and if MHI is tear
> downed sys err cant't be serviced and mhi can't be recovered.
>
> If there is any SYS_ERR, sys_err handler needs to process SYS_ERR state
> and queues the next state transition for device to bring in to Mission
> mode, so mhi_sync_power_up() needs to wait for device to enter in to
> mission mode.
This is very difficult to read, please rephrase the commit message
Konrad
next prev parent reply other threads:[~2025-07-10 12:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 8:58 [PATCH v2 0/5] bus: mhi: host: Enable SRIOV support in MHI driver Vivek.Pernamitta
2025-07-10 8:58 ` [PATCH v2 1/5] bus: mhi: host: Add support for separate controller configurations for VF and PF Vivek.Pernamitta
2025-07-10 8:58 ` [PATCH v2 2/5] bus: mhi: host: pci_generic: Read SUBSYSTEM_VENDOR_ID for VF's to check status Vivek.Pernamitta
2025-08-06 16:59 ` Manivannan Sadhasivam
2025-08-07 7:09 ` Krishna Chaitanya Chundru
2025-08-07 8:13 ` Manivannan Sadhasivam
2025-08-07 8:15 ` Krishna Chaitanya Chundru
2025-08-07 8:26 ` Manivannan Sadhasivam
2025-07-10 8:58 ` [PATCH v2 3/5] bus: mhi: host: pci_generic: Remove MHI driver and ensure graceful device recovery Vivek.Pernamitta
2025-07-10 12:42 ` Konrad Dybcio
2025-07-23 12:11 ` Vivek Pernamitta
2025-07-23 12:51 ` Konrad Dybcio
2025-08-06 17:28 ` Manivannan Sadhasivam
2025-07-10 8:58 ` [PATCH v2 4/5] bus: mhi: host: pci_generic: Add SRIOV support for PCIe device Vivek.Pernamitta
2025-07-10 12:43 ` Konrad Dybcio
2025-07-10 8:58 ` [PATCH v2 5/5] bus: host: mhi: Need to honor sys_err at power_up state Vivek.Pernamitta
2025-07-10 12:46 ` Konrad Dybcio [this message]
2025-08-06 17:32 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f80d4e32-0f28-4a90-9db4-05c95e260658@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=Vivek.Pernamitta@quicinc.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=quic_vpernami@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®