From: Felix Yan <felixonmars@archlinux.org>
To: kbusch@kernel.org, highenthalpyh@gmail.com,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: xuwd1@hotmail.com
Subject: Re: [PATCH v2] nvme-pci: add NVME_QUIRK_DELAY_BEFORE_CHK_RDY for MAXIO MAP1602
Date: Fri, 8 Sep 2023 19:07:15 +0300 [thread overview]
Message-ID: <f80e9412-eaec-467f-8b18-b128df31ae17@archlinux.org> (raw)
In-Reply-To: <20230907183605.631347-1-felixonmars@archlinux.org>
[-- Attachment #1.1: Type: text/plain, Size: 533 bytes --]
Hi,
I think I have found a better solution. Instead of adding quirks, the
NVME_CRTO_CRWMT value is not really trustworthy when CRTO is zeroed.
Luckily the NVME 2.0 spec does have word on this situation: "Software
should not rely on 0h being returned".
I have put together another patch to supersede this one in
[PATCH] nvme-pci: ignore bogus CRTO according to NVME 2.0 spec
(This is still my first time kernel contribution. Please do correct me
if I am doing anything wrong. Thanks!)
--
Regards,
Felix Yan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2023-09-08 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 18:36 Felix Yan
2023-09-08 16:07 ` Felix Yan [this message]
2023-10-03 0:11 ` [PATCH] nvme-pci: Add quirk for Netac NV7000-T Lucas Gabriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f80e9412-eaec-467f-8b18-b128df31ae17@archlinux.org \
--to=felixonmars@archlinux.org \
--cc=highenthalpyh@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=xuwd1@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®