From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Elson Serrao <elson.serrao@oss.qualcomm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Souradeep Chowdhury <quic_schowdhu@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/9] usb: misc: qcom_eud: add host mode coordination
Date: Wed, 4 Feb 2026 14:29:44 +0100 [thread overview]
Message-ID: <f8169943-f986-4e9d-9d3b-a470e57f5e6a@oss.qualcomm.com> (raw)
In-Reply-To: <20260126233830.2193816-7-elson.serrao@oss.qualcomm.com>
On 1/27/26 12:38 AM, Elson Serrao wrote:
> EUD functions by presenting itself as a USB device to the host PC for
> debugging, making it incompatible in USB host mode configurations.
> Enabling EUD, when in host mode can also cause the USB controller to
> misbehave as the EUD hub can only have one upstream facing port.
Perhaps that's a silly idea, but would the device itself see
the debug hub, being able to essentially self-debug in a way?
[...]
> @@ -162,32 +165,66 @@ static ssize_t enable_store(struct device *dev,
> const char *buf, size_t count)
> {
> struct eud_chip *chip = dev_get_drvdata(dev);
> + struct eud_path *path;
> bool enable;
> int ret;
>
> if (kstrtobool(buf, &enable))
> return -EINVAL;
>
> + mutex_lock(&chip->state_lock);
If you use guard(mutex)(&chip->state-lock), you can waive all these
conditional mutex_unlock additions
> +
> /* Skip operation if already in desired state */
> - if (chip->enabled == enable)
> + if (chip->enabled == enable) {
> + mutex_unlock(&chip->state_lock);
> return count;
> + }
> +
> + /*
> + * Handle double-disable scenario: User is disabling EUD that was already
> + * disabled due to host mode. Since the hardware is already disabled, we
> + * only need to clear the host-disabled flag to prevent unwanted re-enabling
> + * when exiting host mode. This respects the user's explicit disable request.
> + */
> + if (!enable && chip->eud_disabled_for_host) {
> + chip->eud_disabled_for_host = false;
> + chip->enabled = false;
> + mutex_unlock(&chip->state_lock);
> + return count;
> + }
>
> if (enable) {
> + /*
> + * EUD functions by presenting itself as a USB device to the host PC for
> + * debugging, making it incompatible in USB host mode configuration.
> + * Prevent enabling EUD in this configuration to avoid hardware conflicts.
> + */
> + path = chip->paths[chip->port_idx];
> + if (path && path->curr_role == USB_ROLE_HOST) {
> + dev_err(chip->dev, "EUD not usable in host mode configuration\n");
"in USB host mode"?
[...]
> + /*
> + * EUD must be disabled when USB operates in host mode. EUD functions by
> + * presenting itself as a USB device to the host PC for debugging, making
> + * it incompatible in host mode configuration.
^ with
Otherwise the logic looks good, I think this may be desired default
behavior (so that the user doesn't have to constantly keep re-enabling
EUD)
Konrad
next prev parent reply other threads:[~2026-02-04 13:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 23:38 [PATCH v2 0/9] Improve Qualcomm EUD driver and platform support Elson Serrao
2026-01-26 23:38 ` [PATCH v2 1/9] dt-bindings: soc: qcom: eud: Restructure to model multi-path hardware Elson Serrao
2026-02-03 13:35 ` Konrad Dybcio
2026-02-04 14:01 ` Konrad Dybcio
2026-02-06 14:55 ` Rob Herring
2026-02-10 4:32 ` Elson Serrao
2026-02-10 7:24 ` Krzysztof Kozlowski
2026-01-26 23:38 ` [PATCH v2 2/9] usb: misc: qcom_eud: add sysfs attribute for port selection Elson Serrao
2026-01-27 13:31 ` Konrad Dybcio
2026-01-26 23:38 ` [PATCH v2 3/9] usb: misc: qcom_eud: add per-path High-Speed PHY control Elson Serrao
2026-02-04 13:21 ` Konrad Dybcio
2026-02-09 17:23 ` Elson Serrao
2026-01-26 23:38 ` [PATCH v2 4/9] usb: misc: qcom_eud: add per-path role switch support Elson Serrao
2026-01-26 23:38 ` [PATCH v2 5/9] usb: misc: qcom_eud: improve enable_store API Elson Serrao
2026-02-04 13:24 ` Konrad Dybcio
2026-01-26 23:38 ` [PATCH v2 6/9] usb: misc: qcom_eud: add host mode coordination Elson Serrao
2026-02-04 13:29 ` Konrad Dybcio [this message]
2026-02-09 17:37 ` Elson Serrao
2026-02-10 10:00 ` Konrad Dybcio
2026-01-26 23:38 ` [PATCH v2 7/9] usb: misc: qcom_eud: fix virtual attach/detach event handling Elson Serrao
2026-02-04 13:32 ` Konrad Dybcio
2026-01-26 23:38 ` [PATCH v2 8/9] arm64: dts: qcom: kodiak: Align EUD node with binding Elson Serrao
2026-01-26 23:38 ` [PATCH v2 9/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable EUD debug functionality Elson Serrao
2026-02-03 13:38 ` Konrad Dybcio
2026-02-09 17:06 ` Elson Serrao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8169943-f986-4e9d-9d3b-a470e57f5e6a@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elson.serrao@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_schowdhu@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®