From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f225.google.com (mail-pl1-f225.google.com [209.85.214.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5EB423A566 for ; Thu, 30 Apr 2026 15:21:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777562493; cv=none; b=LQnx/QehfNnunyXQUNAPG64Ku1rGET+8ypKVsxhn7mOfZf3LfLMw6DjdfuAeNKDfq9VTPvMxmDkQDusUkqMiZfzwwbTKGz/ZP8IMf818ul8Sop3dG0voOPch8jKCGv8h62UT8N1DqMIz2uP1jVPU09TlRYIR/7rU9tDmQIhhKjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777562493; c=relaxed/simple; bh=jfvurasXyO172rf8RueovQ21HocKi4qC6cmZUk6WC5A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Wg+JwiBcBvkU+0t4DswxAUsu6SWOJu6PoSqiYPHz2fi1zVm831DJ9tC1f5tbr5oNsAwzQdQDFaHCi6cerzJlH1qTEatU4RyBGXiNGF8l5N6iP/P1JbVLY0oK9pm+GHQFmepsEyRPAZ/+wBaOaX47bQUY4sjRyKVDSAXQ9b+lRRk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=XL3GSlXM; arc=none smtp.client-ip=209.85.214.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="XL3GSlXM" Received: by mail-pl1-f225.google.com with SMTP id d9443c01a7336-2a7a9b8ed69so9752245ad.2 for ; Thu, 30 Apr 2026 08:21:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777562491; x=1778167291; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j6W7N3TF0u0m9VhuQZcYonFJHVZpaP1eZOWODDM2/uM=; b=NZ0T6f9YrcMfvfeuPTDYQs+x2CeJFz86NeoC1OKsTQpenvlHchFT4grcYICBAFXBAF EJzfKqsWeqqLwJmkUKMorxra19GZ7xWughE7iI5LCu8Yf1QfSfEqmrXOxlpDoppY5R7V qoIKTQvWYL41txS4snScy/MDx46+H8Uau3BksK3BDJF+Vmi0AzpArP+fSR4fxNnFKzK2 lSSJalX2QU+Gv5ljHmj26W4MDuHXknCKXaIhEtOCNWqtlOOlTvxJBO0dW10uErmgccum tZm3GTM+QX3/T6hlmldTMzta8iUC187QOcBJ603xhbzFRGfkKmlGIeWKzQv8Iy30if0q SiNw== X-Forwarded-Encrypted: i=1; AFNElJ/v3ZlzqallQadR4HoveENOJyBDERlIAd1oHukUqiP/awTHtYgiZG7wy3UQgG9B6QQ5BDyJGui5MPp39rY=@vger.kernel.org X-Gm-Message-State: AOJu0YyeKhOsFt0uTmsJb7qlc/fkBoMqHu3F0vLwqrPWDKllOaojmO1q tCTkD8TNjwzOxi8mtBK8hE04VSfbjD88QX2qOrFzBRRMVdaOtDUFTnij+1WJPjGOgmPmPAhBfRt iaLWMQK5DWFEdKF7jx/+f00VCcH35joFWDeBahEDBGocyj5GwghuBdcK5dol7Pz5jKV7AmwEy/S PeFkai+etCkClfMOsareEuz1cImnzc1+x56mKGaWrIBsitdO+HtMP/Li46bTUlBVZ8qG0d0XiYX HciUcFh25C52xzP0k7OFnYh5A== X-Gm-Gg: AeBDiesVGSkVwU9pylNzJgJ9Jgg7EAga65NHFVO9lk9kvY2i6LFI4ZGOTuLxVvYB/MY 1ffNQSS7gctChmgFG9uKpwoUUhQtUeIU7h5kRHbyx4EkqYqxQQDrZPwzkoTSv5VkhShK/G1DHjf OwyJE+RlEdFdfpMGHHnFidcmQK/u+Omz9/RZ0sCiLGu9mPIFHmUclw/2YMPVd6YNnSszVKoec7g h09zT8rj22fqvljkJ57L2KKZ8+XLHkjF9CUUjbVcKyNV59sHWBwPH4+vStcg8JYmyk79gs2LHq+ 9pqJaY9xXX+LRW3VQjfAwMy7wzJm2BEVJWORa38TDfuPOKeio4KnsEdTmrrJYWCw7Gd4s11/qP2 SBw/EXtpZym2YKEf/2VaVfW4+bIDoekXDxT3YR/AbLO4saChKLLTooKGj7JjeGmjfcQVwisG5Yv ZtrTP7iSNHEs+fjy3QQ4pWDpFiN1QKsv4SqwJcDPGQCmgqbpfv5kcYjQJVgZchmG0pbLK+VOo= X-Received: by 2002:a17:903:38cc:b0:2b4:5ddf:24f with SMTP id d9443c01a7336-2b9a2326a95mr36022765ad.10.1777562491192; Thu, 30 Apr 2026 08:21:31 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-16.dlp.protect.broadcom.com. [144.49.247.16]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2b9ca99f45fsm14495ad.7.2026.04.30.08.21.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Apr 2026 08:21:31 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-12c20d5d7f4so4085128c88.1 for ; Thu, 30 Apr 2026 08:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1777562489; x=1778167289; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j6W7N3TF0u0m9VhuQZcYonFJHVZpaP1eZOWODDM2/uM=; b=XL3GSlXMjiOaM6rc98u1XvcNLNpkwVMS57FpMNur7lT5lRNs+GHTXcrvsDRhziyTT9 F9Q5+RHd7w2MWC193xrNTIefATjqS/T3QeWO0sDhSgw/XnFGGI+Wj0ZK3SsJoRwMLjN1 v8HWlAxOJp5iW6aQLv+aFGlfXlf3gwm0NdxPs= X-Forwarded-Encrypted: i=1; AFNElJ+UaPg2upo9mq8YUhhogNF7n5lonsj76qeA8shmjrKPupVEE4hq+SIt77TYKwCUduBTPol+cMoYE1yU/ic=@vger.kernel.org X-Received: by 2002:a05:7300:fd03:b0:2d9:7bc4:9578 with SMTP id 5a478bee46e88-2ed3e386a41mr1602785eec.28.1777562094249; Thu, 30 Apr 2026 08:14:54 -0700 (PDT) X-Received: by 2002:a05:7300:fd03:b0:2d9:7bc4:9578 with SMTP id 5a478bee46e88-2ed3e386a41mr1602745eec.28.1777562093564; Thu, 30 Apr 2026 08:14:53 -0700 (PDT) Received: from [192.168.178.26] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ee38e71ccesm286774eec.10.2026.04.30.08.14.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 08:14:52 -0700 (PDT) Message-ID: Date: Thu, 30 Apr 2026 17:14:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: Consistently define pci_device_ids using named initializers To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , Michael Grzeschik , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marc Kleine-Budde , Vincent Mailhol , Krzysztof Halasa , Johannes Berg Cc: Markus Schneider-Pargmann , Steffen Klassert , David Dillow , Ion Badulescu , Mark Einon , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Ido Schimmel , Sudarsana Kalluru , Manish Chopra , Potnuri Bharat Teja , Denis Kirjanov , Jijie Shao , Jian Shen , Cai Huoqing , Fan Gong , Tony Nguyen , Przemek Kitszel , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Petr Machata , Yibo Dong , Simon Horman , Heiner Kallweit , nic_swsd@realtek.com, Jiri Pirko , Francois Romieu , Daniele Venzano , Samuel Chessman , Jiawen Wu , Mengyuan Lou , Kevin Curtis , Stanislav Yakovlev , Richard Cochran , Kees Cook , Thomas Gleixner , Thomas Fourier , Ingo Molnar , Kory Maincent , Zilin Guan , Marco Crivellari , Vadim Fedorenko , Jacob Keller , Philipp Stanner , Bjorn Helgaas , Yeounsu Moon , Denis Benato , Peiyang Wang , Yonglong Liu , Andy Shevchenko , Yicong Hui , Randy Dunlap , MD Danish Anwar , Nathan Chancellor , Sai Krishna , Ethan Nelson-Moore , Larysa Zaremba , Joe Damato , Double Lo , Chi-hsien Lin , Colin Ian King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, linux-parisc@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@corigine.com, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com References: <20260428171845.2288395-2-u.kleine-koenig@baylibre.com> Content-Language: en-US From: Arend van Spriel In-Reply-To: <20260428171845.2288395-2-u.kleine-koenig@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 28/04/2026 19:18, Uwe Kleine-König (The Capable Hub) wrote: > ... and PCI device helpers. > > The various struct pci_device_id arrays were initialized mostly by one > the PCI_DEVICE macros and then list expressions. The latter isn't easily > readable if you're not into PCI. Using named initializers is more > explicit and thus easier to parse. > > Also use PCI_DEVICE* helper macros to assign .vendor, .device, > .subvendor and .subdevice where appropriate and skip explicit > assignments of 0 (which the compiler takes care of). > > The secret plan is to make struct pci_device_id::driver_data an > anonymous union (similar to > https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@baylibre.com/) > and that requires named initializers. But it's also a nice cleanup on > its own. > > This change doesn't introduce changes to the compiled pci_device_id > arrays. Tested on x86 and arm64. for brcmfmac change... Acked-by: Arend van Spriel > Signed-off-by: Uwe Kleine-König (The Capable Hub) > --- [...] > .../broadcom/brcm80211/brcmfmac/pcie.c | 17 +- > drivers/net/wireless/intel/ipw2x00/ipw2200.c | 52 +- > 69 files changed, 1308 insertions(+), 1101 deletions(-)