mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche@wdc.com>
To: "Bean Huo (beanhuo)" <beanhuo@micron.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: UFS writing request failure handling
Date: Mon, 12 Feb 2018 10:13:26 -0800	[thread overview]
Message-ID: <f81bf6c9-fe46-344a-15cb-03867c9e7c6c@wdc.com> (raw)
In-Reply-To: <2a98182c0eed4f0d9615982dc3733024@SIWEX5A.sing.micron.com>

On 02/12/18 04:21, Bean Huo (beanhuo) wrote:
> I am looking at UFS error handling, but I didn't notice re-issues
> requests with UTP error to the host controller. According UFS host
> spec, "host software either completes the request that had the error
> and requests still outstanding with error to higher level software,
> or re-issues these requests to the host controller". For the latest
> Linux UFS driver, it belongs to former one? If I am wrong, please
> correct me.

Hello Bean,

I'm afraid that reissuing a failed write forever could cause an infinite 
loop that makes e.g. user space processes unkillable or that could cause 
an orderly system shutdown to hang. I'm not sure that we want such behavior.

If you want to learn more about how the SCSI core handles failed writes, 
please have a look at scsi_decide_disposition(). A possible approach to 
modify the error handling behavior is to stack a dm driver on top of the 
SCSI core that implements the desired behavior.

Bart.

  reply	other threads:[~2018-02-12 18:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 12:21 Bean Huo (beanhuo)
2018-02-12 18:13 ` Bart Van Assche [this message]
2018-02-13 15:18 Bean Huo (beanhuo)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f81bf6c9-fe46-344a-15cb-03867c9e7c6c@wdc.com \
    --to=bart.vanassche@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®