From: Florian Fainelli <f.fainelli@gmail.com>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: linux-mips@vger.kernel.org, Paul Cercueil <paul@crapouillou.net>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MIPS: Ingenic: Allow assembler reordering in the XBurst secondary entry
Date: Fri, 20 Nov 2026 10:13:16 -0800 [thread overview]
Message-ID: <f82422b6-20ca-4c47-b420-156ae6912dd3@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2611201404490.54328@angie.orcam.me.uk>
On 11/20/26 06:06, Maciej W. Rozycki wrote:
> On Thu, 19 Nov 2026, Florian Fainelli wrote:
>
>> Remove .set noreorder and the two explicit delay-slot nops from the
>> XBurst secondary CPU reset entry. GNU as emits identical reset-entry
>> instructions with reordering enabled in both the CI20 and generic
>> MIPS64r2 Ingenic SMP builds.
>>
>> On CI20, two baseline and three updated cold boots brought both CPUs
>> online. Each boot passed the CPU affinity check and 100 cross-core
>> idle-wakeup round trips in each direction. Codex assisted with the
>> assembly comparison and hardware test campaign.
>>
>> Suggested-by: Maciej W. Rozycki <macro@orcam.me.uk>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>> Thomas, feel free to fixup into "MIPS: Ingenic: Add XBurst SMP support"
>> if that is simpler. Thanks!
>
> Have you compared objects produced to be the same with and without the
> change applied? If they are, then:
Yes I did and they were the same.
>
> Reviewed-by: Maciej W. Rozycki <macro@orcam.me.uk>
>
> Thanks for this follow-up cleanup.
Of course, thanks for all of your excellent feedback as usual!
--
Florian
next prev parent reply other threads:[~2026-11-20 18:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 5:08 Florian Fainelli
2026-11-20 14:06 ` Maciej W. Rozycki
2026-11-20 18:13 ` Florian Fainelli [this message]
2026-11-20 15:00 ` David Laight
2026-11-20 16:14 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f82422b6-20ca-4c47-b420-156ae6912dd3@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=paul@crapouillou.net \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®