From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752991AbdEDJYs (ORCPT ); Thu, 4 May 2017 05:24:48 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36366 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753298AbdEDJVf (ORCPT ); Thu, 4 May 2017 05:21:35 -0400 Subject: Re: [PATCH 2/3] nVMX: Implement emulated Page Modification Logging To: Bandan Das , kvm@vger.kernel.org References: <20170503221457.18869-1-bsd@redhat.com> <20170503221457.18869-3-bsd@redhat.com> Cc: linux-kernel@vger.kernel.org From: Paolo Bonzini Message-ID: Date: Thu, 4 May 2017 11:21:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170503221457.18869-3-bsd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/05/2017 00:14, Bandan Das wrote: > + if (vmx->nested.pml_full) { > + exit_reason = EXIT_REASON_PML_FULL; > + vmx->nested.pml_full = false; > + } else if (fault->error_code & PFERR_RSVD_MASK) > exit_reason = EXIT_REASON_EPT_MISCONFIG; > else > exit_reason = EXIT_REASON_EPT_VIOLATION; > + /* > + * The definition of bit 12 for EPT violations and PML > + * full event is the same, so pass it through since > + * the rest of the bits are undefined. > + */ Please zero all other bits instead. It's as easy as adding an "u64 exit_qualification" local variable. Paolo > nested_vmx_vmexit(vcpu, exit_reason, 0, vcpu->arch.exit_qualification);