From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4824CC28CC6 for ; Tue, 4 Jun 2019 15:43:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 214F720717 for ; Tue, 4 Jun 2019 15:43:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="M998QStZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728221AbfFDPnc (ORCPT ); Tue, 4 Jun 2019 11:43:32 -0400 Received: from mail-pg1-f173.google.com ([209.85.215.173]:43439 "EHLO mail-pg1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728063AbfFDPnc (ORCPT ); Tue, 4 Jun 2019 11:43:32 -0400 Received: by mail-pg1-f173.google.com with SMTP id f25so10578961pgv.10 for ; Tue, 04 Jun 2019 08:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1tqQUYkCiTPuRzyCy9UBEdirWqMAznB0ETrGx/j7ot8=; b=M998QStZ8hrJ2FjhCVVSwN4KLJOgz73IXrSf06GwSHt2Kcyb8QwopbYLocRJJn8Qna 9aoKrKIr+IW0SGQkkLodklP545PgTzJxSr+KqJok3jhl9FZyPtLFpnVr6oTSg/Iy1IFv DCfmBZzmwGb70dSfOxZ04RZQfecnq1skXX2/fjkv/J1WTJQWZCTSGkmY9LtQJoGBvyD2 KB4YUr/Y3kg1wVLYNmcI9f16MnhS9TzjSFehLMAdTUsFM836NLGXci80US8XQ1yxMzbQ tOeOd8a2kGtBHuMrCKEyQIIpNZ659MrOaooDKXkFMJgyeOgq1Nj6DxUSmWmY7LnW6aXi q73Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1tqQUYkCiTPuRzyCy9UBEdirWqMAznB0ETrGx/j7ot8=; b=g05YgTqzQYj05jUJSVKMcmv3YRSOOBp/74Jt1n+iKhoX8QBpmU7tg6OH78HvKLl7mt lDg5VXciS+ciy00zN5UmXCzzL0RxQ195bHvpB/niGpLVWNnyaGec9/1zwPssNBvLnkx6 XyDzZkL55XhDFdqRmF7czPSN6udfzS00kT7bhN3bezIOrEaTccu9QZgPJLLaDIw+3rqU DzwOdohaWdhg+CTb6ZjFJM6ZXcd+/DmC/+QKm2fjhH0UO4nKgrsPab5oS0/Ai4OF6uxz jw3Q54xVINAIQKdgozp76jCz6CuoNMETzHFrbbnL5uEXY+lHP1EA/ftxc+DfJAum4yTn JlEQ== X-Gm-Message-State: APjAAAWSVIJvmkhDkwljO28YEp+y1Khhv3GnKDBb3x3yxv81tZJQFMlQ KpLuTddzSf93DGjhuA8CswyAlYrCcN4LvQ== X-Google-Smtp-Source: APXvYqw+0N0zrwtySyXMlKkP0zfzYI5m7MA0xh3RMk9nK5rSOHW7riQreacg0ndGgXI3TCzaBMFfRA== X-Received: by 2002:a62:63c6:: with SMTP id x189mr26994829pfb.31.1559663011107; Tue, 04 Jun 2019 08:43:31 -0700 (PDT) Received: from [192.168.1.158] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id r64sm25606402pfr.58.2019.06.04.08.43.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 08:43:30 -0700 (PDT) Subject: Re: [PATCH][next] blktrace: remove redundant assignment to ret To: Colin King , Steven Rostedt , Ingo Molnar , linux-block@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190604142744.15330-1-colin.king@canonical.com> From: Jens Axboe Message-ID: Date: Tue, 4 Jun 2019 09:43:28 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190604142744.15330-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/4/19 8:27 AM, Colin King wrote: > From: Colin Ian King > > Variable ret is being assigned a value that is never read, hence > the assignment is redundant and can be removed. This doesn't look correct to me, here's the full code: ret = -ENOENT; dir = debugfs_lookup(buts->name, blk_debugfs_root); if (!dir) bt->dir = dir = debugfs_create_dir(buts->name, blk_debugfs_root); if (!dir) goto err; [...] err: [...] return ret; The main issue here, to me, looks like we're not dealing with ERR_PTR returns from debugfs_create_dir(), just checking for NULL. -- Jens Axboe