From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m3293.qiye.163.com (mail-m3293.qiye.163.com [220.197.32.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDA6D1E2823; Sun, 2 Mar 2025 07:15:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.32.93 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740899746; cv=none; b=d5RB7Riaykei2xhMnH0EAoSrOBCkr5aSTHxDnMmc+Y1cX5yxBUK+gHXpUd8S6t4GOi0qfH00T6ONB6WoB8TQuAjVzS91TYL+Ig7DWSGkSJ8glU8NQ4z8dDtSqKcBzzCwxLvWW4/7pNdv1xrTUQOskOr8J8FtaxOgK5+5dcVpT8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740899746; c=relaxed/simple; bh=ziDod9pTnCx8VqIh/26uIBZKiuRQeyCD6/ciVFEaAs8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fgPbGeIR4i0zUFyZA6ltgmYoPHnzyXNZvm9n6Dkd+d9YE+lsd+fgw86HiiGUGSO6CrJMHYEZ8/ysWxKKplQ2vtwlJo02Nix5YJwCfygu4v/jpI8iIoJwBmy3ymOcnlw0DB0rWWFlOIplsr0r6wHTjBfbOQTNmqYYdf4zYXbAuVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=Aqh6ofGa; arc=none smtp.client-ip=220.197.32.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="Aqh6ofGa" Received: from [172.16.12.26] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id ca138e88; Sun, 2 Mar 2025 15:15:30 +0800 (GMT+08:00) Message-ID: Date: Sun, 2 Mar 2025 15:15:30 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 04/15] drm/bridge: analogix_dp: Remove the unnecessary calls to clk_disable_unprepare() during probing To: Doug Anderson Cc: heiko@sntech.de, andy.yan@rock-chips.com, hjc@rock-chips.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, dmitry.baryshkov@linaro.org, sebastian.reichel@collabora.com, cristian.ciocaltea@collabora.com, boris.brezillon@collabora.com, l.stach@pengutronix.de, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250224081325.96724-1-damon.ding@rock-chips.com> <20250224081325.96724-5-damon.ding@rock-chips.com> Content-Language: en-US From: Damon Ding In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGUhPQlYZTx9PSh0YTx4ZSUJWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0 hVSktLVUpCS0tZBg++ X-HM-Tid: 0a9555b5c2df03a3kunmca138e88 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Pjo6Lgw6CzIKHUsaFQsLF0tL OBUKCU9VSlVKTE9LQ0JCTEhKQ01CVTMWGhIXVR8aFhQVVR8SFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFJS0hJNwY+ DKIM-Signature:a=rsa-sha256; b=Aqh6ofGacuT+B/WiOkyQRxEZYkd5NWw7bNn++OmrLNSFR5Y2zQSQ6S4knhbwrlYkwPve/ppWG4WrEx6B3hdO/jgE+1l3hEYxMT3Ah6BXdq2v3svwOMcgcj3L9US+GjHWVgNzBiTwKuNOceJpI6UFEEg1IWwgUjUnBrgLUK7S/mM=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=8d5ejZu4ZY9Y9Zh2+eVlwxl7XvRzlgNDw9s/Y5LNOs0=; h=date:mime-version:subject:message-id:from; Hi Doug, On 2025/2/25 9:40, Doug Anderson wrote: > Hi, > > On Mon, Feb 24, 2025 at 12:14 AM Damon Ding wrote: >> >> With the commit f37952339cc2 ("drm/bridge: analogix_dp: handle clock via >> runtime PM"), the PM operations can help enable/disable the clock. The >> err_disable_clk label and clk_disable_unprepare() operations are no >> longer necessary because the analogix_dp_resume() will not be called >> during probing. >> >> Fixes: f37952339cc2 ("drm/bridge: analogix_dp: handle clock via runtime PM") > > When possible "Fixes" should be pushed to the start of your series so > it's obvious they have no dependencies when being picked to stable > kernels. That should be possible here. > >> Signed-off-by: Damon Ding >> --- >> .../gpu/drm/bridge/analogix/analogix_dp_core.c | 18 +++++------------- >> 1 file changed, 5 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> index e23af674d91c..d9dafb038e7a 100644 >> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c >> @@ -1608,10 +1608,8 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data) >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> >> dp->reg_base = devm_ioremap_resource(&pdev->dev, res); > > There is a context conflict when I apply to drm-misc-next because of > commit 43c00fb1a518 ("drm/bridge: analogix_dp: Use > devm_platform_ioremap_resource()"). You probably should rebase and > re-apply. > > Aside from the context conflict, this looks great to me: > > Suggested-by: Douglas Anderson > Reviewed-by: Douglas Anderson > > After rebasing, I found the conflict. I will move this patch to a separate series and ensure it has no dependencies. Best regards Damon