From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D779C43334 for ; Mon, 13 Jun 2022 15:21:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343934AbiFMPVV (ORCPT ); Mon, 13 Jun 2022 11:21:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242503AbiFMPVA (ORCPT ); Mon, 13 Jun 2022 11:21:00 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59B3312F0D2; Mon, 13 Jun 2022 05:47:10 -0700 (PDT) Received: from [10.10.0.109] (unknown [186.189.224.65]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adalessandro) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9A75C66015BE; Mon, 13 Jun 2022 13:47:04 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1655124428; bh=57qBytTfgYArCi7OQkHwm8tHdu4tMguIIFNnrR6lAiA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CavIbQ/X+EB8IPUuRvUIv/aBeGr+ViCz0T/8yLav8mwNynNt8Lo8syg8VcccGBAaK fWcu7Usu208oAMEnEMO2eVaXjGlyv5q4TskPYS6lgOGxjPfPqB9uSOGNfGNOPLhwkk FVQoOBYTnR1AdfczuWFJAXIiM/xsCTHNJABJbampe4KibeAO6NazI8x32KAI+QuvDF JySMXoCuv05SncucIwhFH1kx2oE69KzW2x0Wop0Taby+RGZgYf9GLHoH7jXdITuqL2 +TGxioM5j30FmJteGniLqVzRi2fmnkZ0yUS63oTnyQjIbGZFrUpWbqnw58NoNvykNO j09J+4MdLcnpg== Message-ID: Date: Mon, 13 Jun 2022 09:46:58 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH] ARM: dts: bcm2711-rpi-4-b: Use aliases to set custom MMC device index Content-Language: en-US To: Peter Robinson Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, gbcm-kernel-feedback-list@broadcom.com, gkrzysztof.kozlowski+dt@linaro.org, gnsaenz@kernel.org, grobh+dt@kernel.org, nsaenz@kernel.org, stefan.wahren@i2se.com References: <20220608123233.13439-1-ariel.dalessandro@collabora.com> From: Ariel D'Alessandro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On 6/12/22 17:38, Peter Robinson wrote: > On Wed, Jun 8, 2022 at 1:35 PM Ariel D'Alessandro > wrote: >> >> Add MMC aliases to ensure that the /dev/mmcblk ID for SD card won't >> change depending on the probe order of the MMC drivers. > > Is the bcm2711-rpi.dtsi a better place for it given there's other > aliases there and it will be consistent across variations? Yes, indeed, it makes sense moving it to bcm2711-rpi.dtsi The other board what will be affected by this alias is the Raspberry Pi Compute Module 4 IO Board, on which emmc2 is the eMMC. However, the alias makes sense, to have that as the first mmc device. Maybe we can add the alias as follows? mmc0 = &emmc2; /* mmcblk0 for eMMC/SD */ Regards, Ariel > >> Signed-off-by: Ariel D'Alessandro >> --- >> arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts >> index 4432412044de..780812542bad 100644 >> --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts >> +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts >> @@ -14,6 +14,10 @@ chosen { >> stdout-path = "serial1:115200n8"; >> }; >> >> + aliases { >> + mmc0 = &emmc2; /* mmcblk0 for SD */ >> + }; >> + >> leds { >> led-act { >> gpios = <&gpio 42 GPIO_ACTIVE_HIGH>; >> -- >> 2.34.1 >> >> >> _______________________________________________ >> linux-rpi-kernel mailing list >> linux-rpi-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel